{"id":2222071,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222071/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-8-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-8-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:30","name":"[v2,08/67] ui/console-vc: fix off-by-one in CSI J 2 (clear entire screen)","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3185f0b6b2938dce579e22f9ef7c34418b037bda","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-8-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222071/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222071/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VejQ6BZD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmpY3bQ7z1yGb\n\tfor ; Sat, 11 Apr 2026 05:20:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHOO-0002pB-Ui; Fri, 10 Apr 2026 15:19:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHON-0002fW-3t\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:47 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOL-0000hy-Cv\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:46 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-133--tHQ7Uw-MFmRZKrGUjduog-1; Fri,\n 10 Apr 2026 15:19:42 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DFF7C1800454\n for ; Fri, 10 Apr 2026 19:19:41 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A5D663000C16; Fri, 10 Apr 2026 19:19:39 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848784;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=XM1LdpvMo/ryUlaKFnRu4IyfjRwCYwSedayje/V4ZLw=;\n b=VejQ6BZD1yWXI2aaT5UFEbzrN4oYyvJ5jA2TUWO0BHqXGd/GjLQWKHdmas6eWt0hCIeWk8\n FqzetEuL+uGigq+8DwPuFvFY/B0UYdgqSQd98hOz2hIgAJrRbkK7LQMvAmE/kkLyeIRlJH\n gMzO0wJbfcMYhtPWpy1U+3SuX8Q9NDg=","X-MC-Unique":"-tHQ7Uw-MFmRZKrGUjduog-1","X-Mimecast-MFC-AGG-ID":"-tHQ7Uw-MFmRZKrGUjduog_1775848782","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:30 +0400","Subject":"[PATCH v2 08/67] ui/console-vc: fix off-by-one in CSI J 2 (clear\n entire screen)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-8-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=972;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=+B++g3vg0UFSP1H5PN6zGwpYWHVJzQ3p7MliDE5OVm0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0TrFwNRtxqIGHKIO5B4Qh+MPxJQDf+heFcV\n N5qGc3iwH6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac\n 5ZjUD/9hdwgtLg6oHtm7DhK1Xyag5w9j/Jc+LGs+45YedptowdhPe+lsnoQaNBqDhCSE51AALXr\n i7UdJwBFhbWuh6Jyblv2jwOs8hZGCYIOFRzZdArJqxGI64DOFaOAMhpVz8f+aNM9Z2v8B314Ano\n NmAolgwk3po84USswCKYj7Rnr3HF8bZPkuKwhHQSABWzEGW9JHnkYU7/YgPWQWCPv9PMplKdZ2R\n cxMDPtykz3kUnkGt8M20sBKb262Nrl8+z13ydVDaE+XaZScMmRkafTFN7Uo7w1zPR0n77HL7AzJ\n 8m5qSCPj03TZ1CzuhMBaHqvWEZj4F7BWCz2IEFYI+x2HkrV/GXe01HOXP1k5K401a7WjtOq6C9C\n NSHS95N9Qp7zcMuerLUKN2/BA1ruJO7C8UwlKIVQUeBLF/aeWC2+Dn/ONBp4bgRoMvuhZ+stX4k\n AtcVFCicrFmG1vHvedzKT63oszhOv66ujLsSt/zgpXFGAUrOrCtYFkvqkd+3YuAwlpnWjywQ8Bt\n jKFwQ2I7dpVTxkSwvpUOIX5veMTC7icL8mJB0Unfy+RqCT2e6oGo8vIuQeBFn+fyQgSIfSBg5i1\n klgtScZDlktXEdbdR98ByDB4EmtrYBOgTTrL/IMxGb8sBwmC+6KK0UlPGn30ee065uKh+qgYQuU\n GSdNUvFijVcmJVQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The loop condition used `y <= s->height` instead of `y < s->height`,\ncausing vc_clear_xy() to be called with y == s->height. This clears\na row in the scrollback buffer beyond the visible screen.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex f22806fed79..8dee1f9bd01 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -899,7 +899,7 @@ static void vc_putchar(VCChardev *vc, int ch)\n break;\n case 2:\n /* clear entire screen */\n- for (y = 0; y <= s->height; y++) {\n+ for (y = 0; y < s->height; y++) {\n for (x = 0; x < s->width; x++) {\n vc_clear_xy(vc, x, y);\n }\n","prefixes":["v2","08/67"]}