{"id":2222069,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222069/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-2-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-2-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:24","name":"[v2,02/67] ui/vnc: clarify intent using buffer_empty() function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"98216c2da7ef934531b91276a37abef6d229fc3f","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-2-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222069/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222069/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iQWewPha;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmpR0ry7z1yGS\n\tfor ; Sat, 11 Apr 2026 05:19:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHNp-0002GR-8D; Fri, 10 Apr 2026 15:19:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHNm-0002Fq-QN\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:10 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHNk-0000Nf-A0\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:09 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-u6iGaDMcO7uhPJyMHa9K7w-1; Fri,\n 10 Apr 2026 15:19:06 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 98A5918002C0\n for ; Fri, 10 Apr 2026 19:19:05 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 555CE3000C1F; Fri, 10 Apr 2026 19:19:03 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848747;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=582Mq7JHgKD89nFbt457ZffKJ0pztKW4k1JqMJhynNw=;\n b=iQWewPhaxqv7b/fxx/wuitKhMbXJEmSFHeyk3rd81UNlKdAFgh9h8bQWu2kwaiDbgNylZp\n t9ZECk7dCcouLuARRs9UiLijFrW2DssdDIYQWKVcprQMySn+RpiMtb3c6BZw7rp/ARuc1Q\n xmX/wnEVsNCzJb8x/yMWmJk0368vOYE=","X-MC-Unique":"u6iGaDMcO7uhPJyMHa9K7w-1","X-Mimecast-MFC-AGG-ID":"u6iGaDMcO7uhPJyMHa9K7w_1775848745","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:24 +0400","Subject":"[PATCH v2 02/67] ui/vnc: clarify intent using buffer_empty() function","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-2-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1156;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Oaz4HwykOBOf9JYgkJzVi5dqUDlvyrzedLzIIlA+YUQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0TMZDQJ9nSmNocpX15cdsYo4DX93RlAFrK+\n 4RLcdCWLO6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac\n 5YbqEAC6ky+Rv0lNUojnxjQiDx6KbczbsZjpOvvo4kNs2jZM40OKsEaqQlR4IgQ6BPKo6+UhTTU\n lTtd54nyIWymFmBcSl0ohuJ2rV8yT1Vbo/MAEi0PDwrdK/UcCWEJBRhhvFz8fs0K4Np04jpcNSG\n inr46cQIx1SeKa1XtLK623eZXRTEaAXhvAEivPyAAq+wbbgub/xPK84sLnxcbayAL8oet4gf3Ex\n +cm1JbV516v4+hYr4n811hvvvqs0hTpq9ikq64eAtLHDIk+nr8dncAplO3GCFk6qrPYeTyX4jSk\n mWqMajRaOyvBtGRokdu7lSFl1r/GEfCPaJi1AQDm2bSxZYk/NQJqaepDuDHiG5sPblW+wQkgx62\n evArJ31zEThCplTBHwQqV33Gz4vg7VdyC4Jg/TYpdfv442yKHp3RKYLydok2XOLfxVexqJQlrun\n WyIdvx/elwyPa2DK5ENy8Ul8SMZcGkLwNuRyUJUhYGtg22v+achcWDCXpSWXt4DliEH62XCwpXc\n BFpWs0vWQI2t85Da1MlyPpafjf5Is46vwaMOvbfwKhY9nH3TlC3FfM06HSiM9tjVQHCyd540oBi\n HVPXeNMEmVXgQvjkqMMPEoHqf9fmlxTREbAxeT04/6XNGUipvCaWpButo7P7VFMel1X5xgw2kj/\n pZHMw3kXrI4Sa+g==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Reviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/vnc-jobs.c | 2 +-\n ui/vnc.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex a6ab733faa1..4dd7ccad969 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -160,7 +160,7 @@ void vnc_jobs_consume_buffer(VncState *vs)\n bool flush;\n \n vnc_lock_output(vs);\n- if (vs->jobs_buffer.offset) {\n+ if (!buffer_empty(&vs->jobs_buffer)) {\n if (vs->ioc != NULL && buffer_empty(&vs->output)) {\n g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n if (vs->disconnecting == FALSE) {\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex ccc73bd7aa4..4aa446a48d7 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -1718,7 +1718,7 @@ void vnc_write_u8(VncState *vs, uint8_t value)\n void vnc_flush(VncState *vs)\n {\n vnc_lock_output(vs);\n- if (vs->ioc != NULL && vs->output.offset) {\n+ if (vs->ioc != NULL && !buffer_empty(&vs->output)) {\n vnc_client_write_locked(vs);\n }\n if (vs->disconnecting) {\n","prefixes":["v2","02/67"]}