{"id":2222068,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222068/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-4-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-4-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:26","name":"[v2,04/67] ui/vnc-jobs: remove dead VncJobQueue.exit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"36cb9391993a831373d098ee444b36f9e1a77fef","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-4-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222068/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222068/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aOtGMdqC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmpN6zldz1yGS\n\tfor ; Sat, 11 Apr 2026 05:19:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHNz-0002JT-Mb; Fri, 10 Apr 2026 15:19:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHNy-0002H5-GW\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:22 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHNx-0000Py-5n\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:22 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-vx_P347-OGmlxAVJd63VUA-1; Fri,\n 10 Apr 2026 15:19:18 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 91A431801326\n for ; Fri, 10 Apr 2026 19:19:17 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 56C8D1955E77; Fri, 10 Apr 2026 19:19:15 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848760;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=I09NHvw8atmJax+ZAvCxf3dEVbEAKA6LxIu95J9jOIY=;\n b=aOtGMdqCE3GgNrbgykTRD31oDqd5g2nA/gmAubYY35p7chaAB7gZT+0/AmgggYfMqOfyWl\n 0Onzm8yRHezUzpIhRX+HRf5DWPAMn1z7S+E6CRv0MQm2lGQLwM0mSJ+CCMjOhTTmVhSA8N\n nyS83zuF0q3GQfbtY1j94Kdqko2pHsU=","X-MC-Unique":"vx_P347-OGmlxAVJd63VUA-1","X-Mimecast-MFC-AGG-ID":"vx_P347-OGmlxAVJd63VUA_1775848757","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:26 +0400","Subject":"[PATCH v2 04/67] ui/vnc-jobs: remove dead VncJobQueue.exit","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-4-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1591;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=dgRNTw9wFjvzywdXh2HBEiFRI7zZwhAv49Mp+nZt5gc=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0TpkcMpz7YbgnFAe1hXAkHJHnR/wCYU0Mrb\n ubWcspCNNKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac\n 5UD9D/9I9EaL70HdZHS43JiYeFsD1WDReURSerHfakS1qq6EsrcgYPkP5I0cqiXlAAM2VNYscFa\n 1+9TVAaA4DaXLvytfgzPDC0aFw7oGliGknm8yLdOZoyyj+TfKvy/9R6xV+ZAYqp6TWwkn69t1SI\n 068X2k5HBMUK736cR9ORpjDEKGXavjat4iAoRpGEpQB3NNisYG7BXKO6a2qGtEEDpB/3ny4TV+E\n LrCct8rIZwX8Pof6Ho5Lex/keQSHFd2tjubNEuVVKLd+PYPyXbUZFhI3bekvrKIzVySZl79Lddr\n 1M5N4SNjsEgE9pf0/UiaaoS8aHzJTWsrDwCd34vRFeFW7rLQNmRHodL8BiPjtSf0qBh1kp7LQs4\n hhctQGqAwAPEhyLN+dFJRjyoHdgpM8TUCAmiVKC9KHPt32ez9Q0B0GSXvaJgyueZgRjLjKuFdUt\n 3D1/cVAFfsCsiH3zc+PVmxrxfJHI3pBtELkoTkQgwS7s0JscVwC72Af93MFbxUyEW2I16bQ56/8\n 9tWGuSbqKfUcwKKkiPYjBgNr8+vN+ySkNMkQHIfx37f0i6G7lmrD+r/iFxRZT6gfKhJxs/oPEpK\n 2+fBMFxibm7ClBFTgfQ93EvqdeZ5Erg7vsJR9eQf/kZSVWuadeW1IldCcYpSuO1bu2f30NF23AW\n 2UyU9WACLYYvuNA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Since commit 09526058d0a5 (\"ui/vnc: Remove vnc_stop_worker_thread()\"),\nit's not used anymore. It seems stopping worker thread hasn't been\nsupported ever.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/vnc-jobs.c | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)","diff":"diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex 8cb30e72276..9e536b07b90 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -56,7 +56,6 @@ struct VncJobQueue {\n QemuCond cond;\n QemuMutex mutex;\n QemuThread thread;\n- bool exit;\n QTAILQ_HEAD(, VncJob) jobs;\n };\n \n@@ -124,7 +123,7 @@ static void vnc_job_free(VncJob *job)\n void vnc_job_push(VncJob *job)\n {\n vnc_lock_queue(queue);\n- if (queue->exit || QLIST_EMPTY(&job->rectangles)) {\n+ if (QLIST_EMPTY(&job->rectangles)) {\n vnc_job_free(job);\n } else {\n QTAILQ_INSERT_TAIL(&queue->jobs, job, next);\n@@ -248,17 +247,12 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)\n int saved_offset;\n \n vnc_lock_queue(queue);\n- while (QTAILQ_EMPTY(&queue->jobs) && !queue->exit) {\n+ while (QTAILQ_EMPTY(&queue->jobs)) {\n qemu_cond_wait(&queue->cond, &queue->mutex);\n }\n- /* Here job can only be NULL if queue->exit is true */\n job = QTAILQ_FIRST(&queue->jobs);\n vnc_unlock_queue(queue);\n \n- if (queue->exit) {\n- return -1;\n- }\n-\n assert(job->vs->magic == VNC_MAGIC);\n vc = container_of(job->vs, VncConnection, vs);\n \n","prefixes":["v2","04/67"]}