{"id":2222044,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222044/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20260410-winbond-6-19-rc1-oddr-v1-5-2ac4827a3868@bootlin.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.1/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260410-winbond-6-19-rc1-oddr-v1-5-2ac4827a3868@bootlin.com>","date":"2026-04-10T17:41:05","name":"[5/5] mtd: spinand: winbond: Fix ODTR write VCR on W35NxxJW","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9391710fe6c57739b89f69d58b6db439450853b8","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.1/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20260410-winbond-6-19-rc1-oddr-v1-5-2ac4827a3868@bootlin.com/mbox/","series":[{"id":499489,"url":"http://patchwork.ozlabs.org/api/1.1/series/499489/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=499489","date":"2026-04-10T17:41:01","name":"mtd/spi: Fix Winbond W35N02JW / W35N04JW support","version":1,"mbox":"http://patchwork.ozlabs.org/series/499489/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222044/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222044/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=AYt+GOsa;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=Ep5+M9HS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fskcr08Nxz1y2d\n\tfor ; Sat, 11 Apr 2026 03:41:32 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBFrB-0000000CdUJ-4BKg;\n\tFri, 10 Apr 2026 17:41:26 +0000","from smtpout-04.galae.net ([185.171.202.116])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBFr9-0000000CdR5-2XNn\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 10 Apr 2026 17:41:24 +0000","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-04.galae.net (Postfix) with ESMTPS id 4EBEFC5C1A9;\n\tFri, 10 Apr 2026 17:41:57 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 11EE7603F0;\n\tFri, 10 Apr 2026 17:41:22 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 6E68C10450082;\n\tFri, 10 Apr 2026 19:41:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=R+Lxge/XmvFJmf/koFAPreTB1C+xMoWcHo9ICbExF4U=; b=AYt+GOsaoTdRai\n\tos8xvYGOD//zeGQSNScXK1ISCasl0D7EXN1Wr/N5VQ+I5rlcUrJXh+kGQH0CO9mfWlto3MI1IX6AR\n\tgcmJoCXmne1n5CrIozYJHb2b6n1lvvopxr75/7rKObAQl0m8T9q04WGpc4O8F8rm8bhcCVrk+n+AM\n\tUkXPB0y7dyr+YJP4W3ncbaDvD3rni171nELBhLIsC3Z1+u23Zvf/+Drj+Y6RxOrZomIxBeVOQnrdl\n\tZKbo2aqt/PybrPTq59RFBi9AvgNBSJko5rOGwPkoBUllAPuxSqcJ2CUkEpSwM+oLeSpJk790sxi5O\n\tLRf9oTIuRk+VboWwoBhQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1775842881; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=6cCsRdWer/xoQr7FKNryl+BMiMzpUL7o1CHo+cPuu2k=;\n\tb=Ep5+M9HSLHRDyXiart+fWuti+USarJuRC0e2PDVSq+djwVJ6Oh+zRrsL0e5uwaGwE239dD\n\tbOK4GJnkoif2eeCOt6hVLaEYEn/9peMDHTJsqxi0ln/DzLdPKkygB46wM+NnJvxu3LlHWy\n\tAHRsosfbC0a+zgPP4eocSgaDMwJT9Pc0ovX/3QiP83dsmNdrn2l4X8dVJ6VUZxXK0EnOV1\n\tVmeZKLrYauSeHDu/6I7R5/IabzaOu6gNfLZJIlFE9lUHM2lx6Bth2k5Yvkvt2j31M04oVv\n\txOqO73DY8Dtm+YloPGf5w5EpES9vWbMbNksoBu9PirNe16o4Ci7Nx7XhQoKCxQ=="],"From":"Miquel Raynal ","Date":"Fri, 10 Apr 2026 19:41:05 +0200","Subject":"[PATCH 5/5] mtd: spinand: winbond: Fix ODTR write VCR on W35NxxJW","MIME-Version":"1.0","Message-Id":"<20260410-winbond-6-19-rc1-oddr-v1-5-2ac4827a3868@bootlin.com>","References":"<20260410-winbond-6-19-rc1-oddr-v1-0-2ac4827a3868@bootlin.com>","In-Reply-To":"<20260410-winbond-6-19-rc1-oddr-v1-0-2ac4827a3868@bootlin.com>","To":"Mark Brown , Richard Weinberger ,\n Vignesh Raghavendra , Pratyush Yadav ","Cc":"Steam Lin ,\n Thomas Petazzoni , linux-spi@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n Miquel Raynal ","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260410_104123_799748_38BE89A5 ","X-CRM114-Status":"GOOD ( 10.26 )","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: In most scenarios this variant is actually unused (VCR is\n written in SSDR mode), but we need to provide an octal variant. The address\n is 24 bits but is sent over 4 bytes MSB first. This means we need [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"In most scenarios this variant is actually unused (VCR is written in\nSSDR mode), but we need to provide an octal variant. The address is 24\nbits but is sent over 4 bytes MSB first. This means we need to shift the\nregister address by one extra byte for the address to be correct.\n\nI didn't catch this initially because the volatile register region is\n256 bytes wide, so the write-then-read procedure did work with the small\nregister addresses I was using at that time: 0 and 1.\n\nFixes: 44a2f49b9bdc (\"mtd: spinand: winbond: W35N octal DTR support\")\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/spi/winbond.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c\nindex a3fca8a1cff1..269fc587c5fe 100644\n--- a/drivers/mtd/nand/spi/winbond.c\n+++ b/drivers/mtd/nand/spi/winbond.c\n@@ -99,7 +99,7 @@ static SPINAND_OP_VARIANTS(update_cache_variants,\n \n #define SPINAND_WINBOND_WRITE_VCR_8D_8D_8D(reg, buf)\t\t\t\\\n \tSPI_MEM_OP(SPI_MEM_DTR_OP_RPT_CMD(0x81, 8),\t\t\t\\\n-\t\t SPI_MEM_DTR_OP_ADDR(4, reg, 8),\t\t\t\\\n+\t\t SPI_MEM_DTR_OP_ADDR(4, reg << 8, 8),\t\t\t\\\n \t\t SPI_MEM_OP_NO_DUMMY,\t\t\t\t\t\\\n \t\t SPI_MEM_DTR_OP_DATA_OUT(2, buf, 8))\n \n","prefixes":["5/5"]}