{"id":2222043,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222043/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20260410-winbond-6-19-rc1-oddr-v1-3-2ac4827a3868@bootlin.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.1/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260410-winbond-6-19-rc1-oddr-v1-3-2ac4827a3868@bootlin.com>","date":"2026-04-10T17:41:03","name":"[3/5] mtd: spinand: Add support for packed read data ODTR commands","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9226ac65f90454a4954d90ea9b6499d72c0f0952","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.1/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20260410-winbond-6-19-rc1-oddr-v1-3-2ac4827a3868@bootlin.com/mbox/","series":[{"id":499489,"url":"http://patchwork.ozlabs.org/api/1.1/series/499489/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=499489","date":"2026-04-10T17:41:01","name":"mtd/spi: Fix Winbond W35N02JW / W35N04JW support","version":1,"mbox":"http://patchwork.ozlabs.org/series/499489/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222043/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222043/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CLkeIsX7;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=bLI7mquF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fskcq4xrfz20HT\n\tfor ; Sat, 11 Apr 2026 03:41:31 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBFrB-0000000CdU2-2t7w;\n\tFri, 10 Apr 2026 17:41:25 +0000","from smtpout-04.galae.net ([185.171.202.116])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBFr8-0000000CdQN-34wI\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 10 Apr 2026 17:41:24 +0000","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-04.galae.net (Postfix) with ESMTPS id CCCD2C5C1A5;\n\tFri, 10 Apr 2026 17:41:54 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 8FD18603F0;\n\tFri, 10 Apr 2026 17:41:19 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id D786D10450085;\n\tFri, 10 Apr 2026 19:41:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=uNo8A5gdTHSpjivg7SxIKpLqrKwa5FN0DnjIHVnNJTM=; b=CLkeIsX729sN7q\n\tth3WVBlOCfTHmdy3rAFiH4Pj31jM932tD72dBYL4qdz207m/vrCvKb0I/TPPBhr7wdoLwD6zRUvtb\n\tYMiBNMMxaiwCCXC9f05U3BdpbnZLj3POX2TAKja9plvvsF9iTjXV3Ks+yYqrpsfPK5q5T7B2r94fl\n\tURvRVBu7wyb6/hSX84fnVx0Uck92SoId+J26n8jOQBU6LMV0HwF6yb/EdcgcJImc3IS1VMrqHSFYZ\n\tmK+ZYkw3lzXA9PJfDUl8+91ELfZR4q690DcshPPJ9eV8AzjC/UhCXvPaZX3wZuB7+1Wx2emPqm0kr\n\t2redqKF6JvEK6JGzv4QA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1775842878; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=5i86694lMeG7kylMxcMPx4GdJDrXhoBS7Gx4ntdJ5OQ=;\n\tb=bLI7mquFFWnVp00o0oHH9cqiMpthDSACGYJeebI0hLpcQCvNo7uVlnTPmUmFHK7l+sVuuP\n\ttQgBdTH7L3PiJ0lfkgyvZEhuSwS8bfW+cJNQdE7z9EJXSP9mmxtfoZHoQlHli44dxzZK4N\n\tUM+E7obF/bgroHUjwk4CXeHzovUTAEY/lg2KRivohSdJBCwtehx6czR6GhbVElqR3ZsFQL\n\t4JUrdsWiugGhSZsoudEmLJYpS+bZO3p+xacV9NwFiIonpNOU/uTJC9h1XotpNw7PQf4kgL\n\tptdS3bJl4C6Xfi1sKFzg3gvtwQRCb/oV4+Hq34id0DGzve7r3LdkGEmypYLMow=="],"From":"Miquel Raynal ","Date":"Fri, 10 Apr 2026 19:41:03 +0200","Subject":"[PATCH 3/5] mtd: spinand: Add support for packed read data ODTR\n commands","MIME-Version":"1.0","Message-Id":"<20260410-winbond-6-19-rc1-oddr-v1-3-2ac4827a3868@bootlin.com>","References":"<20260410-winbond-6-19-rc1-oddr-v1-0-2ac4827a3868@bootlin.com>","In-Reply-To":"<20260410-winbond-6-19-rc1-oddr-v1-0-2ac4827a3868@bootlin.com>","To":"Mark Brown , Richard Weinberger ,\n Vignesh Raghavendra , Pratyush Yadav ","Cc":"Steam Lin ,\n Thomas Petazzoni , linux-spi@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n Miquel Raynal ","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260410_104123_066353_D1E0F8B3 ","X-CRM114-Status":"GOOD ( 14.36 )","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Some devices stuff address bits in the double byte opcode\n (in place of the repeated byte) in order to be able to increase the size of\n the devices, without adding extra address bytes. Create a flag to identify\n those devices. When the flag is set, use the \"packed\" variant for the read\n data operation.\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-accredit.habeas.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n bl.score.senderscore.com]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Some devices stuff address bits in the double byte opcode (in place of\nthe repeated byte) in order to be able to increase the size of the\ndevices, without adding extra address bytes.\n\nCreate a flag to identify those devices. When the flag is set, use the\n\"packed\" variant for the read data operation.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/spi/core.c | 24 +++++++++++++++++++++---\n include/linux/mtd/spinand.h | 7 +++++++\n 2 files changed, 28 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c\nindex 66c90419f6d5..96154f359e1a 100644\n--- a/drivers/mtd/nand/spi/core.c\n+++ b/drivers/mtd/nand/spi/core.c\n@@ -100,6 +100,17 @@ spinand_fill_page_read_op(struct spinand_device *spinand, u64 addr)\n \treturn op;\n }\n \n+static struct spi_mem_op\n+spinand_fill_page_read_packed_op(struct spinand_device *spinand, u64 addr)\n+{\n+\tstruct spi_mem_op op = spinand->op_templates->page_read;\n+\n+\top.cmd.opcode |= addr >> 16;\n+\top.addr.val = addr & 0xFFFF;\n+\n+\treturn op;\n+}\n+\n struct spi_mem_op\n spinand_fill_prog_exec_op(struct spinand_device *spinand, u64 addr)\n {\n@@ -453,7 +464,10 @@ static int spinand_load_page_op(struct spinand_device *spinand,\n {\n \tstruct nand_device *nand = spinand_to_nand(spinand);\n \tunsigned int row = nanddev_pos_to_row(nand, &req->pos);\n-\tstruct spi_mem_op op = SPINAND_OP(spinand, page_read, row);\n+\tbool packed = spinand->flags & SPINAND_ODTR_PACKED_PAGE_READ;\n+\tstruct spi_mem_op op = packed ?\n+\t\tSPINAND_OP(spinand, page_read_packed, row) :\n+\t\tSPINAND_OP(spinand, page_read, row);\n \n \treturn spi_mem_exec_op(spinand->spimem, &op);\n }\n@@ -1489,9 +1503,13 @@ static int spinand_init_odtr_instruction_set(struct spinand_device *spinand)\n \tif (!spi_mem_supports_op(spinand->spimem, &tmpl->blk_erase))\n \t\treturn -EOPNOTSUPP;\n \n-\ttmpl->page_read = (struct spi_mem_op)SPINAND_PAGE_READ_8D_8D_0_OP(0);\n-\tif (!spi_mem_supports_op(spinand->spimem, &tmpl->page_read))\n+\tif (spinand->flags & SPINAND_ODTR_PACKED_PAGE_READ)\n+\t\ttmpl->page_read = (struct spi_mem_op)SPINAND_PAGE_READ_PACKED_8D_8D_0_OP(0);\n+\telse\n+\t\ttmpl->page_read = (struct spi_mem_op)SPINAND_PAGE_READ_8D_8D_0_OP(0);\n+\tif (!spi_mem_supports_op(spinand->spimem, &tmpl->page_read)) {\n \t\treturn -EOPNOTSUPP;\n+\t}\n \n \ttmpl->prog_exec = (struct spi_mem_op)SPINAND_PROG_EXEC_8D_8D_0_OP(0);\n \tif (!spi_mem_supports_op(spinand->spimem, &tmpl->prog_exec))\ndiff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h\nindex 6a024cf1c53a..f2f80103649d 100644\n--- a/include/linux/mtd/spinand.h\n+++ b/include/linux/mtd/spinand.h\n@@ -290,6 +290,12 @@\n \t\t SPI_MEM_OP_NO_DUMMY,\t\t\t\t\t\\\n \t\t SPI_MEM_OP_NO_DATA)\n \n+#define SPINAND_PAGE_READ_PACKED_8D_8D_0_OP(addr)\t\t\t\\\n+\tSPI_MEM_OP(SPI_MEM_DTR_OP_PACKED_CMD(0x13, addr >> 16, 8),\t\\\n+\t\t SPI_MEM_DTR_OP_ADDR(2, addr & 0xffff, 8),\t\t\\\n+\t\t SPI_MEM_OP_NO_DUMMY,\t\t\t\t\t\\\n+\t\t SPI_MEM_OP_NO_DATA)\n+\n #define SPINAND_PAGE_READ_FROM_CACHE_8D_8D_8D_OP(addr, ndummy, buf, len, freq) \\\n \tSPI_MEM_OP(SPI_MEM_DTR_OP_RPT_CMD(0x9d, 8),\t\t\t\\\n \t\t SPI_MEM_DTR_OP_ADDR(2, addr, 8),\t\t\t\\\n@@ -482,6 +488,7 @@ struct spinand_ecc_info {\n #define SPINAND_HAS_PROG_PLANE_SELECT_BIT\t\tBIT(2)\n #define SPINAND_HAS_READ_PLANE_SELECT_BIT\t\tBIT(3)\n #define SPINAND_NO_RAW_ACCESS\t\t\t\tBIT(4)\n+#define SPINAND_ODTR_PACKED_PAGE_READ\t\t\tBIT(5)\n \n /**\n * struct spinand_ondie_ecc_conf - private SPI-NAND on-die ECC engine structure\n","prefixes":["3/5"]}