{"id":2222032,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222032/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-16-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410160458.3778874-16-berrange@redhat.com>","date":"2026-04-10T16:04:56","name":"[15/17] monitor: drop unused monitor_is_qmp method","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3de805204c70691b2e1af0a9e49738edfc2a0043","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.1/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-16-berrange@redhat.com/mbox/","series":[{"id":499483,"url":"http://patchwork.ozlabs.org/api/1.1/series/499483/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499483","date":"2026-04-10T16:04:41","name":"monitor: turn QMP and HMP into QOM objects","version":1,"mbox":"http://patchwork.ozlabs.org/series/499483/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222032/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222032/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ChV38lgw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fshY44Dgrz1yGb\n\tfor ; Sat, 11 Apr 2026 02:08:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBEOM-0006iG-FK; Fri, 10 Apr 2026 12:07:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBEN6-0004Rr-1L\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:06:17 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBEN2-0006ag-RV\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:06:15 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-CMlD4FhoOFK9KZEBPtNB8Q-1; Fri,\n 10 Apr 2026 12:06:01 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1F1D019560AA; Fri, 10 Apr 2026 16:06:00 +0000 (UTC)","from toolbx.redhat.corp (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D41E219560AB; Fri, 10 Apr 2026 16:05:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775837164;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=2yGpbp1wrCi4QCAosuKIWuVsmzC+UFfclvaHmYjnOJ4=;\n b=ChV38lgwAfMEbou5Hfv/Rx5ucFz736VZuTpxMfsamvCHhyc/DY/CPpEQTJWKqi910D9bTG\n UZnh43Tksmu/HYggOnFV94PVESTwvIm8gOkRexnHqo/bs3K13C1bVCvVm8esVElzDRQ3dE\n eRgZBwxxpnpiYT/s8tVS6BybRLzEOww=","X-MC-Unique":"CMlD4FhoOFK9KZEBPtNB8Q-1","X-Mimecast-MFC-AGG-ID":"CMlD4FhoOFK9KZEBPtNB8Q_1775837160","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Paolo Bonzini ,\n Markus Armbruster ,\n Christian Brauner ,\n =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_M?=\n\t=?utf-8?q?athieu-Daud=C3=A9?= ,\n Fabiano Rosas ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Xu , Kevin Wolf , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ,\n qemu-block@nongnu.org, \"Dr. David Alan Gilbert\" ,\n Eric Blake ","Subject":"[PATCH 15/17] monitor: drop unused monitor_is_qmp method","Date":"Fri, 10 Apr 2026 17:04:56 +0100","Message-ID":"<20260410160458.3778874-16-berrange@redhat.com>","In-Reply-To":"<20260410160458.3778874-1-berrange@redhat.com>","References":"<20260410160458.3778874-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The previous patch dropped the only remaining use of\nmonitor_is_qmp.\n\nSigned-off-by: Daniel P. Berrangé \n---\n monitor/monitor-internal.h | 9 ---------\n monitor/monitor.c | 1 -\n 2 files changed, 10 deletions(-)","diff":"diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex 7004f5d002..d40fdde793 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -106,7 +106,6 @@ struct Monitor {\n Object parent;\n CharFrontend chr;\n int suspend_cnt; /* Needs to be accessed atomically */\n- bool is_qmp;\n bool use_io_thread;\n \n char *mon_cpu_path;\n@@ -171,14 +170,6 @@ struct MonitorQMP {\n GQueue *qmp_requests;\n };\n \n-/**\n- * Is @mon a QMP monitor?\n- */\n-static inline bool monitor_is_qmp(const Monitor *mon)\n-{\n- return mon->is_qmp;\n-}\n-\n typedef QTAILQ_HEAD(MonitorList, Monitor) MonitorList;\n extern IOThread *mon_iothread;\n extern Coroutine *qmp_dispatcher_co;\ndiff --git a/monitor/monitor.c b/monitor/monitor.c\nindex c08b2c2ee1..f48603a7e8 100644\n--- a/monitor/monitor.c\n+++ b/monitor/monitor.c\n@@ -94,7 +94,6 @@ static void monitor_init(Object *obj)\n Monitor *mon = MONITOR(obj);\n \n qemu_mutex_init(&mon->mon_lock);\n- mon->is_qmp = !!object_dynamic_cast(obj, TYPE_MONITOR_QMP);\n mon->outbuf = g_string_new(NULL);\n }\n \n","prefixes":["15/17"]}