{"id":2222013,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222013/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410152314.86412-3-kwolf@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410152314.86412-3-kwolf@redhat.com>","date":"2026-04-10T15:23:14","name":"[2/2] block: Add more defaults to DEFAULT_BLOCK_CONF","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ed4729d804b2c82642524dd10d58eaaaf6aba5b","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/1.1/people/2714/?format=json","name":"Kevin Wolf","email":"kwolf@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410152314.86412-3-kwolf@redhat.com/mbox/","series":[{"id":499481,"url":"http://patchwork.ozlabs.org/api/1.1/series/499481/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499481","date":"2026-04-10T15:23:12","name":"scsi: Fix discard_granularity for -drive if=scsi","version":1,"mbox":"http://patchwork.ozlabs.org/series/499481/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222013/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222013/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=eNV6TnVu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsgbv6NgHz20HT\n\tfor ; Sat, 11 Apr 2026 01:25:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBDii-0001kR-Cp; Fri, 10 Apr 2026 11:24:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBDiR-0001iW-1B\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:24:15 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBDiM-0008AL-Fw\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:24:14 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-Bc91LWxQNnSrER55qBTrdQ-1; Fri,\n 10 Apr 2026 11:24:03 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 58F481800361; Fri, 10 Apr 2026 15:24:02 +0000 (UTC)","from merkur.redhat.com (unknown [10.44.49.176])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B426A195608E; Fri, 10 Apr 2026 15:23:59 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775834646;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FfjKtk+ZXOkZvUOghWl0pCv85bkiuG0/v4M2PtMHc3M=;\n b=eNV6TnVuztLIdQqgNNnYU5DoEPh9G1nb5DfsadwxFFcyM7BZiAekIsxo1tzJx05cQqVqnl\n qpfyJujtHJgNry6r57iGDc/r0tSr9hfb6VV9Cdq5Dcwlnfv+poSS+Ii3YCQGdYWKd47gMW\n ars87/0f6nbHJMTGwQKTTYh8GyZgX4s=","X-MC-Unique":"Bc91LWxQNnSrER55qBTrdQ-1","X-Mimecast-MFC-AGG-ID":"Bc91LWxQNnSrER55qBTrdQ_1775834642","From":"Kevin Wolf ","To":"qemu-block@nongnu.org","Cc":"kwolf@redhat.com, hreitz@redhat.com, ivy@FreeBSD.org, pbonzini@redhat.com,\n fam@euphon.net, qemu-devel@nongnu.org, qemu-stable@nongnu.org","Subject":"[PATCH 2/2] block: Add more defaults to DEFAULT_BLOCK_CONF","Date":"Fri, 10 Apr 2026 17:23:14 +0200","Message-ID":"<20260410152314.86412-3-kwolf@redhat.com>","In-Reply-To":"<20260410152314.86412-1-kwolf@redhat.com>","References":"<20260410152314.86412-1-kwolf@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"discard_granularity was missing from this, which means that SCSI disks\ncreated with -drive if=scsi would default to 0 (i.e. disabling discards)\ninstead of -1, which makes scsi-hd automatically pick a granularity and\nis the default of the corresponding qdev property for -device scsi-hd.\n\nThis was broken in QEMU 9.0 with commit 3089637.\n\nAlso set other fields whose default isn't an obvious 0. These are not\nactual bug fixes because ON_OFF_AUTO_AUTO in fact happens to be 0, but\nit's better not to rely on the order of enums.\n\nCc: qemu-stable@nongnu.org\nFixes: 308963746169 ('scsi: Don't ignore most usb-storage properties')\nReported-by: Lexi Winter \nSigned-off-by: Kevin Wolf \n---\n include/hw/block/block.h | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/include/hw/block/block.h b/include/hw/block/block.h\nindex e0a427039ee..df941df19f2 100644\n--- a/include/hw/block/block.h\n+++ b/include/hw/block/block.h\n@@ -53,7 +53,12 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf)\n \n #define DEFAULT_BLOCK_CONF (BlockConf) { \\\n .bootindex = -1, \\\n+ .backend_defaults = ON_OFF_AUTO_AUTO, \\\n+ .discard_granularity = -1, \\\n+ .wce = ON_OFF_AUTO_AUTO, \\\n .share_rw = false, \\\n+ .account_invalid = ON_OFF_AUTO_AUTO, \\\n+ .account_failed = ON_OFF_AUTO_AUTO, \\\n .rerror = BLOCKDEV_ON_ERROR_AUTO, \\\n .werror = BLOCKDEV_ON_ERROR_AUTO, \\\n }\n","prefixes":["2/2"]}