{"id":2221978,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221978/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260410141251.283232-1-m.dmitrichenko222@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.1/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs"},"msgid":"<20260410141251.283232-1-m.dmitrichenko222@gmail.com>","date":"2026-04-10T14:12:51","name":"[ovs-dev,v2] netdev-dpdk: Fix possible memory leak when configuring rx-steering","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ffda510663505d1fc77b72d42c1678e41985bf00","submitter":{"id":93057,"url":"http://patchwork.ozlabs.org/api/1.1/people/93057/?format=json","name":"Mikhail Dmitrichenko","email":"m.dmitrichenko222@gmail.com"},"delegate":{"id":81893,"url":"http://patchwork.ozlabs.org/api/1.1/users/81893/?format=json","username":"ktraynor","first_name":"Kevin","last_name":"Traynor","email":"ktraynor@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260410141251.283232-1-m.dmitrichenko222@gmail.com/mbox/","series":[{"id":499467,"url":"http://patchwork.ozlabs.org/api/1.1/series/499467/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=499467","date":"2026-04-10T14:12:51","name":"[ovs-dev,v2] netdev-dpdk: Fix possible memory leak when configuring rx-steering","version":2,"mbox":"http://patchwork.ozlabs.org/series/499467/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221978/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2221978/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=decuVXdO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=decuVXdO","smtp3.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp3.osuosl.org; dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=decuVXdO"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsf0M3s2Nz1yGS\n\tfor ; Sat, 11 Apr 2026 00:13:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6BDB48301D;\n\tFri, 10 Apr 2026 14:13:05 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pQTSUKd0BuTD; Fri, 10 Apr 2026 14:13:04 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 85A4C82CF1;\n\tFri, 10 Apr 2026 14:13:04 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 60A90C054A;\n\tFri, 10 Apr 2026 14:13:04 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 3C69EC0549\n for ; Fri, 10 Apr 2026 14:13:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 1C15A60BD7\n for ; Fri, 10 Apr 2026 14:13:03 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id VtNGumXeWbmI for ;\n Fri, 10 Apr 2026 14:13:02 +0000 (UTC)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n [IPv6:2a00:1450:4864:20::133])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 2FDEE60BD0\n for ; Fri, 10 Apr 2026 14:13:02 +0000 (UTC)","by mail-lf1-x133.google.com with SMTP id\n 2adb3069b0e04-59e4a04f059so1918144e87.2\n for ; Fri, 10 Apr 2026 07:13:01 -0700 (PDT)","from rbta-msk-lt-169874.astralinux.ru ([46.73.170.250])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a3eeee08desm750747e87.52.2026.04.10.07.12.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Apr 2026 07:12:58 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 85A4C82CF1","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2FDEE60BD0"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::133; helo=mail-lf1-x133.google.com;\n envelope-from=m.dmitrichenko222@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 2FDEE60BD0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775830379; x=1776435179; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=uvZEa7+X6kogVLksjSeexdbXRgGGrR2KtBFgfznxhtE=;\n b=decuVXdOJFZ66GPZJqGz/BZd/nNQBJdDhRhF/rTGidF4c9vXPCChLi3/US1/3d5NMh\n b98Mc+mh10G+k2tL1nhPs7hgh3thYuZswMgU4cs0TzCdNTMy6f8JC4cuN1RkbD89XErI\n PHGa+KZEfXArxxd6+88jDawFWKq+nTNoglby5cGN/am7N+cSPizHX6UKVjEEQvkAnVyy\n XcIIdrgewVu31TjNICkWryA0XXanLMqc6K4gUpxkLOn/AYPtBFICRSfKwlCyA+DpBEb6\n Xj6MJnS7wG+ljXTWlsvkEEpXkzuGIFRA7PZy5Q/3foN8/5EkK0jabR56pcbe1RbDFt10\n ImKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775830379; x=1776435179;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uvZEa7+X6kogVLksjSeexdbXRgGGrR2KtBFgfznxhtE=;\n b=sGCQmSc/EYt89uD/a09ZSlFTp3v9f75g+UQK+pdEScRkuQGsGju4/3dEI5eA1BWD0b\n e3HP2Dy7GKz3C8IfDqGlNLltVQ38EcnhQkgr1Ly2L+4G8mHSraX+3T9LznFsAjm1s28A\n X1p9xRLDCmWN9C51TJRiTeCpiqDFDJHQsvuEdPfyVEqeP6ulAHtNziXzfGBSv+QKfvlM\n SAjbwXBrsefS3gcd7iR9DfQob3AnE9pyAu/ozrBBeA/y/3Btwy3xzXk0lEI/88O35NvG\n kfCE0J84W7Y358R1dEuC8E0nxw8hltv4llwjIQkb8G0bIOuI8hghyJv6h98Xu/n8mJvp\n f0wg==","X-Gm-Message-State":"AOJu0YzOr8ehHx3M+z1lWrTclfH5TwpVE9qAmipEtm/qWv++BIINZ+UD\n iPBrBA4kDG2j1xa/yn8IVm4Epo7g0Nf6DFHvTq6Gj6kpv8yD6uMQuKo4/0rrhMCp","X-Gm-Gg":"AeBDiet+Z+Gm5d2z0XGihyG1OLWU7GV5Rh5oDCxs0fgzjuuN6oZIpkn74hVrVq3CULd\n JHipyXPYNPWhIuzWfFqaBEwUEc3KzfFNBd3e7vtmaq5+qAMAOZCA6hIMGVXt3pNOpYX9PVimQU4\n VDWl4ZUAr2+v050FlUXFUumQaetbmjw+zSSxfO6yEfokEIAAqULjfm7ihpVjxbh4UyeN6Tzihnj\n SE5tmyr4h/Xfc+BjMf/jU5XjNSWiWRyP3jLfWjOjzqSpuM04VYmVwz7OM8qUQoAKhE+pWs80g5l\n 12DWH7WC37Cmbu68cAmx8p+Ezc6cyBCUZQ9jScSQYrH3zPMULTfoWBu6FQcM7TWi93b1X3X4dMZ\n i/UiDe387HlnpNupwWbIc8q2FbYl/PYReefMuVNeKuM94+M9j/tujXTI3KAIi04BQvH6sbEJqW2\n Xq/dsUMJcnoBDoBHcq+SNuQ0CO8Q3X6J+S2/tzcVkB+oY6z+YoZb8nMw17ycKSFm/isV6K","X-Received":"by 2002:ac2:53b9:0:b0:5a3:f25b:4e25 with SMTP id\n 2adb3069b0e04-5a3f25b4e2cmr689904e87.39.1775830378958;\n Fri, 10 Apr 2026 07:12:58 -0700 (PDT)","From":"Mikhail Dmitrichenko ","To":"dev@openvswitch.org","Date":"Fri, 10 Apr 2026 17:12:51 +0300","Message-Id":"<20260410141251.283232-1-m.dmitrichenko222@gmail.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH v2] netdev-dpdk: Fix possible memory leak when\n configuring rx-steering","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Mikhail Dmitrichenko ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"VLOG_WARN_BUF() allocates a new string with xasprintf() every time it is\ncalled and overwrites *errp without freeing the previous value. This can\nlead to a memory leak if multiple warnings are emitted or if a later\nhard error in netdev_dpdk_set_config() also writes\nto errp.\n\nThe three cases in dpdk_set_rx_steer_config() are not fatal errors:\n- unsupported rx-steering value\n- rss+lacp on non-ethernet port\n- rss+lacp together with hw-offload\n\nIn all cases program simply log a warning and fall back to default RSS\nsteering. Configuration continues normally (err remains 0 and execution\nflow do not goto out).\n\nTherefore change them to plain VLOG_WARN(). As a result the 'errp'\nparameter becomes unused and is removed from the function signature and\nthe call site in netdev_dpdk_set_config().\n\nThis makes the code cleaner and consistent with the rest of netdev-dpdk.\n\nFound by Linux Verification Center (linuxtesting.org) with SVACE.\n\nFixes: fc06ea9a1883 (\"netdev-dpdk: Add custom rx-steering configuration.\")\nSigned-off-by: Mikhail Dmitrichenko \n---\n lib/netdev-dpdk.c | 19 ++++++++-----------\n 1 file changed, 8 insertions(+), 11 deletions(-)","diff":"diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex 54959ff0d..e75b9ad55 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -2251,7 +2251,7 @@ dpdk_process_queue_size(struct netdev *netdev, const struct smap *args,\n \n static void\n dpdk_set_rx_steer_config(struct netdev *netdev, struct netdev_dpdk *dev,\n- const struct smap *args, char **errp)\n+ const struct smap *args)\n {\n const char *arg = smap_get_def(args, \"rx-steering\", \"rss\");\n uint64_t flags = 0;\n@@ -2259,22 +2259,19 @@ dpdk_set_rx_steer_config(struct netdev *netdev, struct netdev_dpdk *dev,\n if (!strcmp(arg, \"rss+lacp\")) {\n flags = DPDK_RX_STEER_LACP;\n } else if (strcmp(arg, \"rss\")) {\n- VLOG_WARN_BUF(errp, \"%s: options:rx-steering \"\n- \"unsupported parameter value '%s'\",\n- netdev_get_name(netdev), arg);\n+ VLOG_WARN(\"%s: options:rx-steering unsupported parameter value '%s'\",\n+ netdev_get_name(netdev), arg);\n }\n \n if (flags && dev->type != DPDK_DEV_ETH) {\n- VLOG_WARN_BUF(errp, \"%s: options:rx-steering \"\n- \"is only supported on ethernet ports\",\n- netdev_get_name(netdev));\n+ VLOG_WARN(\"%s: options:rx-steering is only supported on ethernet ports\",\n+ netdev_get_name(netdev));\n flags = 0;\n }\n \n if (flags && dpif_offload_enabled()) {\n- VLOG_WARN_BUF(errp, \"%s: options:rx-steering \"\n- \"is incompatible with hw-offload\",\n- netdev_get_name(netdev));\n+ VLOG_WARN(\"%s: options:rx-steering is incompatible with hw-offload\",\n+ netdev_get_name(netdev));\n flags = 0;\n }\n \n@@ -2304,7 +2301,7 @@ netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args,\n ovs_mutex_lock(&dpdk_mutex);\n ovs_mutex_lock(&dev->mutex);\n \n- dpdk_set_rx_steer_config(netdev, dev, args, errp);\n+ dpdk_set_rx_steer_config(netdev, dev, args);\n \n dpdk_set_rxq_config(dev, args);\n \n","prefixes":["ovs-dev","v2"]}