{"id":2221820,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221820/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410120318.997202495@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260410120318.997202495@kernel.org>","date":"2026-04-10T12:20:11","name":"[21/38] hamradio: baycom_epp: Remove BAYCOM_DEBUG","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"95c0538da412a69a6d904c50360b8c6254ff5f1c","submitter":{"id":92397,"url":"http://patchwork.ozlabs.org/api/1.1/people/92397/?format=json","name":"Thomas Gleixner","email":"tglx@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410120318.997202495@kernel.org/mbox/","series":[{"id":499449,"url":"http://patchwork.ozlabs.org/api/1.1/series/499449/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499449","date":"2026-04-10T12:18:27","name":"treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use","version":1,"mbox":"http://patchwork.ozlabs.org/series/499449/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221820/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221820/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=K9r3LlHr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19591-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=K9r3LlHr;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=tglx@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbW65ffcz1y2d\n\tfor ; Fri, 10 Apr 2026 22:21:06 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsbV94p7Hz3bgx;\n\tFri, 10 Apr 2026 22:20:17 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsbV85qpjz2yZ6\n\tfor ; Fri, 10 Apr 2026 22:20:16 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id EFCF56111B;\n\tFri, 10 Apr 2026 12:20:14 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8C840C2BCB0;\n\tFri, 10 Apr 2026 12:20:13 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775823617;\n\tcv=none;\n b=TkiRAyzsbVD83PvQogSBLYzHUihUf0+8yZABF3gxjtQcJr3g6m7arL0omR9VLVqls1V2oGpwxdtfFvj7dZIMuCwDM/NLHDK1JB+dexLoErLrRcFHSpyTbcHqQ1kFwICOAdVX3a6K801ZbxweZAzIMeSBysyUn1Oh5x6knyNz15DfTFMxBwRTDzjRgJ1VF/zTaEwSzuAeNd4x1BTE2DWCNlc1Qpt2q+LEHDEgZ+N13OoP/NGVqOYTKjgyvlx2HD0MXd1kCshEApSfEXWmBw46RNK7+P+LVnmfYovpSwrxnAZ4TGj3+Y/Zka6bBW0YNhW3taydQapBMgV1NPqFxIj0WQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775823617; c=relaxed/relaxed;\n\tbh=uc43GoCkDGKCftnS7MZ3OA0khnbsdPYb8yxntAbHoVw=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=WGimUiL6ZwPWLceGdkM8GrD1P35BybpTRhxu1lON2D5bDQwwMmKYXqZT4Hc3IPWKwwHnmTyEv4z9BHrNFXMWj64mK5P10DeecpFvD2FjEp5ovnwyMGzxccPZUrQoXz3cL3L/Pyt/li/qE0Bvn2NnRlC5ewXvad6IeELJtN614sW1JYVN6pCjl/81kc41hZx9JLAylo6w5YWdklff2o1xD+oIxt3F6ndj1uWBZPNjxlFQTU1kADPIY+U1N917Qvjq33ovXCjRlIQ/1Vfaku4Q7ZezlUbkuNsS/mL/Hlx91TAjfqpE/G1cTFAQ6goKHWdfPK8fnFehjoTVQjIT4IIr/A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=K9r3LlHr; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=tglx@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823614;\n\tbh=fBmKDE903B55aOazdk1fgTYrHTdJzb3m7rYXj49+TyY=;\n\th=Date:From:To:Cc:Subject:References:From;\n\tb=K9r3LlHrTcCOkcDztBL2sK/tQ+yi3dZzcdFnxujOK2CvaNmPXdlKrSDZTOaDJVW4S\n\t 4mOX2OGTBKQ54SjOZcfKwdFhqUqz7KSUNqnVJajtIbXp/GGLFwlU7bEb8zVF3NgHwH\n\t 1PaUWksbUVEp48mOHI3J4/UWYuvo5lLJzmYA1j3FTzptfyaQ68k1o579nPzwBiXUsC\n\t 3DfIec/NNOEw9ut9tg7BENSlBdgvHCyF+4+WEDfTHmiMcBanB5cN+csJSB4d+fA+Ka\n\t C4Vf48Goy0kDdmbaemETnL+HfFRh1XMMUZS6QyYOK2+NJ2yf87fs8P9lxl4UXibsda\n\t 2J390A/pMX1Ag==","Date":"Fri, 10 Apr 2026 14:20:11 +0200","Message-ID":"<20260410120318.997202495@kernel.org>","User-Agent":"quilt/0.68","From":"Thomas Gleixner ","To":"LKML ","Cc":"Thomas Sailer ,\n linux-hams@vger.kernel.org,\n Arnd Bergmann ,\n x86@kernel.org,\n Lu Baolu ,\n iommu@lists.linux.dev,\n Michael Grzeschik ,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu ,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka ,\n linux-mm@kvack.org,\n David Woodhouse ,\n Bernie Thompson ,\n linux-fbdev@vger.kernel.org,\n \"Theodore Tso\" ,\n linux-ext4@vger.kernel.org,\n Andrew Morton ,\n Uladzislau Rezki ,\n Marco Elver ,\n Dmitry Vyukov ,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin ,\n \"Jason A. Donenfeld\" ,\n Richard Henderson ,\n linux-alpha@vger.kernel.org,\n Russell King ,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas ,\n Huacai Chen ,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven ,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen ,\n Jonas Bonn ,\n linux-openrisc@vger.kernel.org,\n Helge Deller ,\n linux-parisc@vger.kernel.org,\n Michael Ellerman ,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley ,\n linux-riscv@lists.infradead.org,\n Heiko Carstens ,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" ,\n sparclinux@vger.kernel.org","Subject":"[patch 21/38] hamradio: baycom_epp: Remove BAYCOM_DEBUG","References":"<20260410120044.031381086@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The whole code guarded by BAYCOM_DEBUG is only writing debug values into a\ndatastructure, but there is no way to ever access them.\n\nRemove the pointless ballast.\n\nThis is part of a larger effort to remove get_cycles() usage from\nnon-architecture code.\n\nSigned-off-by: Thomas Gleixner \nCc: Thomas Sailer \nCc: linux-hams@vger.kernel.org\n---\n drivers/net/hamradio/baycom_epp.c | 51 --------------------------------------\n 1 file changed, 51 deletions(-)","diff":"--- a/drivers/net/hamradio/baycom_epp.c\n+++ b/drivers/net/hamradio/baycom_epp.c\n@@ -44,7 +44,6 @@\n \n /* --------------------------------------------------------------------- */\n \n-#define BAYCOM_DEBUG\n #define BAYCOM_MAGIC 19730510\n \n /* --------------------------------------------------------------------- */\n@@ -191,18 +190,6 @@ struct baycom_state {\n \n \tunsigned int ptt_keyed;\n \tstruct sk_buff *skb; /* next transmit packet */\n-\n-#ifdef BAYCOM_DEBUG\n-\tstruct debug_vals {\n-\t\tunsigned long last_jiffies;\n-\t\tunsigned cur_intcnt;\n-\t\tunsigned last_intcnt;\n-\t\tint cur_pllcorr;\n-\t\tint last_pllcorr;\n-\t\tunsigned int mod_cycles;\n-\t\tunsigned int demod_cycles;\n-\t} debug_vals;\n-#endif /* BAYCOM_DEBUG */\n };\n \n /* --------------------------------------------------------------------- */\n@@ -259,26 +246,6 @@ static inline int calc_crc_ccitt(const u\n \n #define tenms_to_flags(bc,tenms) ((tenms * bc->bitrate) / 800)\n \n-/* --------------------------------------------------------------------- */\n-\n-static inline void baycom_int_freq(struct baycom_state *bc)\n-{\n-#ifdef BAYCOM_DEBUG\n-\tunsigned long cur_jiffies = jiffies;\n-\t/*\n-\t * measure the interrupt frequency\n-\t */\n-\tbc->debug_vals.cur_intcnt++;\n-\tif (time_after_eq(cur_jiffies, bc->debug_vals.last_jiffies + HZ)) {\n-\t\tbc->debug_vals.last_jiffies = cur_jiffies;\n-\t\tbc->debug_vals.last_intcnt = bc->debug_vals.cur_intcnt;\n-\t\tbc->debug_vals.cur_intcnt = 0;\n-\t\tbc->debug_vals.last_pllcorr = bc->debug_vals.cur_pllcorr;\n-\t\tbc->debug_vals.cur_pllcorr = 0;\n-\t}\n-#endif /* BAYCOM_DEBUG */\n-}\n-\n /* ---------------------------------------------------------------------- */\n /*\n * eppconfig_path should be setable via /proc/sys.\n@@ -621,13 +588,6 @@ static int receive(struct net_device *de\n \treturn ret;\n }\n \n-/* --------------------------------------------------------------------- */\n-\n-#define GETTICK(x)\t\t\t\t\t\t\\\n-({\t\t\t\t\t\t\t\t\\\n-\tx = (unsigned int)get_cycles();\t\t\t\t\\\n-})\n-\n static void epp_bh(struct work_struct *work)\n {\n \tstruct net_device *dev;\n@@ -635,21 +595,17 @@ static void epp_bh(struct work_struct *w\n \tstruct parport *pp;\n \tunsigned char stat;\n \tunsigned char tmp[2];\n-\tunsigned int time1 = 0, time2 = 0, time3 = 0;\n \tint cnt, cnt2;\n \n \tbc = container_of(work, struct baycom_state, run_work.work);\n \tdev = bc->dev;\n \tif (!bc->work_running)\n \t\treturn;\n-\tbaycom_int_freq(bc);\n \tpp = bc->pdev->port;\n \t/* update status */\n \tif (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)\n \t\tgoto epptimeout;\n \tbc->stat = stat;\n-\tbc->debug_vals.last_pllcorr = stat;\n-\tGETTICK(time1);\n \tif (bc->modem == EPP_FPGAEXTSTATUS) {\n \t\t/* get input count */\n \t\ttmp[0] = EPP_TX_FIFO_ENABLE|EPP_RX_FIFO_ENABLE|EPP_MODEM_ENABLE|1;\n@@ -673,7 +629,6 @@ static void epp_bh(struct work_struct *w\n \t\t\tgoto epptimeout;\n \t\tif (transmit(bc, cnt2, stat))\n \t\t\tgoto epptimeout;\n-\t\tGETTICK(time2);\n \t\tif (receive(dev, cnt))\n \t\t\tgoto epptimeout;\n \t\tif (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)\n@@ -700,7 +655,6 @@ static void epp_bh(struct work_struct *w\n \t\t}\n \t\tif (transmit(bc, cnt, stat))\n \t\t\tgoto epptimeout;\n-\t\tGETTICK(time2);\n \t\t/* do receiver */\n \t\twhile ((stat & (EPP_NRAEF|EPP_NRHF)) != EPP_NRHF) {\n \t\t\tswitch (stat & (EPP_NRAEF|EPP_NRHF)) {\n@@ -734,11 +688,6 @@ static void epp_bh(struct work_struct *w\n \t\t\t\tgoto epptimeout;\n \t\t}\n \t}\n-\tGETTICK(time3);\n-#ifdef BAYCOM_DEBUG\n-\tbc->debug_vals.mod_cycles = time2 - time1;\n-\tbc->debug_vals.demod_cycles = time3 - time2;\n-#endif /* BAYCOM_DEBUG */\n \tschedule_delayed_work(&bc->run_work, 1);\n \tif (!bc->skb)\n \t\tnetif_wake_queue(dev);\n","prefixes":["21/38"]}