{"id":2221732,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221732/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260410074921.1254213-4-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410074921.1254213-4-aleksandr.loktionov@intel.com>","date":"2026-04-10T07:49:14","name":"[iwl-next,3/10] ice: add PORT_AUI and PORT_NONE ethtool port type reporting","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e751e1d029b3821cc50f4ba8440c8fec0877cb6a","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260410074921.1254213-4-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499419,"url":"http://patchwork.ozlabs.org/api/1.1/series/499419/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499419","date":"2026-04-10T07:49:11","name":"ice: misc cleanups and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/499419/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221732/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221732/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=zqB4vr8L;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsTTv2WSDz1yCv\n\tfor ; Fri, 10 Apr 2026 17:49:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7BE9C60B79;\n\tFri, 10 Apr 2026 07:49:34 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tSg-dX2Ehe7j; Fri, 10 Apr 2026 07:49:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 78AE460B1C;\n\tFri, 10 Apr 2026 07:49:32 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 686EB1F6\n for ; Fri, 10 Apr 2026 07:49:30 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 5A76481A81\n for ; Fri, 10 Apr 2026 07:49:30 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id R3VVuGsx7RsB for ;\n Fri, 10 Apr 2026 07:49:29 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 40E24816EE\n for ; Fri, 10 Apr 2026 07:49:29 +0000 (UTC)","from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 00:49:29 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa008.jf.intel.com with ESMTP; 10 Apr 2026 00:49:28 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 78AE460B1C","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 40E24816EE"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775807372;\n\tbh=B7PniQdktGTH5Xbz6NoC1eHTHqXDZUUFFZdptj4zKrM=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=zqB4vr8LupVWcf0mW7xlf9oN8hMU8uxPJmLSeRhn2PaqrIZ++SIkw3FsmbTbDI1Zf\n\t aAu58T72P2oi+o+DT37VBK2kSxC+fz0BbKu7lt3qDt+puK7WLU71T31tDmroO3W9SH\n\t XQ7uGBlKQVCchKGE6h3/MkhpODv+MjQiULcRoz/b2xytVKrpOCIMtTl24pk+4bMYjY\n\t pKkve1839o20txMC5llfqY1NFBvNkxzsy8EkQZUy+OeJ++H0TXL2j0Qt960DALeQF6\n\t PCLSe+T4lFsBhy0p87f+PhowBwtwXQkQhwRgomr8ERrPWnZlgi6SKlOrYIAbWwK8s3\n\t HgYM2V94RfZDw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 40E24816EE","X-CSE-ConnectionGUID":["T5eZrwhzTEK5bWWnsUEsmA==","WJom4z9jSietYueaIRcQKA=="],"X-CSE-MsgGUID":["lc9OStPkSWG7reI+fW84HQ==","n7uYW9p8TIeLoY4+ufg6qA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11754\"; a=\"77007925\"","E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"77007925\"","E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"228941865\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org,\n\tPaul Greenwalt ","Date":"Fri, 10 Apr 2026 09:49:14 +0200","Message-ID":"<20260410074921.1254213-4-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260410074921.1254213-1-aleksandr.loktionov@intel.com>","References":"<20260410074921.1254213-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775807369; x=1807343369;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=NcU0Iz9MD/rDovwL1/g0sA94Rz0+LbfmauAxlyFyR6A=;\n b=hj3nMhFHfR3Jhxk5Q/GXPFeBoiQGh4Jw92mucPltKK8lfVI6avppWoSD\n ReAizf2E6tQ81usGv2xp/yXJyV0a45x2cBNzSaF6FrfGBRxnUP0s8G2pZ\n mxdApXWS5QCvaYivrvrcBZVDoI+h4DxFLkH8NsHQEQGvjt0WkqlxE7+6q\n zEySqQ5uuaEnt6Reg5sIxwrxBgrEn1SpR9318zsk44hY92dGDst5zeeop\n G92VfA5rzRjDU/1VXk9idbtSmPpXQktfgFT3O5asY/GMr70RLC349m5sU\n Xmh1yQaHOqKRA5uxI/+rUYY64zTztnQCuMUNaqOEYAqxJCn3WrXW5euxq\n g==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=hj3nMhFH"],"Subject":"[Intel-wired-lan] [PATCH iwl-next 3/10] ice: add PORT_AUI and\n PORT_NONE ethtool port type reporting","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Now that ICE_MEDIA_AUI and ICE_MEDIA_NONE enum values exist,\nice_get_link_ksettings() reports PORT_OTHER for both of them because the\nswitch falls through to the former default handler.\n\nReplace the catch-all default with an explicit ICE_MEDIA_UNKNOWN case for\nPORT_OTHER, and add proper ICE_MEDIA_AUI -> PORT_AUI and\nICE_MEDIA_NONE -> PORT_NONE mappings. The switch now covers every\nenum ice_media_type value.\n\nSuggested-by: Paul Greenwalt \nSigned-off-by: Aleksandr Loktionov \n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 11 +++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex caec297..6857fcd 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1901,9 +1901,18 @@ ice_get_link_ksettings(struct net_device *netdev,\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising, FIBRE);\n \t\tks->base.port = PORT_DA;\n \t\tbreak;\n-\tdefault:\n+\tcase ICE_MEDIA_AUI:\n+\t\tethtool_link_ksettings_add_link_mode(ks, supported, AUI);\n+\t\tethtool_link_ksettings_add_link_mode(ks, advertising, AUI);\n+\t\tks->base.port = PORT_AUI;\n+\t\tbreak;\n+\tcase ICE_MEDIA_NONE:\n+\t\tks->base.port = PORT_NONE;\n+\t\tbreak;\n+\tcase ICE_MEDIA_UNKNOWN:\n \t\tks->base.port = PORT_OTHER;\n \t\tbreak;\n+\t/* All ice_media_type enum values are explicitly handled above. */\n \t}\n \n \t/* flow control is symmetric and always supported */\n","prefixes":["iwl-next","3/10"]}