{"id":2221708,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221708/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410055040.39233-5-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260410055040.39233-5-kwilczynski@kernel.org>","date":"2026-04-10T05:50:24","name":"[04/20] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c49e0a73cbc2101568fc3de0ec56b181777ddad3","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410055040.39233-5-kwilczynski@kernel.org/mbox/","series":[{"id":499413,"url":"http://patchwork.ozlabs.org/api/1.1/series/499413/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499413","date":"2026-04-10T05:50:20","name":"PCI: Convert all dynamic sysfs attributes to static","version":1,"mbox":"http://patchwork.ozlabs.org/series/499413/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221708/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221708/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fFgo48Kh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19537-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fFgo48Kh;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsShv5Y9rz1y2d\n\tfor ; Fri, 10 Apr 2026 17:14:07 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsShv4TQ1z2yjs;\n\tFri, 10 Apr 2026 17:14:07 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsQs10yFkz2yRl\n\tfor ; Fri, 10 Apr 2026 15:51:01 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 4BF8D6013E;\n\tFri, 10 Apr 2026 05:50:59 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CFB7FC2BC9E;\n\tFri, 10 Apr 2026 05:50:55 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775800261;\n\tcv=none;\n b=SonXgiyg+DwmoYqX9+MxJCddAMSGyw4i8lf9DJN8IDWK0929uEu4YdIrf9+nRPlJyK4IS6pf4lZrjwfMcPrNtf3DOn5rpEt+UDN6fkK3fwcxARVQsZczQr3qGvRmvCVEdHi+5SbEk/qi8MCHNO/amiUdybKr57oqEyMsFEKIv0n+Rb6zDQAkVB09r6wRz5lswm2JVZugrJpZovQDUaPlPyGzcxwBZETn/WjUqU1ZnG27qDWoZsCn/GvaCigsg4lP/lUfZ6k/Ts4MIrz/nGQelOt6WvNTsWrwHWE1gzR/1Y7aibYhtj/A6D4xAlifqtERfWNJtocUdu6OYDHIMvuMgA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775800261; c=relaxed/relaxed;\n\tbh=ysD8K23LHB0BTmxbzGNFdfOIxZhJ0vrLMxkwZTsqprk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=lc2S7ExyVVkA6C1cwre9GFHxW5b/vcJ5iB0frroFiI4QJTJSSEpLEPIdFnYagCksDJu187mp8XCs+WuZCNKdGayV6VcjUvCeez9IEBeW6oQx0QkkenHj4qMOBwJ0OvfV4TuXWujK79n6L9hOG/f+gpvVTNxaCcqRqFRpk8R9Gl+SAR6KbaWMj8CevkH9Jat8HklEqvdDN2svuuQP9ZeWWaxlwDxNRVY6+eSf3Eyb5b+9yJ183mAn51TCm7dKSh54h5SVl4Tdkg+uzth5pezgdnCbMseey1vafru5Sfp7bfHi4Ep8J/1k7+Af+kOi63cjRaE2OISHKz+EYfORwDcSQg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fFgo48Kh; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775800259;\n\tbh=SoGJBLsBAedU3UkQnFKz0LBvzv23roF9wHFr+0WZ14I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fFgo48KhP2UwDP+v7nBAAQpFvOcYKzZLYUpNrDbkMijA1CB/EOL/wf0hnZlc+76nA\n\t QsgNEHBftINlrHeVEVCM5cfdhpaa2UA20qtkNr3ImV/HC/36UrrDrZu1vqo3Q8KvHH\n\t 8igsFPxntEMEia0YELY/E2uyNxICaOnxIC5jIi1ROZv8KDzNFgIncJy6+XVY/KlGVt\n\t hBUfxONpEMROdiKXuWSdcPvqOrOEmz5Tlvi5RZ7lP8ZW+WbtPwfj6HZ7o+ZSkR2k5I\n\t lKraDdD1mdbrwxowYEuiId6ylp90u/2drCdw7XYpIg3MuyfilzxfGOPlCH6FY0sPJl\n\t GaMDcCMe1ufsA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 04/20] PCI/sysfs: Add CAP_SYS_ADMIN check to\n __resource_resize_store()","Date":"Fri, 10 Apr 2026 05:50:24 +0000","Message-ID":"<20260410055040.39233-5-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410055040.39233-1-kwilczynski@kernel.org>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, the __resource_resize_store() allows writing to the\nresourceN_resize sysfs attribute to change a BAR's size without\nchecking for capabilities, currently relying only on the file\naccess check.\n\nResizing a BAR modifies PCI device configuration and can disrupt\nactive drivers. After the upcoming conversion to static attributes,\nit will also trigger resource file updates via sysfs_update_groups().\n\nThus, add a CAP_SYS_ADMIN check to prevent unprivileged users from\nperforming BAR resize operations.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex ac4e7c516e78..6b8c8e62f68a 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1619,6 +1619,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tint ret;\n \tu16 cmd;\n \n+\tif (!capable(CAP_SYS_ADMIN))\n+\t\treturn -EPERM;\n+\n \tif (kstrtoul(buf, 0, &size) < 0)\n \t\treturn -EINVAL;\n \n","prefixes":["04/20"]}