{"id":2221702,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221702/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260410070935.9540-1-bartosz.golaszewski@oss.qualcomm.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410070935.9540-1-bartosz.golaszewski@oss.qualcomm.com>","date":"2026-04-10T07:09:35","name":"pinctrl: mediatek: moore: implement gpio_chip::get_direction()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a4434030095a05f77d16b9b1bf6571dca0fde223","submitter":{"id":92196,"url":"http://patchwork.ozlabs.org/api/1.1/people/92196/?format=json","name":"Bartosz Golaszewski","email":"bartosz.golaszewski@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260410070935.9540-1-bartosz.golaszewski@oss.qualcomm.com/mbox/","series":[{"id":499411,"url":"http://patchwork.ozlabs.org/api/1.1/series/499411/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=499411","date":"2026-04-10T07:09:35","name":"pinctrl: mediatek: moore: implement gpio_chip::get_direction()","version":1,"mbox":"http://patchwork.ozlabs.org/series/499411/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221702/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221702/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=TDZJbw28;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=RNJk9nNP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34982-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"TDZJbw28\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"RNJk9nNP\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsSby3TMpz1yGb\n\tfor ; Fri, 10 Apr 2026 17:09:50 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 6E48C3007E04\n\tfor ; Fri, 10 Apr 2026 07:09:48 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A427A395DB5;\n\tFri, 10 Apr 2026 07:09:47 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D61A3939C1\n\tfor ; Fri, 10 Apr 2026 07:09:46 +0000 (UTC)","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63A4gTJd2698273\n\tfor ; Fri, 10 Apr 2026 07:09:45 GMT","from mail-qt1-f200.google.com (mail-qt1-f200.google.com\n [209.85.160.200])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4degt9t21b-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Fri, 10 Apr 2026 07:09:45 +0000 (GMT)","by mail-qt1-f200.google.com with SMTP id\n d75a77b69052e-50d68dbb77bso34842751cf.2\n for ;\n Fri, 10 Apr 2026 00:09:45 -0700 (PDT)","from brgl-qcom.home ([2a01:cb1d:dc:7e00:7d6c:c663:fa06:9ee8])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e50289sm5338689f8f.28.2026.04.10.00.09.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Apr 2026 00:09:43 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775804987; cv=none;\n b=RsGilzIFfCT78yRRLE1AhmC/ZgTO1rEfKG4th5F0fmRwYbZSWiFdJrGpb+LBuDSU5EQfqGaWYwbwtih7KvWeacaEnMAuoPS3PU/KUUyUwtnWfjQNIs3mluKnwRWu/jrJucLNr1hH858T75Zs4P+Q4w+2IqndvLfgHtblg+dXifk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775804987; c=relaxed/simple;\n\tbh=/xh8mbmsndrtfR6dGnoexqxNFoHHbegyXk8sqrhDi/g=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=VRY6RN28MQyyAvSdUzhEIQ3cZwdNtbkHJLDcjQRrtiV8CzBMW96Texuns7hJ5Ea0tv3S9hvw/unh6/K955GhSiFwy6k8DlVifK+PwwWMfqq90qHzQJerHlmwdy6VEHOUqvWMrh5TpgRaqbyN2yZhTT7MacE0DvIMOiTeBF2nFyI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=TDZJbw28;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=RNJk9nNP; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=5P8NXaOriPkPC2q0IRIWz9wKZcBWfE5/xl+\n\tXEf1jVQ4=; b=TDZJbw28P7WvcFvFthM1dYWl7MpKJOVzb/nmk83ywwpePZQIurg\n\tpQLwORmoW6gH15oGMA/yBgtVtZfW62pBWog+rqSyHM0d9S3k1Ty6dTKBndlAA8wN\n\tR9NQULd1MQ/+WUaYDgr7LL4Ron4es66rYcDkNXbXeTB9hcE8FMd91Sd3Y8FGLlxG\n\tY26FYG+IcdWTJlMpY70fWiopkb4gka6ARm7t74lZi7zmbW8B3BpkwV0CNZkHM0E+\n\t1EdwVtLLVU9p3FNnIv1rEIBWucMvFFvqBZuVsE8HFYBvbvaowQWv26dChumtmMwM\n\tu+l+9lBe2BI70nrzr3l+d4uxN6RDLQuqI7g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775804984; x=1776409784;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=5P8NXaOriPkPC2q0IRIWz9wKZcBWfE5/xl+XEf1jVQ4=;\n b=RNJk9nNPyS4WHtOo2OiUkqXrKtUEpHWNvpRXbI6Zzt+DKG1EXqkTc1MDqPTbBFFepq\n DKLIKOqKDG3XZm3K1bAFdOYzyIgmFTGf+wxXkHSbEH/dl83vSTEUvOFHYUh9zFM5fjVz\n cJ9ubviHKJAqv/pjnOMec87Xal2MxfNeekLWucv+hOROH+dZCqH2zTWUAOXJ/7IHEyj0\n P5K9LHF+ZA3/QrUb58qJGzBVkkzoa6CmUApo9Y8po50W1prsjY2aWcp+EZqPGzikImul\n Xsv8Rv8fLFhC5xEMiRg4ATGY6FH+HURXqqaGzHCbwdpRL3UdHXuGNnL/wEi6k7idVP5q\n kKfg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775804984; x=1776409784;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5P8NXaOriPkPC2q0IRIWz9wKZcBWfE5/xl+XEf1jVQ4=;\n b=ocOl1w1uhje/fpCmHEjvuNE+QXwIXNz/wS3oJ5mitq9rQ9AAgB+6xZNkxRqLrM3hAk\n T6UkWSNYYslyxhotgahlDVU9AghnUitbwoFm3C3AqYS1dKvYFphMaV36UhIVscaWDGy+\n CIv1QhEGQtsE7PuFfSj+nc+fksg10bps/IxXCnYqtacfDaOjqN4Q4oE7+9GF0dhOgUjX\n ycdvWm7x/TKA0k0b8et29CKfKghl0JOkhlp1JAritmwfAeecXOexMfiITreXPkXIiJAp\n J8maaJHSLANQvpgK13GWF1KbhtxTkDuU8an3BBJrPmiOVQYssAqcGcLptctRzvU0CmYV\n /H0w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX4wqs9z1TsS5z1ckqVARx3VBbUg8uV0nqwPpndIQy8a124GUNDb81q6uLO95JIYxvHIxL73fakSj0m@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw1ljRiu7jaEx3XO2W+FkhV/VFOG/iMa8z7VPFS1+7p60gKdYWG\n\tWJpZ4hCW7kW1UvE9dbOh9M4yO8/LriyDZnfvdGKS54Qat9A8841gS6hfxawS7+27rhu6NsYfLhv\n\tCJdepemHmACNnvtuZolrKdTuXhURf34TKDtdDxzEiLdZbys7t0j+t7a3gRz89DDRsMYYFtTSR","X-Gm-Gg":"AeBDievCvdtXwns2cJEEM/oI7yadA5sBuWZ7dGm6th1KuS8fuiuX2G8HZR69TwknNqM\n\t1+AaWfWNtjdUgRssVWMKoND27U9XwvLhhKgxK0/rHn2WH5G8inpezxxM2OImp/MmXuIytaLEHKW\n\tSfMy5aV7DS8AQkDCtpi4H0o2LxdK13rq8uAvAz2yEsXfb4HOQWcL6i+aPO2Iu3VoHXLhEd8M4x3\n\tqVmM0d6Vgfp6t+r/wdiAEwPOJG3VPjCg++EhhWWLnlc0MuMpgYPI9Tzq0/UV+24L3Z2YkafNAIA\n\tB1JAuX/tiLvf9l7bPbEo6clDxjeh5ieiBGXGKz0+aYxs4CVjOlSiDWHm3i1vbLX58bovw1tRqKG\n\tF514G/7Jn5wUl1wvUUf10V/5bVPcsfyWM0TZpol6PgjUu/sBnLQ==","X-Received":["by 2002:a05:622a:834f:b0:50d:aa99:7bbf with SMTP id\n d75a77b69052e-50dd5c0be6bmr27268941cf.43.1775804984526;\n Fri, 10 Apr 2026 00:09:44 -0700 (PDT)","by 2002:a05:622a:834f:b0:50d:aa99:7bbf with SMTP id\n d75a77b69052e-50dd5c0be6bmr27268711cf.43.1775804984031;\n Fri, 10 Apr 2026 00:09:44 -0700 (PDT)"],"From":"Bartosz Golaszewski ","To":"Frank Wunderlich , Sean Wang ,\n Linus Walleij ,\n Matthias Brugger ,\n AngeloGioacchino Del Regno ,\n Bartosz Golaszewski ","Cc":"linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n Bartosz Golaszewski ","Subject":"[PATCH] pinctrl: mediatek: moore: implement\n gpio_chip::get_direction()","Date":"Fri, 10 Apr 2026 09:09:35 +0200","Message-ID":"<20260410070935.9540-1-bartosz.golaszewski@oss.qualcomm.com>","X-Mailer":"git-send-email 2.47.3","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEwMDA2NCBTYWx0ZWRfX84GtHKOQuqGP\n Kpm2limBrHr/xJXgMs1l8NrgznFmLBxUhFuKzcF2iet+8n87IeVog+qISG3EqmoAoyROevJCY8+\n N3TWban91RLkxB3O2lrn7X/zo083t19cfg+xEsBY/N7AtqVSnOmE54SDHIUsukZrLeY29tKIzxr\n Jv2NRWKJ5IeTLkMSctmYttpRCELbIAGrWnFIrqc8IgaCm7m7wXYr4GTVL21A3GXtTmlHDKHmAs1\n zk4UnhMBtNi7BWX7zlHMA3dzf0O6YtI+JOpkho/2w/bqNrr7b5uk691ev6sxFl4VVoGLhAWBOlh\n Phmp/0ATbdeKXt879i+INI23pZTt54YTHCbqEU/lvAAMEh5sSE/4vFWQFWgEQ6AC4igMRLnYLeh\n Lyf4wcp72ogKl5KG4dXhAaNuaMvSTwVNww4BkNWEC/cA/6XJrLQvz4wrXEmJlwkyMS2y7811D5z\n urkor5nFWnfiF/yNUgg==","X-Proofpoint-ORIG-GUID":"eCNjowaXSAtkUjBxiteuITdZOlU47tO5","X-Proofpoint-GUID":"eCNjowaXSAtkUjBxiteuITdZOlU47tO5","X-Authority-Analysis":"v=2.4 cv=BJyDalQG c=1 sm=1 tr=0 ts=69d8a239 cx=c_pps\n a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8\n a=gdeKHt93fcZDdug0Yb8A:9 a=uxP6HrT_eTzRwkO_Te1X:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-10_02,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0\n priorityscore=1501 impostorscore=0 clxscore=1015 phishscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100064"},"content":"If the gpio_chip::get_direction() callback is not implemented by the GPIO\ncontroller driver, GPIOLIB emits a warning.\n\nImplement get_direction() for the GPIO part of pinctrl-moore.\n\nFixes: 471e998c0e31 (\"gpiolib: remove redundant callback check\")\nFixes: e623c4303ed1 (\"gpiolib: sanitize the return value of gpio_chip::get_direction()\")\nReported-by: Frank Wunderlich \nCloses: https://lore.kernel.org/all/20260409132724.126258-1-linux@fw-web.de/\nSigned-off-by: Bartosz Golaszewski \n---\n drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)","diff":"diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c\nindex 70f608347a5f6..071ba849e5322 100644\n--- a/drivers/pinctrl/mediatek/pinctrl-moore.c\n+++ b/drivers/pinctrl/mediatek/pinctrl-moore.c\n@@ -520,6 +520,23 @@ static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio,\n \treturn pinctrl_gpio_direction_output(chip, gpio);\n }\n \n+static int mtk_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)\n+{\n+\tstruct mtk_pinctrl *hw = gpiochip_get_data(chip);\n+\tconst struct mtk_pin_desc *desc;\n+\tint ret, dir;\n+\n+\tdesc = (const struct mtk_pin_desc *)&hw->soc->pins[offset];\n+\tif (!desc->name)\n+\t\treturn -ENOTSUPP;\n+\n+\tret = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_DIR, &dir);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\treturn dir ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN;\n+}\n+\n static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)\n {\n \tstruct mtk_pinctrl *hw = gpiochip_get_data(chip);\n@@ -566,6 +583,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw)\n \tchip->parent\t\t= hw->dev;\n \tchip->request\t\t= gpiochip_generic_request;\n \tchip->free\t\t= gpiochip_generic_free;\n+\tchip->get_direction\t= mtk_gpio_get_direction;\n \tchip->direction_input\t= pinctrl_gpio_direction_input;\n \tchip->direction_output\t= mtk_gpio_direction_output;\n \tchip->get\t\t= mtk_gpio_get;\n","prefixes":[]}