{"id":2221666,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221666/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-6-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260410055040.39233-6-kwilczynski@kernel.org>","date":"2026-04-10T05:50:25","name":"[05/20] PCI/sysfs: Add static PCI resource attribute macros","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e58bac87ab0428c857721b0e251d09860ce8bd87","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-6-kwilczynski@kernel.org/mbox/","series":[{"id":499398,"url":"http://patchwork.ozlabs.org/api/1.1/series/499398/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499398","date":"2026-04-10T05:50:21","name":"PCI: Convert all dynamic sysfs attributes to static","version":1,"mbox":"http://patchwork.ozlabs.org/series/499398/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221666/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221666/checks/","tags":{},"headers":{"Return-Path":"\n <linux-pci+bounces-52267-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Y9ryeqGM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52267-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Y9ryeqGM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsQs60wBsz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 15:51:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id F11DE300C6C9\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 05:51:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1C6973264DC;\n\tFri, 10 Apr 2026 05:51:03 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EDECB30F52A;\n\tFri, 10 Apr 2026 05:51:02 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 5B023C19424;\n\tFri, 10 Apr 2026 05:50:59 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775800263; cv=none;\n b=J51YN9n6+jPOWTtqiKrcI6o1RLy2MTlg845LhS7eZJZfkAGbEr/g5t5lXTH7ZXgZ8lEtn0DSN7MUSxmsGml+MPliaXgIjiA3YyVWKoeJ3kTzD3T209eKji98Hnee3JMAATbX+US5j3FD+SKlTZmY9pcw/0JGJ+QrjqPg0bbU7eQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775800263; c=relaxed/simple;\n\tbh=Jl/CqRDCeCLI+hvaYW9X7cU2GJJVSRyyY/vEVWNYR6U=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=lN7JqPtdYmmQbs2+0ugTQjccSvtdxoZRRAwmxSnzWIJNIAOX31nZtmYt86ICZDLxhn4VphXaykfD4SPrwp88vu0F+j3SSRZ8KQ7zSlvhMbWdbG5fMdYhsq1f9fVfn7HNr8QvD9dtkhVdPH55PAoiGilkgc5EV+nHpMoZkxxT6VA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Y9ryeqGM; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775800262;\n\tbh=Jl/CqRDCeCLI+hvaYW9X7cU2GJJVSRyyY/vEVWNYR6U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Y9ryeqGMhfUQt6iNjkMXN+tFxZqVheQae+upre/T2m6AjawDlXhjV6HYvVyaI7EGo\n\t 2ZpxrTWLNwAHa+rQVcfyucCEuha+govFmDAe3UCLb6/X4E3egZmibWhGz+1sIuZis0\n\t dyp/xArjE2f8Nvtq2b05CuE/K5gPJ9BaNvMidTC81SacrhQvO8poGWvEIiUoSKjAow\n\t +Obvt2GnVRLgz/5LB/wWnlcyy72zk/Kfr865EYjx5Oq6vpqexLv85znTJYrpFdJ0s5\n\t nwAGUXr6W43glUhueOuPgN/KMgcr426lM+dlQQnzJkTaREBQ58GRjfejEaZh4FdqB/\n\t Xyxicu/sDHRsA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>","To":"Bjorn Helgaas <bhelgaas@google.com>","Cc":"Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 05/20] PCI/sysfs: Add static PCI resource attribute macros","Date":"Fri, 10 Apr 2026 05:50:25 +0000","Message-ID":"<20260410055040.39233-6-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410055040.39233-1-kwilczynski@kernel.org>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Add three macros for declaring static binary attributes for PCI\nresource files:\n\n  - pci_dev_resource_io_attr(), for I/O BAR resources (read/write)\n  - pci_dev_resource_uc_attr(), for memory BAR resources (mmap uncached)\n  - pci_dev_resource_wc_attr(), for write-combine resources (mmap WC)\n\nEach macro only sets the callbacks its resource type needs.  The I/O\nmacro conditionally includes mmap support via __PCI_RESOURCE_IO_MMAP_ATTRS\non architectures where arch_can_pci_mmap_io() is true at compile time\n(such as PowerPC, SPARC, and Xtensa).\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/pci-sysfs.c | 41 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 41 insertions(+)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 6b8c8e62f68a..d29d79be8ee5 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1220,6 +1220,47 @@ static ssize_t pci_write_resource_io(struct file *filp, struct kobject *kobj,\n \treturn pci_resource_io(filp, kobj, attr, buf, off, count, true);\n }\n \n+/*\n+ * generic_file_llseek() consults f_mapping->host to determine\n+ * the file size. As iomem_inode knows nothing about the\n+ * attribute, it's not going to work, so override it as well.\n+ */\n+#if arch_can_pci_mmap_io()\n+# define __PCI_RESOURCE_IO_MMAP_ATTRS\t\t\\\n+\t.f_mapping = iomem_get_mapping,\t\t\\\n+\t.llseek = pci_llseek_resource,\t\t\\\n+\t.mmap = pci_mmap_resource_uc,\n+#else\n+# define __PCI_RESOURCE_IO_MMAP_ATTRS\n+#endif\n+\n+#define pci_dev_resource_io_attr(_bar)\t\t\t\t\t\\\n+static const struct bin_attribute dev_resource##_bar##_io_attr = {\t\\\n+\t.attr = { .name = \"resource\" __stringify(_bar), .mode = 0600 },\t\\\n+\t.private = (void *)(unsigned long)(_bar),\t\t\t\\\n+\t.read = pci_read_resource,\t\t\t\t\t\\\n+\t.write = pci_write_resource,\t\t\t\t\t\\\n+\t__PCI_RESOURCE_IO_MMAP_ATTRS\t\t\t\t\t\\\n+}\n+\n+#define pci_dev_resource_uc_attr(_bar)\t\t\t\t\t\\\n+static const struct bin_attribute dev_resource##_bar##_uc_attr = {\t\\\n+\t.attr = { .name = \"resource\" __stringify(_bar), .mode = 0600 },\t\\\n+\t.private = (void *)(unsigned long)(_bar),\t\t\t\\\n+\t.f_mapping = iomem_get_mapping,\t\t\t\t\t\\\n+\t.llseek = pci_llseek_resource,\t\t\t\t\t\\\n+\t.mmap = pci_mmap_resource_uc,\t\t\t\t\t\\\n+}\n+\n+#define pci_dev_resource_wc_attr(_bar)\t\t\t\t\t\t\\\n+static const struct bin_attribute dev_resource##_bar##_wc_attr = {\t\t\\\n+\t.attr = { .name = \"resource\" __stringify(_bar) \"_wc\", .mode = 0600 },\t\\\n+\t.private = (void *)(unsigned long)(_bar),\t\t\t\t\\\n+\t.f_mapping = iomem_get_mapping,\t\t\t\t\t\t\\\n+\t.llseek = pci_llseek_resource,\t\t\t\t\t\t\\\n+\t.mmap = pci_mmap_resource_wc,\t\t\t\t\t\t\\\n+}\n+\n /**\n  * pci_remove_resource_files - cleanup resource files\n  * @pdev: dev to cleanup\n","prefixes":["05/20"]}