{"id":2221665,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221665/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-5-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260410055040.39233-5-kwilczynski@kernel.org>","date":"2026-04-10T05:50:24","name":"[04/20] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c49e0a73cbc2101568fc3de0ec56b181777ddad3","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-5-kwilczynski@kernel.org/mbox/","series":[{"id":499398,"url":"http://patchwork.ozlabs.org/api/1.1/series/499398/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499398","date":"2026-04-10T05:50:21","name":"PCI: Convert all dynamic sysfs attributes to static","version":1,"mbox":"http://patchwork.ozlabs.org/series/499398/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221665/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221665/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fFgo48Kh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52266-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"fFgo48Kh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsQs31W4tz1yGb\n\tfor ; Fri, 10 Apr 2026 15:51:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 10C003010777\n\tfor ; Fri, 10 Apr 2026 05:51:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7FFC030F52A;\n\tFri, 10 Apr 2026 05:50:59 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5B230BF5C;\n\tFri, 10 Apr 2026 05:50:59 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CFB7FC2BC9E;\n\tFri, 10 Apr 2026 05:50:55 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775800259; cv=none;\n b=XeZZ4uEKjnhngw5FDnwzqne9ubyv70UUC+9vbuDWxoVDDbiKOs/konKu3Cb/9gD3eAH3zeZ3+HxtUHLYE4Yuk+jSMs3yaKqPnAGWHqUSLPomqM4+jAQ8fla7gA74KHswaFqsLcjP4aIDx5e1AXUpVxufsfvJModdUrTTDwXHxKE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775800259; c=relaxed/simple;\n\tbh=SoGJBLsBAedU3UkQnFKz0LBvzv23roF9wHFr+0WZ14I=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=ehPQpaoDe7l0xuOG9AkQwoLApJIpbAyAvtwCg9R4Faxum2OSkv969fn142+4czwnRiFh2+gc30anilMu9+weaWU9wp1UlB460Uee4fxEAvRNPqu8X6aedHGAdtllYYlaVV78SKriiQ5RQvX/bZjsBGzdsENEspaPRAfbdBkIsSQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=fFgo48Kh; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775800259;\n\tbh=SoGJBLsBAedU3UkQnFKz0LBvzv23roF9wHFr+0WZ14I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fFgo48KhP2UwDP+v7nBAAQpFvOcYKzZLYUpNrDbkMijA1CB/EOL/wf0hnZlc+76nA\n\t QsgNEHBftINlrHeVEVCM5cfdhpaa2UA20qtkNr3ImV/HC/36UrrDrZu1vqo3Q8KvHH\n\t 8igsFPxntEMEia0YELY/E2uyNxICaOnxIC5jIi1ROZv8KDzNFgIncJy6+XVY/KlGVt\n\t hBUfxONpEMROdiKXuWSdcPvqOrOEmz5Tlvi5RZ7lP8ZW+WbtPwfj6HZ7o+ZSkR2k5I\n\t lKraDdD1mdbrwxowYEuiId6ylp90u/2drCdw7XYpIg3MuyfilzxfGOPlCH6FY0sPJl\n\t GaMDcCMe1ufsA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 04/20] PCI/sysfs: Add CAP_SYS_ADMIN check to\n __resource_resize_store()","Date":"Fri, 10 Apr 2026 05:50:24 +0000","Message-ID":"<20260410055040.39233-5-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410055040.39233-1-kwilczynski@kernel.org>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, the __resource_resize_store() allows writing to the\nresourceN_resize sysfs attribute to change a BAR's size without\nchecking for capabilities, currently relying only on the file\naccess check.\n\nResizing a BAR modifies PCI device configuration and can disrupt\nactive drivers. After the upcoming conversion to static attributes,\nit will also trigger resource file updates via sysfs_update_groups().\n\nThus, add a CAP_SYS_ADMIN check to prevent unprivileged users from\nperforming BAR resize operations.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex ac4e7c516e78..6b8c8e62f68a 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1619,6 +1619,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tint ret;\n \tu16 cmd;\n \n+\tif (!capable(CAP_SYS_ADMIN))\n+\t\treturn -EPERM;\n+\n \tif (kstrtoul(buf, 0, &size) < 0)\n \t\treturn -EINVAL;\n \n","prefixes":["04/20"]}