{"id":2221227,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221227/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408190214.1287708-1-matt@readmodwrite.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408190214.1287708-1-matt@readmodwrite.com>","date":"2026-04-08T19:02:14","name":"[net] ice: Fix missing 1's complement negation in GCS raw checksum","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"6be537700114fea203c57ba411843962e948684a","submitter":{"id":93093,"url":"http://patchwork.ozlabs.org/api/1.1/people/93093/?format=json","name":"Matt Fleming","email":"matt@readmodwrite.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/1.1/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408190214.1287708-1-matt@readmodwrite.com/mbox/","series":[{"id":499212,"url":"http://patchwork.ozlabs.org/api/1.1/series/499212/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499212","date":"2026-04-08T19:02:14","name":"[net] ice: Fix missing 1's complement negation in GCS raw checksum","version":1,"mbox":"http://patchwork.ozlabs.org/series/499212/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221227/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221227/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=djL13DL6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frbZV4JQ0z1xy1\n\tfor ; Thu, 09 Apr 2026 07:20:34 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 3444460831;\n\tWed, 8 Apr 2026 21:20:33 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xvFAyg-s5_b4; Wed, 8 Apr 2026 21:20:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 66BFD60790;\n\tWed, 8 Apr 2026 21:20:32 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 3CC681F6\n for ; Wed, 8 Apr 2026 19:02:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 22D384052D\n for ; Wed, 8 Apr 2026 19:02:21 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0R8rHDKLCV0e for ;\n Wed, 8 Apr 2026 19:02:20 +0000 (UTC)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n [IPv6:2a00:1450:4864:20::42b])\n by smtp2.osuosl.org (Postfix) with ESMTPS id CB5B94006F\n for ; Wed, 8 Apr 2026 19:02:19 +0000 (UTC)","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-43d23305225so44879f8f.2\n for ; Wed, 08 Apr 2026 12:02:19 -0700 (PDT)","from matt-Precision-5490.. ([2a09:bac6:37a8:ec8::179:1f4])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4f1a99sm64678239f8f.32.2026.04.08.12.02.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2026 12:02:17 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 66BFD60790","OpenDKIM Filter v2.11.0 smtp2.osuosl.org CB5B94006F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775683232;\n\tbh=H5kVGMWj80+QphQVczp12xoX+BKVAGC3CV86I0J4IZU=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=djL13DL6e7rvFjk/MMIwKuEJWvtvy16JD8L4nuw9Zft6q+PH/wo2+AZN7R4gVnyAN\n\t aDLRgcAgoJv1FSrWG9h5RlBsSzrkjseJYmOEIrciBwAUSb/ynnV4BePjHVVXzz2vqc\n\t namWUdtn20ydIytZ2PbfCakCy+5SNr5v2SB7ODKTiAdKdycPcwWUCT5b/lrNqTRLLo\n\t aIRwQkKfjdqESqmtmE6WQ7GafBm04dr1xKS7rVikvopda/8UBoNVDdO9uvUUKIfo/E\n\t X0H2CMr58+S7Wshs0qaeiWXJixrlO2I2isQEVKSk+h7zC6Wo6I9NqmnCssIXfyvx8e\n\t xrTJknzedXWOw==","Received-SPF":"None (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com;\n envelope-from=matt@readmodwrite.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org CB5B94006F","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775674938; x=1776279738;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=H5kVGMWj80+QphQVczp12xoX+BKVAGC3CV86I0J4IZU=;\n b=cmZ8mcJFmrZtoPw78qCggCN2OAtnzrzmJSxGw1NBX+wdp7IlNlkcwWLfb2oLfSn2+R\n 7mBnwp+PXvP4wvNXqnmsSq2BevBmoXQgsg2LBnvD2dnf5ozN0gGqeNMNWbnUL7hqUMDh\n ft7Hvg0uRRoTxHBLbwRxhU9iBMlF7yQNOsyORU0oYnIBD93n0gwniHl/2NU88hBCRKpJ\n 50+GX0X70uS5cGIJ2SMCcOeS8YDlDFRtMXZQpzbsc7L0WwRJI/AQkwfd0jJ/G2/Km+P5\n vIcdJbupLvhPWgFkKRNNChB0JFqnz7/2nVOF1f7d3kUj9bDEsEKasz0a5zrafyAliEW0\n w2+A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVhblRKf/V32URZEgCQabMdEo077NQU8BAwkgw9d4iv/h13Vtmn8zgZrVJeEW69V0hTvWRoRoOSCH+dCCMVC4w=@lists.osuosl.org","X-Gm-Message-State":"AOJu0Yznml/fll4/msUOiE3wjt237j5gyHqPgojsHk/1+jnUjdbF21SE\n RBosecr6LLf9JF18HAdyNar5qaIxSEecFFqZ0uAkE2G/PqFofU619q2G703E7UvXtVw=","X-Gm-Gg":"AeBDietol9Lu6+TWJ7TkLn5CsICwLHDyOV7tLpI/8UilWZsc90IF5fo9u2sAWaF/RkE\n yJGuEmSEcULdZ489jqQ7z9C1s1URzpqbO2WtqU4Ttymsa8wD7+XbdTXXKPVPLJUuu1wKYiVlswB\n /iPzaN+MA0oonAgfynK8tqrMZy8ARjOvA2SJX6zij79JPLV/QxRtNrsGsCq5WAJM3cuRJ4sSeGA\n tPBm+vo/+oDpQmJfkllQue6y/gOmOAqwquulllu61EMA0rbQrx8qbuHf8Im0o+AuGdP7oG1kviE\n kcbt27Q22QTdY9odNSQzwKxjjAl1umm7Rqqq9msNmDL9aPiMsYYsoXMvzVQRRYp8srkBykWmGd2\n hAB+Icu5R4df8PWH4+VMu+mtt+fvbG5qIIn8gHopaZBq9dlzRYqdFYqpWsYlcICT7ezAvOJ5ivx\n mKbn0Vh1M7P8604YIh5dQBfVrvgw==","X-Received":"by 2002:a05:6000:400a:b0:43d:4c:229f with SMTP id\n ffacd0b85a97d-43d292e27admr32977247f8f.44.1775674937668;\n Wed, 08 Apr 2026 12:02:17 -0700 (PDT)","From":"Matt Fleming ","To":"Tony Nguyen ,\n Przemek Kitszel ","Cc":"Andrew Lunn ,\n \"David S . Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n kernel-team@cloudflare.com, Matt Fleming ","Date":"Wed, 8 Apr 2026 20:02:14 +0100","Message-ID":"<20260408190214.1287708-1-matt@readmodwrite.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Wed, 08 Apr 2026 21:20:31 +0000","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1775674938;\n x=1776279738; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=H5kVGMWj80+QphQVczp12xoX+BKVAGC3CV86I0J4IZU=;\n b=tu1pnDZATOwKLqoNrwFXRxiVM8Wt4rx6X/oMFe7fhD5Vi9mAkmYYrJkiHravgq1hAI\n M1CGDGd/RXIlhx472jYY+BoHcVHUeiiRGB/MA7hbWEj1xXVqMr6RLALDA8XaFpvfFhwt\n ihnsjJQpUawK78bgytkEiMQezToWTquCH3wxazMez0ykD/BwscUQfpdD4X3Xf/sVZy5B\n q21Ff24kqKb5ZEVFcWk4RJ5chezLHfVYj8Tca5ScokPBxn8ud6GROBHusdeB0C+EgFxF\n o2dqppcT5StXZGW2O7mcVhb1TxZ6yWq9o1Oke0fo/UvnkFrXj2yZmXXq2ELJ7U5CvGFT\n tjNg==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=readmodwrite.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=readmodwrite-com.20251104.gappssmtp.com\n header.i=@readmodwrite-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=tu1pnDZA"],"Subject":"[Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n negation in GCS raw checksum","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Matt Fleming \n\nCommit 905d1a220e8d (\"ice: Add E830 checksum offload support\") added\nGeneric Checksum (GCS) support for E830 NICs but omitted the 1's\ncomplement negation (~) when converting the hardware raw_csum to\nskb->csum for CHECKSUM_COMPLETE.\n\nWithout the negation, every CHECKSUM_COMPLETE packet fails the\nfast-path validation in nf_ip_checksum() and falls through to software\nchecksumming via __skb_checksum_complete(), which triggers the\nrate-limited \"hw csum failure\" warning. Packets are still accepted\n(the software recheck passes) but hardware checksum offload is\neffectively disabled and the warning floods dmesg on systems running\nnf_conntrack on VLAN sub-interfaces.\n\nMultiple other drivers (idpf, ehea, iwlwifi, cassini, sunhme, enetc)\nalso apply ~ for CHECKSUM_COMPLETE. The ice driver was the only in-tree\nuser of csum_unfold() for CHECKSUM_COMPLETE that omitted it.\n\nFixes: 905d1a220e8d (\"ice: Add E830 checksum offload support\")\nSigned-off-by: Matt Fleming \n---\n drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\nindex e695a664e53d..c177579e0114 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n@@ -92,7 +92,7 @@ static void ice_rx_gcs(struct sk_buff *skb,\n \tdesc = (struct ice_32b_rx_flex_desc_nic *)rx_desc;\n \tskb->ip_summed = CHECKSUM_COMPLETE;\n \tcsum = (__force u16)desc->raw_csum;\n-\tskb->csum = csum_unfold((__force __sum16)swab16(csum));\n+\tskb->csum = csum_unfold((__force __sum16)~swab16(csum));\n }\n \n /**\n","prefixes":["net"]}