{"id":2221207,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221207/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408091459.4001711-1-dietmar@proxmox.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408091459.4001711-1-dietmar@proxmox.com>","date":"2026-04-08T09:14:59","name":"qemu-keymap: fix altgr modifier lookup for newer xkeyboard-config","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0778c1112d46c7608bd478d9c51fc94d2679736b","submitter":{"id":17956,"url":"http://patchwork.ozlabs.org/api/1.1/people/17956/?format=json","name":"Dietmar Maurer","email":"dietmar@proxmox.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408091459.4001711-1-dietmar@proxmox.com/mbox/","series":[{"id":499206,"url":"http://patchwork.ozlabs.org/api/1.1/series/499206/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499206","date":"2026-04-08T09:14:59","name":"qemu-keymap: fix altgr modifier lookup for newer xkeyboard-config","version":1,"mbox":"http://patchwork.ozlabs.org/series/499206/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221207/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221207/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYV56BN3z1xv0\n\tfor ; Thu, 09 Apr 2026 05:46:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYV4-0002Xs-81; Wed, 08 Apr 2026 15:23:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAY4y-0006ek-OX; Wed, 08 Apr 2026 14:56:44 -0400","from [94.136.29.99] (helo=zilli.proxmox.com)\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from )\n id 1wAPBA-0000Lv-AV; Wed, 08 Apr 2026 05:26:34 -0400","by zilli.proxmox.com (Postfix, from userid 1000)\n id DCFF21C31BA; Wed, 08 Apr 2026 11:15:05 +0200 (CEST)"],"From":"Dietmar Maurer ","To":"qemu-devel@nongnu.org","Cc":"qemu-trivial@nongnu.org,\n\tDietmar Maurer ","Subject":"[PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","Date":"Wed, 8 Apr 2026 11:14:59 +0200","Message-ID":"<20260408091459.4001711-1-dietmar@proxmox.com>","X-Mailer":"git-send-email 2.47.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Host-Lookup-Failed":"Reverse DNS lookup failed for 94.136.29.99 (failed)","Received-SPF":"none client-ip=94.136.29.99;\n envelope-from=dietmar@zilli.proxmox.com; helo=zilli.proxmox.com","X-Spam_score_int":"-10","X-Spam_score":"-1.1","X-Spam_bar":"-","X-Spam_report":"(-1.1 / 5.0 requ) BAYES_00=-1.9, NO_DNS_FOR_FROM=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n RDNS_NONE=0.793, SPF_HELO_NONE=0.001,\n SPF_NONE=0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"xkeyboard-config 2.37 removed the \"AltGr\" virtual modifier in favor\nof mapping upper groups directly to Mod5. Since then,\nxkb_keymap_mod_get_index(map, \"AltGr\") returns XKB_MOD_INVALID, so\nAltGr-based keysyms were never generated.\n\nSee: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/473f9bc32f9ba869829cc0d06a75cd1f2560aa60\n\nTry \"AltGr\" first, and fall back to \"Mod5\" for compatibility with\nboth old and new xkeyboard-config versions.\n\nSigned-off-by: Dietmar Maurer \n---\n qemu-keymap.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/qemu-keymap.c b/qemu-keymap.c\nindex 1c081db287..d4dccf456e 100644\n--- a/qemu-keymap.c\n+++ b/qemu-keymap.c\n@@ -230,6 +230,9 @@ int main(int argc, char *argv[])\n shift = get_mod(map, \"Shift\");\n ctrl = get_mod(map, \"Control\");\n altgr = get_mod(map, \"AltGr\");\n+ if (!altgr) {\n+ altgr = get_mod(map, \"Mod5\");\n+ }\n numlock = get_mod(map, \"NumLock\");\n \n state = xkb_state_new(map);\n","prefixes":[]}