{"id":2221165,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221165/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407212333.59260-1-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407212333.59260-1-philmd@linaro.org>","date":"2026-04-07T21:23:33","name":"[v10,19.5/21] linux-user/arm: Inline bswap_code()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"794dcddd3ae4dfff91fbf337d7d88a9c538b5c79","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407212333.59260-1-philmd@linaro.org/mbox/","series":[{"id":499198,"url":"http://patchwork.ozlabs.org/api/1.1/series/499198/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499198","date":"2026-04-07T21:23:33","name":null,"version":10,"mbox":"http://patchwork.ozlabs.org/series/499198/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221165/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221165/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=uUZc8UKM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYC90mJJz20wy\n\tfor ; Thu, 09 Apr 2026 05:33:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYcC-0005Lf-Bz; Wed, 08 Apr 2026 15:31:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAYA6-0000pr-54\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:02:02 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wADtZ-0006cc-KL\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:23:38 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so57012975e9.2\n for ; Tue, 07 Apr 2026 14:23:37 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488a8ddfde7sm460077915e9.5.2026.04.07.14.23.34\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Tue, 07 Apr 2026 14:23:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775597016; x=1776201816; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=52fny4xf/umuE1X09OYy8HjDidhbGmt3lpbRc93/+vg=;\n b=uUZc8UKMLtksu/hFr9hukCsrla4lhQOo024mEAL3j90/ap0xmdFHizQCWRGimymZbb\n RtMe4UqUr3TlK4K9QhU7S3gt60aJ3w3/gtA5uqJX9eZPUUKt4lOJCnkn2brneCJjqTQk\n wAdEOKVGzclkaks1QTSEwzG4BENnNZgUBqucOzHFgY+QBv3K3TgZF8nVxAOTSsK/+d92\n fnUB6MPGlPRFqTIGqqhL/ANxNFmA73XAp8Z7/g2rCudFTclCW1SzlEiCQ8R9o7/u6mmX\n +giAU1lUgSb8ZVTM8s9JeZSbz/WFtmwe1y/Pk3TzGW2NrR0fd7qd+v6tmGghcwnoxiWG\n SJjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775597016; x=1776201816;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=52fny4xf/umuE1X09OYy8HjDidhbGmt3lpbRc93/+vg=;\n b=dEWN8Rnsy3TrIIqmBrs58VZKL/Iz3Y4I58EGrONYJau8Q+XY5gVhBmpybIOQxkE8xv\n hv7dibHiLdNjGvwSjyS97rrMpDs134bF+aHzOKFAD1e8PzCU1Sm0l1DHBCbT0UDtkhbE\n KsNGUXPlrJmI1CmZfaarPEtx07w966nTqfKZCNDQIFkirNl4FfwAQwyWmP99SNFwvJXU\n 6mNb359KWRr70MT334dF4bWopMJBn9WDTNDmXAniSUofuLBn5uQPKZXgJrtMbMHM1Fwd\n mGFcdS5DwRMzFF7CrTwRTshxOD+NtbLQfLEvu2VMAoHIX9h5n7D8vlynsoovSwgSOV+Y\n jQtw==","X-Gm-Message-State":"AOJu0YzqMXGvWJJ4QvbVDdhYaUAS5AQEOnfy2pYQsNNfI7m9jzUL+x29\n Lkk8UMIZ4OBPpoRM8z93AnHXZfqg6f6zPbuFjs67hkIiRkDRcHG/4AWKTt3ohNnXf5vwDk5bmMD\n 8qHTniyI=","X-Gm-Gg":"AeBDieuwy1eFXpDGy9sFel6kdvrHe3NV3fcPjCsvJTd0EZZnFm/eEjkptCdwaIfd5Go\n Ym4Zn6obVmjZH0olUlQ69bO4R53PV4iU+ld0zxL5O9eSR1TxcpP5i09DJhIfZHAM8CTTsGUZ3NO\n qrpoja6fDw6PPsajDctvL/OXZG8fC1hJq7AfDHuggR+ft0v4ef5K+WqALq4loRkHDNhJZ2y2IGM\n dx+vxbIJrEKqq5v+fv6kLRHdADOzQ5Y8KO8uPi2NY79QtwClIgINvJ0R/D5SEDcLIkQjKHfYL9u\n woq0ttm1UvfEymf4MaTsiCf4tmTsX3cMVXMDtpCIhID73aS7dR5STFOvvCFe3hmU7OFK4pVsTRT\n 3ScXumaO77vjlAcF8VFpSbSODiO4TVaBHaBPMuvjr8rjvNw2NlcSaUotvN0twW+hJl64sK5D2y8\n cc06+ZJ8vFifbM6UKVQVcB9//ovPcjR/ru+L3MxKO2n6mi1FeyFp8zWvjVOGrSuxByoQQ0kngq","X-Received":"by 2002:a05:600c:a413:b0:485:6bcc:87dc with SMTP id\n 5b1f17b1804b1-488997b3a9amr195457605e9.14.1775597015603;\n Tue, 07 Apr 2026 14:23:35 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, Peter Maydell ,\n Laurent Vivier ,\n Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?=\n\t=?utf-8?q?Daud=C3=A9?= ","Subject":"[PATCH v10 19.5/21] linux-user/arm: Inline bswap_code()","Date":"Tue, 7 Apr 2026 23:23:33 +0200","Message-ID":"<20260407212333.59260-1-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"bswap_code() is now used once in get_user_code_u32(),\ninline it and simplify removing dead system code.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/arm/cpu.h | 16 ----------------\n linux-user/arm/cpu_loop.c | 10 ++++++++++\n 2 files changed, 10 insertions(+), 16 deletions(-)","diff":"diff --git a/target/arm/cpu.h b/target/arm/cpu.h\nindex 657ff4ab20b..917e9919e8c 100644\n--- a/target/arm/cpu.h\n+++ b/target/arm/cpu.h\n@@ -2568,22 +2568,6 @@ static inline int sme_vq(CPUARMState *env)\n return EX_TBFLAG_A64(env->hflags, SVL) + 1;\n }\n \n-static inline bool bswap_code(bool sctlr_b)\n-{\n-#ifdef CONFIG_USER_ONLY\n- /* BE8 (SCTLR.B = 0, TARGET_BIG_ENDIAN = 1) is mixed endian.\n- * The invalid combination SCTLR.B=1/CPSR.E=1/TARGET_BIG_ENDIAN=0\n- * would also end up as a mixed-endian mode with BE code, LE data.\n- */\n- return TARGET_BIG_ENDIAN ^ sctlr_b;\n-#else\n- /* All code access in ARM is little endian, and there are no loaders\n- * doing swaps that need to be reversed\n- */\n- return 0;\n-#endif\n-}\n-\n enum {\n QEMU_PSCI_CONDUIT_DISABLED = 0,\n QEMU_PSCI_CONDUIT_SMC = 1,\ndiff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c\nindex 19874f4c727..24a66b52cee 100644\n--- a/linux-user/arm/cpu_loop.c\n+++ b/linux-user/arm/cpu_loop.c\n@@ -29,6 +29,16 @@\n #include \"user/page-protection.h\"\n #include \"target/arm/syndrome.h\"\n \n+static inline bool bswap_code(bool sctlr_b)\n+{\n+ /*\n+ * BE8 (SCTLR.B = 0, TARGET_BIG_ENDIAN = 1) is mixed endian.\n+ * The invalid combination SCTLR.B=1/CPSR.E=1/TARGET_BIG_ENDIAN=0\n+ * would also end up as a mixed-endian mode with BE code, LE data.\n+ */\n+ return TARGET_BIG_ENDIAN ^ sctlr_b;\n+}\n+\n #define get_user_code_u32(x, gaddr, env) \\\n ({ abi_long __r = get_user_u32((x), (gaddr)); \\\n if (!__r && bswap_code(arm_sctlr_b(env))) { \\\n","prefixes":["v10","19.5/21"]}