{"id":2221121,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221121/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408010026.4611-7-matt@matthewpenney.net/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408010026.4611-7-matt@matthewpenney.net>","date":"2026-04-08T01:02:49","name":"[6/8] target/i386/kvm: use g_clear_handle_id() for GSource cleanup","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ab9927e449e03c424f72ebe37fa212e52f6f1e21","submitter":{"id":92789,"url":"http://patchwork.ozlabs.org/api/1.1/people/92789/?format=json","name":"Matthew Penney","email":"matt@matthewpenney.net"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408010026.4611-7-matt@matthewpenney.net/mbox/","series":[{"id":499175,"url":"http://patchwork.ozlabs.org/api/1.1/series/499175/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499175","date":"2026-04-08T01:02:28","name":"[1/8] hw/char: use g_clear_handle_id() for GSource cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/499175/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221121/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221121/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=matthewpenney.net header.i=@matthewpenney.net\n header.a=rsa-sha256 header.s=protonmail header.b=AYiwC0E8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXvC1GpDz1yD6\n\tfor ; Thu, 09 Apr 2026 05:19:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYKs-0004qU-8q; Wed, 08 Apr 2026 15:13:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAYJT-0008Qu-VY\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:11:44 -0400","from mail-4318.protonmail.ch ([185.70.43.18])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAHJq-0001P0-7w\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 21:02:59 -0400"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=matthewpenney.net;\n s=protonmail; t=1775610173; x=1775869373;\n bh=H3u1e6oqrvjOVue/AzgRE2wOemZMtQFe4II1WfBXrww=;\n h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n b=AYiwC0E8Ua31xK/RfacfzYUctL3QqJvOXd+KF23ebGWEBmA0K1+CPvkQb6BDxdMGS\n pjiHyuoDqYfcLRmh2h/yWAzAl4EFEO6ebpGqIdNw+EjCI5fwRRwnWm+79G8y1Rkc5S\n bXvXgsDQsWhtMYCJXy+6rjPY0LtNmYu2SoMiStzpOgf28r3J8TpCctquO8YBdKyHVZ\n Z4X4bK+wO5aaW/f8hWYkOlCw+UCZVe4dMnCr8qN7tCL64Bt+ww/ByEtNl/dF1t4MVd\n EmXrbTgKlxCJvBseaQCK+K4YNNge1eiUEMXbuniyr9XaEzgGj5qhd23DG9VmVhi1hJ\n QnFWWxMCsjivg==","Date":"Wed, 08 Apr 2026 01:02:49 +0000","To":"qemu-devel@nongnu.org","From":"Matthew Penney ","Cc":"Matthew Penney ,\n Paolo Bonzini , mtosatti@redhat.com, kvm@vger.kernel.org","Subject":"[PATCH 6/8] target/i386/kvm: use g_clear_handle_id() for GSource\n cleanup","Message-ID":"<20260408010026.4611-7-matt@matthewpenney.net>","Feedback-ID":"185185778:user:proton","X-Pm-Message-ID":"02f22ade2439bebbfcb019f0bd7f951675313f34","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=185.70.43.18;\n envelope-from=matt@matthewpenney.net;\n helo=mail-4318.protonmail.ch","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Replace g_source_remove() and explicit watch id check with\ng_clear_handle_id().\n\nThis simplifies the code and ensures consistent handling of GSource IDs,\nsince g_clear_handle_id() checks for a non-zero ID before calling the\ncleanup function.\n\nNo functional change intended.\n\nSigned-off-by: Matthew Penney \n---\n target/i386/kvm/tdx-quote-generator.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/target/i386/kvm/tdx-quote-generator.c b/target/i386/kvm/tdx-quote-generator.c\nindex dee8334b27..ab10986efa 100644\n--- a/target/i386/kvm/tdx-quote-generator.c\n+++ b/target/i386/kvm/tdx-quote-generator.c\n@@ -75,9 +75,7 @@ static void tdx_generate_quote_cleanup(TdxGenerateQuoteTask *task)\n {\n timer_del(&task->timer);\n \n- if (task->watch) {\n- g_source_remove(task->watch);\n- }\n+ g_clear_handle_id(&task->watch, g_source_remove);\n qio_channel_close(QIO_CHANNEL(task->sioc), NULL);\n object_unref(OBJECT(task->sioc));\n \n","prefixes":["6/8"]}