{"id":2221049,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221049/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408024024.606222-1-zhaoguohan@kylinos.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408024024.606222-1-zhaoguohan@kylinos.cn>","date":"2026-04-08T02:40:24","name":"ui/input-linux: close evdev fd when qemu_set_blocking fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d50e9953ab5797fbe7e54d15b5e2bd28a34b07bc","submitter":{"id":92952,"url":"http://patchwork.ozlabs.org/api/1.1/people/92952/?format=json","name":"GuoHan Zhao","email":"zhaoguohan@kylinos.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408024024.606222-1-zhaoguohan@kylinos.cn/mbox/","series":[{"id":499180,"url":"http://patchwork.ozlabs.org/api/1.1/series/499180/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499180","date":"2026-04-08T02:40:24","name":"ui/input-linux: close evdev fd when qemu_set_blocking fails","version":1,"mbox":"http://patchwork.ozlabs.org/series/499180/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221049/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221049/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (unknown [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frWtS6BZxz1xy1\n\tfor ; Thu, 09 Apr 2026 04:34:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAXiX-000417-CX; Wed, 08 Apr 2026 14:33:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAXiU-0003sL-67\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:33:30 -0400","from mailgw.kylinos.cn ([124.126.103.232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAIr3-0001Op-MV\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 22:41:24 -0400","from localhost.localdomain [(116.128.244.171)] by mailgw.kylinos.cn\n (envelope-from )\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 526151136; Wed, 08 Apr 2026 10:41:04 +0800"],"X-UUID":["6332da1632f411f1aa26b74ffac11d73-20260408","6332da1632f411f1aa26b74ffac11d73-20260408"],"X-CID-O-RULE":"Release_Ham","X-CID-RULE":"EDM_GE969F26","X-CID-O-INFO":"VERSION:1.3.12, REQID:9a123e84-91a9-40e1-a4a1-3dfa735fc3e4,\n IP:15,\n URL:0,TC:0,Content:0,EDM:-20,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC\n TION:release,TS:-20","X-CID-INFO":"VERSION:1.3.12, REQID:9a123e84-91a9-40e1-a4a1-3dfa735fc3e4, IP:15,\n UR\n L:0,TC:0,Content:0,EDM:-20,RT:0,SF:-15,FILE:0,BULK:0,RULE:EDM_GE969F26,ACT\n ION:release,TS:-20","X-CID-META":"VersionHash:e7bac3a, CLOUDID:fe676f893e334d42bcaa6a352d991b70,\n BulkI\n D:260408104105X6V6V9AL,BulkQuantity:0,Recheck:0,SF:10|66|78|101|102|123|12\n 7|850|898,TC:nil,Content:0|15|50,EDM:1,IP:-2,URL:0,File:nil,RT:nil,Bulk:ni\n l,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE\n :0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR,TF_CID_SPAM_AEC","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","X-User":"zhaoguohan@kylinos.cn","From":"zhaoguohan@kylinos.cn","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Cc":"qemu-devel@nongnu.org","Subject":"[PATCH] ui/input-linux: close evdev fd when qemu_set_blocking fails","Date":"Wed, 8 Apr 2026 10:40:24 +0800","Message-ID":"<20260408024024.606222-1-zhaoguohan@kylinos.cn>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=124.126.103.232;\n envelope-from=zhaoguohan@kylinos.cn; helo=mailgw.kylinos.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: GuoHan Zhao \n\ninput_linux_complete() opens the evdev node before switching it to\nnon-blocking mode. If qemu_set_blocking() fails, the function returns\nwithout closing the file descriptor.\n\nThe finalize path only closes initialized devices, so this leaks the fd\non an error path.\n\nJump to err_close when qemu_set_blocking() fails so the descriptor is\nreleased before returning.\n\nFixes: c7b1172026a0 (\"ui: replace qemu_set_nonblock()\")\nSigned-off-by: GuoHan Zhao \n---\n ui/input-linux.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/ui/input-linux.c b/ui/input-linux.c\nindex c16726a3b799..74bc8511428a 100644\n--- a/ui/input-linux.c\n+++ b/ui/input-linux.c\n@@ -316,7 +316,7 @@ static void input_linux_complete(UserCreatable *uc, Error **errp)\n return;\n }\n if (!qemu_set_blocking(il->fd, false, errp)) {\n- return;\n+ goto err_close;\n }\n \n rc = ioctl(il->fd, EVIOCGVERSION, &ver);\n","prefixes":[]}