{"id":2221011,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221011/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260408170613.587902-9-aconole@redhat.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.1/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs"},"msgid":"<20260408170613.587902-9-aconole@redhat.com>","date":"2026-04-08T17:06:04","name":"[ovs-dev,RFC,08/12] conntrack: Add calls to ct-offload infrastructure.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aad953ffead7b6ad5efbea49946db9c91d14d1fd","submitter":{"id":67184,"url":"http://patchwork.ozlabs.org/api/1.1/people/67184/?format=json","name":"Aaron Conole","email":"aconole@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260408170613.587902-9-aconole@redhat.com/mbox/","series":[{"id":499163,"url":"http://patchwork.ozlabs.org/api/1.1/series/499163/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=499163","date":"2026-04-08T17:05:56","name":"ct-offload: Introduce a conntrack offload infrastructure.","version":1,"mbox":"http://patchwork.ozlabs.org/series/499163/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221011/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2221011/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZVaMZKFj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZVaMZKFj","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frTy55Ymcz1xv0\n\tfor ; Thu, 09 Apr 2026 03:07:09 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 50E2C41084;\n\tWed, 8 Apr 2026 17:07:08 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QWAMrFsPr6Xz; Wed, 8 Apr 2026 17:07:06 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 7C0964102C;\n\tWed, 8 Apr 2026 17:07:03 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 716B7C054A;\n\tWed, 8 Apr 2026 17:07:03 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 1388AC0908\n for ; Wed, 8 Apr 2026 17:07:01 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id C47FD41032\n for ; Wed, 8 Apr 2026 17:06:40 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id GFcnVIV4WXsi for ;\n Wed, 8 Apr 2026 17:06:39 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 44EBE4100E\n for ; Wed, 8 Apr 2026 17:06:39 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-RvYghVTCMA2EXiBhGSDRCg-1; Wed,\n 08 Apr 2026 13:06:34 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B825D19560A7; Wed, 8 Apr 2026 17:06:33 +0000 (UTC)","from RHTRH0061144.redhat.com (unknown [10.22.89.172])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0F3EC300019F; Wed, 8 Apr 2026 17:06:31 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7C0964102C","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 44EBE4100E"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=aconole@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 44EBE4100E","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775667998;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=expsvgU0zmJrqjHdwIzXa358pNB5bLBGD5z4Fn7Q1yA=;\n b=ZVaMZKFjV1SMzwPHMg6nhDE4ItvW+uU/RysI/5BtKHSsBGq7pR6B7SB88EYCyqKEDKau4g\n ujhqEZdFzkgaksqkXEXn2N+JiiB0JJPZ/hduVtAyU0uTETvWCzTcvYziQxC9zvqxbo2cac\n 6e8Zq76+7LpKEuTMnEIcaQEwZOUveUU=","X-MC-Unique":"RvYghVTCMA2EXiBhGSDRCg-1","X-Mimecast-MFC-AGG-ID":"RvYghVTCMA2EXiBhGSDRCg_1775667993","To":"dev@openvswitch.org","Date":"Wed, 8 Apr 2026 13:06:04 -0400","Message-ID":"<20260408170613.587902-9-aconole@redhat.com>","In-Reply-To":"<20260408170613.587902-1-aconole@redhat.com>","References":"<20260408170613.587902-1-aconole@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"4WHmA3RYRqJXF1sxgecI1GnuxsXh0LD6vUGV-YgnQ8E_1775667993","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [RFC 08/12] conntrack: Add calls to ct-offload\n infrastructure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Aaron Conole via dev ","Reply-To":"Aaron Conole ","Cc":"Eli Britstein , Florian Westphal ,\n Flavio Leitner ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"This connects the offload provider infrastructure with the\nvarious places in conntrack where connection status changes\ntake place.\n\nSigned-off-by: Aaron Conole \n---\n lib/conntrack.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++--\n 1 file changed, 76 insertions(+), 3 deletions(-)","diff":"diff --git a/lib/conntrack.c b/lib/conntrack.c\nindex eab65e48f2..9872d7af51 100644\n--- a/lib/conntrack.c\n+++ b/lib/conntrack.c\n@@ -27,6 +27,7 @@\n #include \"conntrack-tcp.h\"\n #include \"conntrack-tp.h\"\n #include \"coverage.h\"\n+#include \"ct-offload.h\"\n #include \"crc32c.h\"\n #include \"csum.h\"\n #include \"ct-dpif.h\"\n@@ -533,6 +534,13 @@ conn_clean(struct conntrack *ct, struct conn *conn)\n atomic_count_dec(&zl->czl.count);\n }\n \n+ struct ct_offload_ctx offload_ctx = {\n+ .conn = conn,\n+ .netdev_in = NULL,\n+ .input_port_id = ODPP_NONE,\n+ };\n+ ct_offload_conn_del(&offload_ctx);\n+\n ovsrcu_postpone(delete_conn, conn);\n atomic_count_dec(&ct->n_conn);\n }\n@@ -1396,6 +1404,31 @@ process_one(struct conntrack *ct, struct dp_packet *pkt,\n helper, alg_exp, ct_alg_ctl, tp_id);\n }\n ovs_mutex_unlock(&ct->ct_lock);\n+\n+ if (conn) {\n+ struct ct_offload_ctx offload_ctx = {\n+ .conn = conn,\n+ .netdev_in = NULL,\n+ .input_port_id = pkt->md.in_port.odp_port,\n+ };\n+ ct_offload_conn_add(&offload_ctx);\n+ }\n+ }\n+\n+ if (!create_new_conn && conn && ctx->reply &&\n+ (pkt->md.ct_state & CS_ESTABLISHED) &&\n+ ct_offload_conn_is_offloaded(conn) &&\n+ !ct_offload_conn_is_established(conn)) {\n+ /* Notify offload providers that the connection is established.\n+ * We use the reply bit to detect that the connection has\n+ * transitioned and give us the input port, which should be the\n+ * reverse direction port. */\n+ struct ct_offload_ctx offload_ctx = {\n+ .conn = conn,\n+ .netdev_in = NULL,\n+ .input_port_id = pkt->md.in_port.odp_port,\n+ };\n+ ct_offload_conn_established(&offload_ctx);\n }\n \n write_ct_md(pkt, zone, conn, &ctx->key, alg_exp);\n@@ -1541,19 +1574,59 @@ ct_sweep(struct conntrack *ct, struct rculist *list, long long now,\n size_t *cleaned_count)\n OVS_NO_THREAD_SAFETY_ANALYSIS\n {\n+ struct ct_offload_op_batch batch;\n+ struct ct_offload_op *op;\n+\n struct conn *conn;\n size_t cleaned = 0;\n size_t count = 0;\n \n+\n+ ct_offload_op_batch_init(&batch);\n+\n RCULIST_FOR_EACH (conn, node, list) {\n if (conn_expired(conn, now)) {\n- conn_clean(ct, conn);\n- cleaned++;\n+ if (!ct_offload_conn_is_offloaded(conn)) {\n+ conn_clean(ct, conn);\n+ cleaned++;\n+ } else {\n+ struct ct_offload_ctx offload_ctx = {\n+ .conn = conn,\n+ .netdev_in = NULL,\n+ .input_port_id = ODPP_NONE,\n+ };\n+\n+ ct_offload_op_batch_add(&batch, CT_OFFLOAD_OP_UPD,\n+ &offload_ctx);\n+ }\n }\n-\n count++;\n }\n \n+ /* Run the batch. */\n+ ct_offload_op_batch_submit(&batch);\n+\n+ CT_OFFLOAD_BATCH_OP_FOR_EACH (idx, op, &batch) {\n+ struct conn *c = CONST_CAST(struct conn *, op->ctx.conn);\n+\n+ if (op->error) {\n+ conn_clean(ct, c);\n+ cleaned++;\n+ } else {\n+ /* Extend expiration by one sweep interval from now so the\n+ * connection survives until the next pass. */\n+ long long new_exp = now + conntrack_get_sweep_interval(ct);\n+ long long cur;\n+\n+ atomic_read_relaxed(&c->expiration, &cur);\n+ if (new_exp > cur) {\n+ atomic_store_relaxed(&c->expiration, new_exp);\n+ }\n+ }\n+ }\n+\n+ ct_offload_op_batch_destroy(&batch);\n+\n if (cleaned_count) {\n *cleaned_count = cleaned;\n }\n","prefixes":["ovs-dev","RFC","08/12"]}