{"id":2221000,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2221000/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260408165426.4154722-1-christoph.muellner@vrull.eu/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260408165426.4154722-1-christoph.muellner@vrull.eu>","date":"2026-04-08T16:54:26","name":"RISC-V: Fix Zbkb single-bit IOR/XOR synthesis [PR124818]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b0ed3c22addbb782ad8c06ce4ec51f6ee3b7b407","submitter":{"id":84173,"url":"http://patchwork.ozlabs.org/api/1.1/people/84173/?format=json","name":"Christoph Müllner","email":"christoph.muellner@vrull.eu"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260408165426.4154722-1-christoph.muellner@vrull.eu/mbox/","series":[{"id":499161,"url":"http://patchwork.ozlabs.org/api/1.1/series/499161/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499161","date":"2026-04-08T16:54:26","name":"RISC-V: Fix Zbkb single-bit IOR/XOR synthesis [PR124818]","version":1,"mbox":"http://patchwork.ozlabs.org/series/499161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221000/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221000/checks/","tags":{},"headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=vrull.eu header.i=@vrull.eu header.a=rsa-sha256\n header.s=google header.b=mR/lxGfR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=vrull.eu header.i=@vrull.eu header.a=rsa-sha256\n header.s=google header.b=mR/lxGfR","sourceware.org;\n dmarc=none (p=none dis=none) header.from=vrull.eu","sourceware.org; spf=pass smtp.mailfrom=vrull.eu","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.46"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frTh527Glz1xv0\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 02:54:59 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id D1F7B4BA2E15\n\tfor <incoming@patchwork.ozlabs.org>; Wed,  8 Apr 2026 16:54:57 +0000 (GMT)","from mail-wm1-f46.google.com (mail-wm1-f46.google.com\n [209.85.128.46])\n by sourceware.org (Postfix) with ESMTPS id A81864BA2E09\n for <gcc-patches@gcc.gnu.org>; Wed,  8 Apr 2026 16:54:30 +0000 (GMT)","by mail-wm1-f46.google.com with SMTP id\n 5b1f17b1804b1-488ba840146so314585e9.1\n for <gcc-patches@gcc.gnu.org>; Wed, 08 Apr 2026 09:54:30 -0700 (PDT)","from antares.fritz.box (62-178-148-172.cable.dynamic.surfer.at.\n [62.178.148.172]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cd1d647fsm5397665e9.14.2026.04.08.09.54.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2026 09:54:28 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org D1F7B4BA2E15","OpenDKIM Filter v2.11.0 sourceware.org A81864BA2E09"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org A81864BA2E09","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org A81864BA2E09","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775667271; cv=none;\n b=PcgxXsI6qsYmta7w1SKEvV706ZoCcNcW3AEQth/z2MSBd03rdWO0JnMXlcrjaKp8iA3OgntxhXdpVboa815wQikM1TK7BytGksUe/AjKrWW+k1Bzhr+JaODDMYJTg2q5Q40dH5xhjoofx2kD0a5V7tc6tsL86X2LX91zQ8cw3mQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775667271; c=relaxed/simple;\n bh=LmC+tYEWcgISKmCEwq0Up2+2sqCqWTwyd+wB53gLTK4=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=vDNEIZfKRuLGlksq//5Syi+75whDel8hRUTlhAQu9Qu9/CJiQyyYBrKmJMyL9mN6unuyecObDlOpRTtycQyzwxjHhZ/dgQCnEKg4GGvwcXzKuwoDgTXCh4Qlx9XiIAVf1PqU1ix7CeNTh8p0mgEP7vuGXnpsheq2PUjJQMCe2CM=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=vrull.eu; s=google; t=1775667269; x=1776272069; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=HcAB/PeKijCOATbVAtQ60cTv7o2M+e8fYQp3SveSh9o=;\n b=mR/lxGfRmQ3v/DgQdT/VM0HK2WvldWHOuTxifFp1lbL4F2mYB9SVUjgxT4zgEewTtr\n JWNDPoov+9UAnOd2LTtg0/0rL+DKR9GphuuqBZvkkXTCkVo7Sz6AvGRBSfQLK1DLXPMl\n G3fDy3PNI/LW4nN++hsL/ByRBo+VzcWGigptgjuKLFZUmRKKsgm1hPdJNp96lUlH5MMY\n qhsaSDl9fibHk1aBh3elzQmTRF27nTcDAMPHUuSgIDcGCqifGWNwCiU76nJIgXqHAeaV\n jmObto9MhslGUtkWz+dkAhFz871ZunP/Ns9+AckPF8OLBXiS+DB0eko980ms3DpuP/q7\n F6KA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775667269; x=1776272069;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HcAB/PeKijCOATbVAtQ60cTv7o2M+e8fYQp3SveSh9o=;\n b=Okl2if0x5aTv5FKTw18qIaj6qJYbCo0ystRjQ1rhdEL3yl1oyDO8ykOIJqlUsCIMf1\n J7IOQVeBrifJvgIcS+zHsrM8kifKmGrOLbsOs1rI+uG6wSs+333elRQdUhuh7XZQ9z0G\n z+ptyHN9Wtrm8/+u+V3o/wi+s0IZbMMh7gNRkcSfrgONrInq/SS9Efn4HAShRT7ksXMl\n 5A9ciVlJUTalMJGVvU/psxUXQKrAjP0jULfPOLKlXnDdysUUPCytr/+xsgpsBhlIMaFP\n rpyVMyBDULV3IP7fL706hyh8kgcuCFMkKjqQHv5A4xwops6tmInxhhHdr6j0eCx+3lRg\n Pwww==","X-Gm-Message-State":"AOJu0Yxx0af8DwNeuvwBic82c8Q1Jxe8jUWP2/LVagQ4VCOzriVtMCQ9\n BXLAqNVn1yJRn16NYYIAPUI/yjnDbdTjeC+uJLx05V63l031CKgWmJHRnFdZQsjfvcPy8H2ubeM\n WN8dK","X-Gm-Gg":"AeBDietJRNfSZxeDrFCi82I/6HfLolH+K3s2VZKPlBk8j+sl6LobgbYhJFDTUIJjJga\n t22HsMO4Zt6vjo6v9jR2Tz6/ydZvzYjTCST8gjT4QfZkprDsGOhep3f+yG2iwamwtL+rcwk4XKR\n rq/Wi1cvlmSxyGNlTrYlgT1iAFgqiUocRVWIJsdiejGo1xvSlv2eA/1ttonJqM2QjLWEdBR+m61\n +mQ8P/pmWg+7ydqfSOvcFAVYE4bV90od2ZFJfIaOG93Uga+doeBWORRfm9zy2HuepdtjTV66VAH\n Ik61Nd9TNOgaIDoa+0uh/1+IhekPAGfF8v8N/gQMQn99gsh8xnS6FcIAHeDETpDu0w1BkxxF+UJ\n v6xjES+tOaZbXmEIt2cCp9xK1CIz41A8YkVi5eciSLRKKJveOJ1e4KdOkv5W049AtAd5KeFOnLQ\n 34M2aLX54o1/1hntAD9RLKtit3FNLRlME2zONNm2XU0ejc5LU82F6hMJYshAc4+ff/TjQkBKB5x\n QjWOMALO80t","X-Received":"by 2002:a05:600c:c0dc:b0:486:f4d2:eac6 with SMTP id\n 5b1f17b1804b1-488ccf71199mr6541025e9.13.1775667269224;\n Wed, 08 Apr 2026 09:54:29 -0700 (PDT)","From":"=?utf-8?q?Christoph_M=C3=BCllner?= <christoph.muellner@vrull.eu>","To":"gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@gmail.com>,\n Palmer Dabbelt <palmer@dabbelt.com>, Robin Dapp <rdapp.gcc@gmail.com>,\n Andrew Waterman <andrew@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>,\n Jeff Law <jlaw@ventanamicro.com>,\n Shreya Munnangi <smunnangi1@ventanamicro.com>","Cc":"=?utf-8?q?Christoph_M=C3=BCllner?= <christoph.muellner@vrull.eu>","Subject":"[PATCH] RISC-V: Fix Zbkb single-bit IOR/XOR synthesis [PR124818]","Date":"Wed,  8 Apr 2026 18:54:26 +0200","Message-ID":"<20260408165426.4154722-1-christoph.muellner@vrull.eu>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"Only Zbs provides the bseti/binvi support that can directly handle a\nlarge single-bit immediate in scalar IOR/XOR operations.  Zbkb alone\ndoes not, but synthesize_ior_xor treated Zbkb as sufficient and\nreturned false for such constants.\n\nOn RV32 with -march=rv32gc_zbkb this leaves an unmatchable\n(ior:SI reg (const_int 0x20000)) RTL insn, which later triggers an ICE\nin extract_insn during virtual register instantiation.\n\nRestrict the single-bit fast path to Zbs and add an RV32 Zbkb\nregression test for the reduced reproducer.\n\n\tPR target/124818\n\ngcc/ChangeLog:\n\n\t* config/riscv/riscv.cc (synthesize_ior_xor): Do not treat\n\tTARGET_ZBKB as sufficient for single-bit immediate IOR/XOR.\n\ngcc/testsuite/ChangeLog:\n\n\t* gcc.target/riscv/pr124818.c: New test.\n\nSigned-off-by: Christoph Müllner <christoph.muellner@vrull.eu>\n---\n gcc/config/riscv/riscv.cc                 | 2 +-\n gcc/testsuite/gcc.target/riscv/pr124818.c | 9 +++++++++\n 2 files changed, 10 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.target/riscv/pr124818.c","diff":"diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc\nindex a6106547757..b743d3533f2 100644\n--- a/gcc/config/riscv/riscv.cc\n+++ b/gcc/config/riscv/riscv.cc\n@@ -15919,7 +15919,7 @@ synthesize_ior_xor (rtx_code code, rtx operands[3])\n {\n   /* Trivial cases that don't need synthesis.  */\n   if (SMALL_OPERAND (INTVAL (operands[2]))\n-     || ((TARGET_ZBS || TARGET_ZBKB)\n+     || (TARGET_ZBS\n \t && single_bit_mask_operand (operands[2], word_mode)))\n     return false;\n \ndiff --git a/gcc/testsuite/gcc.target/riscv/pr124818.c b/gcc/testsuite/gcc.target/riscv/pr124818.c\nnew file mode 100644\nindex 00000000000..a629e8e96a2\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/riscv/pr124818.c\n@@ -0,0 +1,9 @@\n+/* { dg-do compile { target { riscv32*-*-* } } } */\n+/* { dg-options \"-O2 -march=rv32gc_zbkb -mabi=ilp32\" } */\n+\n+int\n+f (unsigned int *flags)\n+{\n+  *flags |= 0x20000U;\n+  return 1;\n+}\n","prefixes":[]}