{"id":2220985,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220985/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260408152354.77017-1-xry111@xry111.site/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260408152354.77017-1-xry111@xry111.site>","date":"2026-04-08T15:23:21","name":"ifcvt: reject use of ctrap post reload [PR 105192]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fca0afce98faf7ba33e588401227dd411e5e5ceb","submitter":{"id":84026,"url":"http://patchwork.ozlabs.org/api/1.1/people/84026/?format=json","name":"Xi Ruoyao","email":"xry111@xry111.site"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260408152354.77017-1-xry111@xry111.site/mbox/","series":[{"id":499155,"url":"http://patchwork.ozlabs.org/api/1.1/series/499155/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499155","date":"2026-04-08T15:23:21","name":"ifcvt: reject use of ctrap post reload [PR 105192]","version":1,"mbox":"http://patchwork.ozlabs.org/series/499155/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220985/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220985/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=xry111.site header.i=@xry111.site header.a=rsa-sha256\n header.s=default header.b=JaXHpcCe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=xry111.site header.i=@xry111.site header.a=rsa-sha256\n header.s=default header.b=JaXHpcCe","sourceware.org;\n dmarc=pass (p=reject dis=none) header.from=xry111.site","sourceware.org; spf=pass smtp.mailfrom=xry111.site","server2.sourceware.org;\n arc=none smtp.remote-ip=89.208.246.23"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frRh90PGKz1xy1\n\tfor ; Thu, 09 Apr 2026 01:24:55 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9C7614BA2E15\n\tfor ; Wed, 8 Apr 2026 15:24:53 +0000 (GMT)","from xry111.site (xry111.site [89.208.246.23])\n by sourceware.org (Postfix) with ESMTPS id 33F2B4BA2E16\n for ; Wed, 8 Apr 2026 15:24:24 +0000 (GMT)","from stargazer (unknown\n [IPv6:2408:824e:305:fbc1:1a03:70b5:436b:8e1a])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (Client did not present a certificate)\n (Authenticated sender: xry111@xry111.site)\n by xry111.site (Postfix) with ESMTPSA id 9A8CB65992;\n Wed, 8 Apr 2026 11:24:17 -0400 (EDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 9C7614BA2E15","OpenDKIM Filter v2.11.0 sourceware.org 33F2B4BA2E16"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 33F2B4BA2E16","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 33F2B4BA2E16","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775661864; cv=none;\n b=xPp5IL+0Ltx2Awe6LPh3dRRWCGg0vPgQdKSPjUHgt4LC7aJwZR5USVG1zYIozA9vReAZhTQ/CSA9tZVyMNvq3ZimV+d2VqTwC9iBl9dW9y8HknPxCR3k5U+uzDhaDa51U9WCQ2+R33TQ/kzYmjgMkgKaHLq/26VhZrNltHSt8DI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775661864; c=relaxed/simple;\n bh=GcD0YPkh6xZI6YecHautKO6q74YT2DONYWgL6CpKrkI=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=tFURp9AYiPqcFsPo1P3+Zuvit/sCXFHz9P8Xwml5Ub5O9hlxEWlrr1O5sR3yTzmzp4I2MKB/19CKtS6YF9pDqa6lF68DXeOu0OH73Tjs/lVbC7/ZGy0pfV9qqczNT8dl+Vuxl4T+sJGdwX1fOwG2Y6cZRnR7+hgsiT36bdcgx1Q=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=xry111.site;\n s=default; t=1775661862;\n bh=UGyrSAyAoglME+Ok8mR18y5tchZwxk6dZeNGdmXEFFU=;\n h=From:To:Cc:Subject:Date:From;\n b=JaXHpcCejCdZRDJn75FseVCMRmRY1rn+zaWHC0rPSYrIJtkXEKzAv30vUqNsbervN\n O/TiJgBv1wFH34IgFT0x5ZJnpDeLSVJ3PHKWlmLhvPQuo4fCiZtVY47HXHSaVzeN2Z\n wJrUmYarzaaVJYX3bLTIlegGt2iBD58GWFVk2f78=","From":"Xi Ruoyao ","To":"gcc-patches@gcc.gnu.org","Cc":"Andrew Pinski ,\n Mingcong Bai , Henry Chen ,\n Zixing Liu , Xi Ruoyao ","Subject":"[PATCH] ifcvt: reject use of ctrap post reload [PR 105192]","Date":"Wed, 8 Apr 2026 23:23:21 +0800","Message-ID":"<20260408152354.77017-1-xry111@xry111.site>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"The ctrap expanders of several targets can end up creating pseudos. And\nit would be really counter-intuitive to disallow a define_expand to\ngenerate pseudos. So don't invoke the expander post reload.\n\n\tPR target/105192\n\ngcc/\n\n\t* ifcvt.cc (find_if_header): Don't attempt to use ctrap expander\n\tafter reload.\n\ngcc/testsuite/\n\n\t* gcc.c-torture/compile/pr105192.c: New test.\n---\n\nBootstrapped and regtested on x86_64-linux-gnu and\nmips64el-linux-gnuabi64. Ok for trunk?\n\n gcc/ifcvt.cc | 2 +-\n gcc/testsuite/gcc.c-torture/compile/pr105192.c | 9 +++++++++\n 2 files changed, 10 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr105192.c","diff":"diff --git a/gcc/ifcvt.cc b/gcc/ifcvt.cc\nindex 7f5af2ca915..c151146c1b2 100644\n--- a/gcc/ifcvt.cc\n+++ b/gcc/ifcvt.cc\n@@ -5180,7 +5180,7 @@ find_if_header (basic_block test_bb, int pass)\n && cond_exec_find_if_block (&ce_info))\n goto success;\n \n- if (targetm.have_trap ()\n+ if (!reload_completed && targetm.have_trap ()\n && optab_handler (ctrap_optab, word_mode) != CODE_FOR_nothing\n && find_cond_trap (test_bb, then_edge, else_edge))\n goto success;\ndiff --git a/gcc/testsuite/gcc.c-torture/compile/pr105192.c b/gcc/testsuite/gcc.c-torture/compile/pr105192.c\nnew file mode 100644\nindex 00000000000..0cc61505218\n--- /dev/null\n+++ b/gcc/testsuite/gcc.c-torture/compile/pr105192.c\n@@ -0,0 +1,9 @@\n+/* { dg-additional-options \"-fno-if-conversion -fharden-compares\" } */\n+\n+int a, b;\n+\n+void\n+foo (void)\n+{\n+ b = a % 0 > 0;\n+}\n","prefixes":[]}