{"id":2220973,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220973/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408141429.2798589-1-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408141429.2798589-1-aleksandr.loktionov@intel.com>","date":"2026-04-08T14:14:29","name":"[iwl-next,v2] ice: call netif_keep_dst() once when entering switchdev mode","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"2c0937a98527bf8d7704d3442be60f966706cc8b","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/1.1/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408141429.2798589-1-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499148,"url":"http://patchwork.ozlabs.org/api/1.1/series/499148/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499148","date":"2026-04-08T14:14:29","name":"[iwl-next,v2] ice: call netif_keep_dst() once when entering switchdev mode","version":2,"mbox":"http://patchwork.ozlabs.org/series/499148/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220973/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220973/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=AYLtM6xC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frQ733KQnz1xy1\n\tfor ; Thu, 09 Apr 2026 00:14:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 10FDE40EE6;\n\tWed, 8 Apr 2026 14:14:37 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id oaE0kJReA6uC; Wed, 8 Apr 2026 14:14:34 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D2F6740ED1;\n\tWed, 8 Apr 2026 14:14:34 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id DD2E8237\n for ; Wed, 8 Apr 2026 14:14:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id CF1CC823AA\n for ; Wed, 8 Apr 2026 14:14:32 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Mi77yVDotPld for ;\n Wed, 8 Apr 2026 14:14:32 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 343A28235C\n for ; Wed, 8 Apr 2026 14:14:31 +0000 (UTC)","from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 07:14:31 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa008.fm.intel.com with ESMTP; 08 Apr 2026 07:14:30 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org D2F6740ED1","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 343A28235C"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775657674;\n\tbh=59JzdarhuqKN+Ltdli4ZQCYPcZP8imhj4kqdn/TLBmo=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=AYLtM6xCZicVqQrJFtCgsqVkQfvuj2w/tXgUm6rfq6SRS5QlaP7gAq01b3e+dYndN\n\t W/yVjEidTwW7hMDeRlk6iEoE4D4/Nv0t8tcfXgQUjrXE904ux9RzokHFjdMcWgcZQY\n\t /JZFZzv3ezKXazANwXi2ErkrVo2T+/+5215sSPB8cUfclMzUxH5ckdCepQO34XtG5l\n\t IpMKhuuMMBggZM7fO9Up6E7AnmqEpzNXqiI5wSwQS4mhsrvRDIXaUJkO/Uh/WLbV0X\n\t bazhbI3SX9IeO33I3lF6rgi7oFctpI8Ln7vFiTCe48R58TEmY3B1oCff82Cs4YEoBE\n\t hMLdmGM0Qoa2w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 343A28235C","X-CSE-ConnectionGUID":["mZG6noXYQmGInsCLPjNs6A==","nQZXeFGxTmqJm5Ko0JrjIA=="],"X-CSE-MsgGUID":["Z51zAp2FTr2cGMxf2DbRPQ==","hil73vjbRmufhZPqKUfXRQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11753\"; a=\"64187417\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"64187417\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"225721117\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org,\n\tMarcin Szycik ","Date":"Wed, 8 Apr 2026 16:14:29 +0200","Message-ID":"<20260408141429.2798589-1-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775657672; x=1807193672;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=sw3WqSkSk8vlNUrCc326Em40Cu7by960cERr0qqQGu4=;\n b=cqfCl5B7ggGwRrIGGHgd7sGW55IIIN5/PT4pmJYdM60XCq5RhfmcnuKl\n O9hXfKvZiInL1s5ArfyQh5GxBIy7L1yIbfHr8GHQY//eBv2xCeM3Bi2yx\n Zx0EWjs04iUkSnLTSGcgwI107vu0Z3Senh6cZlKUiAIv2uw3TOiQGqOLS\n ZyOojWmkI4w8vkmpDEFq/gSTJARHAoqd9KS5cl91hpXZMvXpjjpfjwRwA\n E0zTzon8uJvd4IlHKKwgv/8mmUxTIebZvbhna3PLVUYrGNtR2XhGgJd++\n c3x32u1t56ySkP8xe4JMCInpm/e2GahPoL4wahzDjwyVs8lakpUp+WmvI\n A==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=cqfCl5B7"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v2] ice: call netif_keep_dst()\n once when entering switchdev mode","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Marcin Szycik \n\nnetif_keep_dst() only needs to be called once for the uplink VSI, not\nonce for each port representor. Move it from ice_eswitch_setup_repr()\nto ice_eswitch_enable_switchdev().\n\nFixes: defd52455aee (\"ice: do Tx through PF netdev in slow-path\")\nSigned-off-by: Marcin Szycik \nSigned-off-by: Aleksandr Loktionov \n---\nv1 -> v2:\n - Verified Fixes: tag via bisect - defd52455aee introduced the redundant\n per-repr call to netif_keep_dst(uplink_vsi->netdev) by changing the\n target netdev to the uplink VSI inside the per-representor setup\n function. Before that commit, each call was on a distinct repr->netdev\n so no Fixes: predating it applies.\n\n drivers/net/ethernet/intel/ice/ice_eswitch.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c\nindex 2e4f096..c30e27b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_eswitch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n@@ -117,8 +117,6 @@ static int ice_eswitch_setup_repr(struct ice_pf *pf, struct ice_repr *repr)\n \tif (!repr->dst)\n \t\treturn -ENOMEM;\n \n-\tnetif_keep_dst(uplink_vsi->netdev);\n-\n \tdst = repr->dst;\n \tdst->u.port_info.port_id = vsi->vsi_num;\n \tdst->u.port_info.lower_dev = uplink_vsi->netdev;\n@@ -312,6 +310,8 @@ static int ice_eswitch_enable_switchdev(struct ice_pf *pf)\n \tif (ice_eswitch_br_offloads_init(pf))\n \t\tgoto err_br_offloads;\n \n+\tnetif_keep_dst(uplink_vsi->netdev);\n+\n \tpf->eswitch.is_running = true;\n \n \treturn 0;\n","prefixes":["iwl-next","v2"]}