{"id":2220962,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220962/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131216.2662245-6-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408131216.2662245-6-aleksandr.loktionov@intel.com>","date":"2026-04-08T13:12:13","name":"[iwl-next,v2,5/8] ixgbe: remove ixgbe_ping_all_vfs() from link state change handlers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"41277b9b2ab9e33b1f426fe5c867c54f6cac1dfe","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131216.2662245-6-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499140,"url":"http://patchwork.ozlabs.org/api/1.1/series/499140/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499140","date":"2026-04-08T13:12:08","name":"ixgbe: nits and improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/499140/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220962/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220962/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=NxQ4g3hy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frNlP6wB4z1xy1\n\tfor ; Wed, 08 Apr 2026 23:12:33 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 770AE40F2C;\n\tWed, 8 Apr 2026 13:12:29 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xKl4TDR8f_jG; Wed, 8 Apr 2026 13:12:28 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B6F5E40F1F;\n\tWed, 8 Apr 2026 13:12:28 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 4C90D2C7\n for ; Wed, 8 Apr 2026 13:12:27 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 3EF6D40F1F\n for ; Wed, 8 Apr 2026 13:12:27 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id EmUfROixAEHR for ;\n Wed, 8 Apr 2026 13:12:26 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 3335940ECD\n for ; Wed, 8 Apr 2026 13:12:26 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 06:12:26 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 08 Apr 2026 06:12:25 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org B6F5E40F1F","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3335940ECD"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775653948;\n\tbh=Tk98gFi1G4Cc60/OkMoHNdw7FjA9PdLmLGQkbABHMfU=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=NxQ4g3hyQQAOZQuSdzEehS0+eV00zigoPduX91uopCpj/YXwEtTFN7QKGc6u4i/Ph\n\t OZWM//EEc1nQU/WdJGt6bOyloJhdly+keQ8uv9FHXOJqmEixRbMCihCKY8IZoA/DOO\n\t lsxlcgM9Ibx3ZnO0j52uBHhNz8f2AA7PNZaevTPyKUmhZ0/num5TPeGH/EM4HLIOat\n\t X0mYly83mUs5f3kEukaF97dCrRMuRyFNokriVr4U3xMjV/Ttonw61FlSlZlb0O5jA9\n\t jZFGEy5Ap3DiHgTjxCnlpRz6fAfhbW0oKAd1AAVUheoEKhRUEadgDw34NMI+ls7U0Z\n\t oxzRxoeMoFFwA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3335940ECD","X-CSE-ConnectionGUID":["W6Xc9Un5SxqVAlfjHPeHsw==","+B6SeTRFSZyabaTTLmNT2g=="],"X-CSE-MsgGUID":["MgsjarmIQmOB5/HodFeOQA==","rX3SN5HwTG+tC10sUiu4Og=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11752\"; a=\"102087283\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"102087283\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"228715100\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Wed, 8 Apr 2026 15:12:13 +0200","Message-ID":"<20260408131216.2662245-6-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260408131216.2662245-1-aleksandr.loktionov@intel.com>","References":"<20260408131216.2662245-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775653946; x=1807189946;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Kqq495al0fixHxITQwzw8FJCfkmaTNXmJ8mDt7IdcGo=;\n b=OfQoJFkFzV+tvpr3sX1CUS3DTFB67Ys8v/aLlr2pvBBejcQsgFBtCtuq\n JCXLDqFVn9zGjbJHfxBqonYOSVcFSaX6rnhXNfrsky7ywvciqj2p2JVwr\n L2ARAilihZVHl6grG94Y6WSXCjgqP3U2pd0yDDuMaGMis0Obp3x4pAccn\n Qx4XKsj19VpvlWNCGfedZAt3b9CQp5zXdShOkPhKGE0r89lHZO9c+a25A\n I2p3rX5X/sgDREcQAZZyzJIYYHLxkGcfLi3SScYsJEkKxGK+t7NRTUNY6\n jPbU9mBQV/GVhEnrWFGSi+HefXUxjoYnb95RzURuEeqqMs3VBcKE9hWtw\n g==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=OfQoJFkF"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v2 5/8] ixgbe: remove\n ixgbe_ping_all_vfs() from link state change handlers","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"When multiple VFs are brought up simultaneously, a VF can receive a\nCTS (Clear To Send) mailbox message instead of the expected RESET |\n(N)ACK response, because the watchdog fires a gratuitous ping right as\nthe VF mailbox transaction is in progress.\n\nRemove the ixgbe_ping_all_vfs() call from both ixgbe_watchdog_link_is_up()\nand ixgbe_watchdog_link_is_down(). Both paths contain an identical call\nwith the same race window during VF initialization: link-state changes\n(up or down) can arrive while VFs are mid-initialization, and the\ngratuitous ping from either direction collides with the VF mailbox state\nmachine for the same reason.\n\nLink-state changes are already communicated to VFs through the normal\nmailbox protocol; these extra pings are redundant on both paths.\n\nSuggested-by: Sebastian Basierski \nSigned-off-by: Aleksandr Loktionov \n---\nv1 -> v2:\n - Extend fix to also remove ixgbe_ping_all_vfs() from\n ixgbe_watchdog_link_is_down(), which carries the same race window;\n justifies the asymmetry by eliminating it.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ------\n 1 file changed, 6 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 1885fe8..7c3d821 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8151,9 +8151,6 @@ static void ixgbe_watchdog_link_is_up(struct ixgbe_adapter *adapter)\n \n \t/* update the default user priority for VFs */\n \tixgbe_update_default_up(adapter);\n-\n-\t/* ping all the active vfs to let them know link has changed */\n-\tixgbe_ping_all_vfs(adapter);\n }\n \n /**\n@@ -8183,8 +8180,5 @@ static void ixgbe_watchdog_link_is_down(struct ixgbe_adapter *adapter)\n \te_info(drv, \"NIC Link is Down\\n\");\n \tnetif_carrier_off(netdev);\n-\n-\t/* ping all the active vfs to let them know link has changed */\n-\tixgbe_ping_all_vfs(adapter);\n }\n \n static bool ixgbe_ring_tx_pending(struct ixgbe_adapter *adapter)\n","prefixes":["iwl-next","v2","5/8"]}