{"id":2220956,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220956/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131154.2661818-6-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408131154.2661818-6-aleksandr.loktionov@intel.com>","date":"2026-04-08T13:11:53","name":"[iwl-net,v2,5/6] ixgbe: fix ITR value overflow in adaptive interrupt throttling","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c576a94ee95bd5b83d48d6a6e87e487d3ccc685b","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131154.2661818-6-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499139,"url":"http://patchwork.ozlabs.org/api/1.1/series/499139/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499139","date":"2026-04-08T13:11:48","name":"ixgbe: six bug fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/499139/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220956/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220956/checks/","tags":{},"headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=o5lwy3LQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frNl10qFNz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 23:12:13 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 3222040EB4;\n\tWed,  8 Apr 2026 13:12:08 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZWDZhGZCA5C7; Wed,  8 Apr 2026 13:12:06 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DCDD940EC4;\n\tWed,  8 Apr 2026 13:12:05 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id E7F222C7\n for <intel-wired-lan@lists.osuosl.org>; Wed,  8 Apr 2026 13:12:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id CDC4E608DA\n for <intel-wired-lan@lists.osuosl.org>; Wed,  8 Apr 2026 13:12:04 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1EXFW7swsyNK for <intel-wired-lan@lists.osuosl.org>;\n Wed,  8 Apr 2026 13:12:04 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E0CA8608A8\n for <intel-wired-lan@lists.osuosl.org>; Wed,  8 Apr 2026 13:12:03 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 06:12:04 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 08 Apr 2026 06:12:03 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org DCDD940EC4","OpenDKIM Filter v2.11.0 smtp3.osuosl.org E0CA8608A8"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775653925;\n\tbh=j+GPXuo5nok7Sl5I3M8zh0LuXNegmZ7u1Eio+6IiWeo=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=o5lwy3LQiueXusl2+Uf3aXLh+lmahE3bCvq/w+nHGb0JtSjTnd4GJVDA2NltrpsUR\n\t 1tEJR1JiicbOr2G0Fb0PowZ3ryIgjPVzr9RlfgJQZ84U12BAuIs6+6ZMn8x7jYC2nU\n\t 058zp14vpuiCI/MaHiB3RO0QLe88H9GM02CU6bmf8m0p/N6Mkk0uWej6QnuQ36ImrY\n\t asLXtt72fZUqWjNqFUhJwVpWzzCOugYm9lgLp9B9qgHvSc9CNhzsdSXRnjUEw/kjRk\n\t 5mo9d257kLFblUCMxuJlLWPJyjRcXUh83P7dEfMreJlBQs6+H4MtEQ7VUpvxw7yPye\n\t QayYpBs+7g5ng==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org E0CA8608A8","X-CSE-ConnectionGUID":["wgty392/Riu7kGS8/UOwZw==","Bql28W+bQUuK12k1FUl8pw=="],"X-CSE-MsgGUID":["dn4oHH4rQr+0xp+3G1WCig==","oDbuBW78SbCyMCnpNeUt9g=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11752\"; a=\"102087238\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"102087238\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"228714974\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Wed,  8 Apr 2026 15:11:53 +0200","Message-ID":"<20260408131154.2661818-6-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775653924; x=1807189924;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=yv/bdNXZH9c8rMWd2v5owZSXHg0dmXwqwGf4QRKCawI=;\n b=Y2YKczcqImJWSUPaAkL67YnZ5BlsLHT/G9Ov4dKS+wjEmUequo1MlXnI\n 1zJKjOHilsBivsA9Dy6Nqm6VFqMwcqdCi6HMeA9HZAhy+AsnRsIcUpA/W\n hv3WgI/xdWuSi65cIm22rzKBvn1YsaOuK2UExBVFAk3AhJzlFm3Vby/pb\n tc9SDJ6BOEKytPGIyg/v23KTb62UwzyeCNPOtvYGWUOV8hTofYzTB4dk/\n p8TCXMOMGbo28Cy4PJgsynrr7lMhANU0URtkmEZUWYv979ph9/PSU02qi\n fOdLWkuYIFR7xnsMrVMLept+fkxl5kcTgKp6axfaOE5+fry5A3r+/SOEr\n w==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Y2YKczcq"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v2 5/6] ixgbe: fix ITR value\n overflow in adaptive interrupt throttling","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"},"content":"ixgbe_update_itr() packs a mode flag (IXGBE_ITR_ADAPTIVE_LATENCY,\nbit 7) and a usecs delay (bits [6:0]) into an unsigned int, then\nstores the combined value in ring_container->itr which is declared as\nu8.  Values above 0xFF wrap on truncation, corrupting both the delay\nand the mode flag on the next readback.\n\nSeparate the mode bits from the usecs sub-field; clamp only the usecs\nportion to [0, IXGBE_ITR_ADAPTIVE_LATENCY - 1] (= 0x7F) using min_t()\nso overflow cannot bleed into bit 7.\n\nFixes: b4ded8327fea (\"ixgbe: Update adaptive ITR algorithm\")\nCc: stable@vger.kernel.org\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nv1 -> v2:\n - Add proper [N/M] numbering so patchwork tracks it as part of the set;\n   no code change.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 210c7b9..9f3ae21 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -2889,8 +2889,9 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,\n \t}\n \n clear_counts:\n-\t/* write back value */\n-\tring_container->itr = itr;\n+\tring_container->itr = (itr & IXGBE_ITR_ADAPTIVE_LATENCY) |\n+\t\tmin_t(unsigned int, itr & ~IXGBE_ITR_ADAPTIVE_LATENCY,\n+\t\t      IXGBE_ITR_ADAPTIVE_LATENCY - 1);\n \n \t/* next update should occur within next jiffy */\n \tring_container->next_update = next_update + 1;\n","prefixes":["iwl-net","v2","5/6"]}