{"id":2220954,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220954/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131154.2661818-5-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408131154.2661818-5-aleksandr.loktionov@intel.com>","date":"2026-04-08T13:11:52","name":"[iwl-net,v2,4/6] ixgbe: fix cls_u32 nexthdr path returning success when no entry installed","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c94bb66d093edeca1618ff0bfb024ffb34db1719","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131154.2661818-5-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499139,"url":"http://patchwork.ozlabs.org/api/1.1/series/499139/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499139","date":"2026-04-08T13:11:48","name":"ixgbe: six bug fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/499139/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220954/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220954/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=AqDrHs0P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frNky2Q5cz1xy1\n\tfor ; Wed, 08 Apr 2026 23:12:10 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E716E40EFD;\n\tWed, 8 Apr 2026 13:12:05 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jdMOdnH2Cap7; Wed, 8 Apr 2026 13:12:05 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 594BF40EB4;\n\tWed, 8 Apr 2026 13:12:05 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 8E3951F6\n for ; Wed, 8 Apr 2026 13:12:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 800FB608A8\n for ; Wed, 8 Apr 2026 13:12:03 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lLdsRNUGS9HP for ;\n Wed, 8 Apr 2026 13:12:02 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 86E26608DA\n for ; Wed, 8 Apr 2026 13:12:02 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 06:12:02 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 08 Apr 2026 06:12:02 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 594BF40EB4","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 86E26608DA"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775653925;\n\tbh=qYwlT+BL9YDD9Zp6WEUNhdEQNMJrSNnI9RY6v49ynHg=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=AqDrHs0PbuZ2eeIZd1y7UekAFDWA+lIxZK4mxdIMwtjjhxkYRzQ2hTj9n6pePx/TU\n\t 5dvCbsaUwyDXllmGiAhjkUgymDWveSSSiIg6gouhS+QMDWDCFz+i43ooM7qjolpMig\n\t hXPFzolH6wVHYxCT/+870xJq9WBLJD44eENnxO6EePyoo1Jx2cW+aeKQFhp/G3BZXW\n\t Aohw0VBv7yvdTuCC0Vjm9bNV0/+ONpi8xJHoLqcEG7Gp0CMLy5IlXVXbyYpNwAVe0A\n\t rlNti98c9IHRJbnJyllPxfT0NF4w3pnFr8jgKg8qydf/kMxEVarGn99inYpYOQh0Gr\n\t aqfOrWyC77lwA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 86E26608DA","X-CSE-ConnectionGUID":["YzA4C+z7RrSsgriiKhqX4g==","nX59O9kFTlGYWVPwcZAbHg=="],"X-CSE-MsgGUID":["9/dnY/o5SwuA3dxLOehTbA==","6hyiGce6S/ugd6MA8qRDbQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11752\"; a=\"102087235\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"102087235\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"228714962\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org,\n\tMarcin Szycik ","Date":"Wed, 8 Apr 2026 15:11:52 +0200","Message-ID":"<20260408131154.2661818-5-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775653922; x=1807189922;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=PpPMGQbAmgiuM9HIOll7uCflsYjGK5MLju7m2oo4jhc=;\n b=nbpj6gePcg7RqddBI1XVNvx++ota2NE0wJnMxB8gJHKqC2IFXQcTxiDe\n 28HRnd6nBtasFwxHjmUOEsYVDeInJc/Yh+LkddXhY3lDgIShYaNZp2AiE\n 1wMDKrtbMlyI0/YKUw183M+TzWhD8QqKYQ4eU+2YuZlFOPYWZh4yK+xSE\n 1TTGcp9Xd1sfldxLR+mwBiDnw5QoZCTYoTAUxbzVGdbLr2XS1EzfW4uJb\n pSID6yp4VFNvg5E+vx9FSuSIMvFbWk0g/tM0EsOqWAJsqcqTebu8UH+pn\n dkuIz2YBMfrWBHkDJZWjbmGeALIMf9Nsf4MV2aOeq2F8OfhKfYfgSDbYS\n w==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=nbpj6geP"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v2 4/6] ixgbe: fix cls_u32 nexthdr\n path returning success when no entry installed","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ixgbe_configure_clsu32() returns 0 (success) after the nexthdr loop\neven when ixgbe_clsu32_build_input() fails for every candidate entry\nand no jump-table slot is actually programmed. Callers that test the\nreturn value would then falsely believe the filter was installed.\n\nThe variable 'err' already tracks the last ixgbe_clsu32_build_input()\nreturn value; if the loop completes with a successful break, err is 0.\nIf all attempts failed, err holds the last failure code. Change the\nunconditional 'return 0' to 'return err' so errors are propagated\ncorrectly.\n\nFixes: 1cdaaf5405ba (\"ixgbe: Match on multiple headers for cls_u32 offloads\")\nSigned-off-by: Aleksandr Loktionov \nCc: stable@vger.kernel.org\nReviewed-by: Marcin Szycik \n---\nv1 -> v2:\n - Add Fixes: tag; reroute from iwl-next to iwl-net (false-success\n return is a user-visible correctness bug, not a cleanup).\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 210c7b9..6e7f8a9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -10311,7 +10311,7 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter,\n \t\t\t\tkfree(jump);\n \t\t\t}\n \t\t}\n-\t\treturn 0;\n+\t\treturn err;\n \t}\n \n \tinput = kzalloc_obj(*input);\n","prefixes":["iwl-net","v2","4/6"]}