{"id":2220952,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220952/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131154.2661818-4-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408131154.2661818-4-aleksandr.loktionov@intel.com>","date":"2026-04-08T13:11:51","name":"[iwl-net,v2,3/6] ixgbe: call ixgbe_setup_fc() before fc_enable() after NVM update","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9fe808e86a3c8ef6bb5aac33fa8240663f24b6a1","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131154.2661818-4-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499139,"url":"http://patchwork.ozlabs.org/api/1.1/series/499139/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499139","date":"2026-04-08T13:11:48","name":"ixgbe: six bug fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/499139/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220952/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220952/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=KYnQLz7Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frNkt149Lz1xy1\n\tfor ; Wed, 08 Apr 2026 23:12:06 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4315440EC6;\n\tWed, 8 Apr 2026 13:12:04 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HdR0x5q3T-MT; Wed, 8 Apr 2026 13:12:03 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 7E0AB40ECA;\n\tWed, 8 Apr 2026 13:12:03 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 22E981F6\n for ; Wed, 8 Apr 2026 13:12:02 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 08D97608DC\n for ; Wed, 8 Apr 2026 13:12:02 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZxkQP9abXoE8 for ;\n Wed, 8 Apr 2026 13:12:01 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 1A07260856\n for ; Wed, 8 Apr 2026 13:12:01 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 06:12:01 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 08 Apr 2026 06:12:00 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7E0AB40ECA","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1A07260856"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775653923;\n\tbh=Tvxn+58WP/lxdddYqw/gfryGzIxe0VNXkiQOm16wh0s=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=KYnQLz7ZJY68SN+CbQkEuLG6RMYj3nMMdBZFhqEBUY4fmGqJi1zfV3xwGS+g8+qCQ\n\t X4YAz/JsaRI7FIsp+jM96aiKc6ROxZ/w22res2LJgdHEyG/s7y82aXUyIOmcQ6Nk2u\n\t BwvVn4TKgcxRGiPGBH/XGvrPtVsNDMU5PLQFkx6plZhdSrwseLDZAlvJ279tX8nDor\n\t yZQuEnF9hpY7azMJOIser22mjTbxp0V4vpsUsDGsi2lRM1uXPDOecst1U0X+w8aiFQ\n\t dWkLLghp3WrR3b46Y2LJFds0O9P6KAAECC0/xikzqpJr7uiBPZNf+x3N4c8TYJ1q/h\n\t afYH4Xspn9XUg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1A07260856","X-CSE-ConnectionGUID":["woe3AjrsQW+Y4nWwE4Qieg==","PE5/I+TxTr6jA8UzHR0T5A=="],"X-CSE-MsgGUID":["pPZoIK4CRrKKLXEZgbxAxA==","1fLCnSvsQXiQYuldeXuDaw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11752\"; a=\"102087232\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"102087232\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"228714957\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Wed, 8 Apr 2026 15:11:51 +0200","Message-ID":"<20260408131154.2661818-4-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775653921; x=1807189921;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=yQAXDpgBHYrZWGNoOaXRbwm61fkcniHXP8DOyif6ekw=;\n b=lHjJ4RLwdqVFWMI0d4nX/fpjtLGIIZ9N8BEzfE55kZf3aatPBgqsiogU\n ij/P1ps02l/P7ApHXGrUhPXMR5fyLndgp5svRiTle3Egh+J67QPfbBJnq\n esqtoMQMTCNQNXhJJkNVnabpL1XMxzn8ynL751wMeviub84NvXIgSut1g\n 4OorICsq31LzJemJnWTXqpq59aQK0v9Hc+YhDLcBSP9Q7j35pKNTfv2ft\n zz8tjipT4xMPdR8LNFwgnfCKY0GLHQ0PgYsiqujfxe3+Iz0zNUKwboBDT\n vt9COB5vhGOafGJGRKsod/hkul6uLzcjXPzjjuhTCajVfM3yrqsiJbISc\n w==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=lHjJ4RLw"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v2 3/6] ixgbe: call\n ixgbe_setup_fc() before fc_enable() after NVM update","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"During an NVM update the PHY reset clears the Technology Ability Field\n(IEEE 802.3 clause 37 register 7.10) back to hardware defaults. When\nthe driver subsequently calls only hw->mac.ops.fc_enable() the SRRCTL\nregister is recalculated from stale autonegotiated capability bits,\nwhich the MDD (Malicious Driver Detect) logic treats as an invalid\nchange and halts traffic on the PF.\n\nFix by calling ixgbe_setup_fc() immediately before fc_enable() in\nixgbe_watchdog_update_link() so that flow-control autoneg and the PHY\nregisters are re-programmed in the correct order after any reset.\n\nHandle the failure path explicitly: if setup_fc() returns an error its\noutput is invalid and calling fc_enable() on the unchanged hardware\nstate would repeat the exact MDD-triggering condition the fix is meant\nto prevent. Skip fc_enable() in that case while still calling\nixgbe_set_rx_drop_en() which configures the independent RX-drop\nbehaviour.\n\nFixes: 93c52dd0033b (\"ixgbe: Merge watchdog functionality into service task\")\nSuggested-by: Radoslaw Tyl \nCc: stable@vger.kernel.org\nSigned-off-by: Aleksandr Loktionov \n---\nv1 -> v2:\n - Add Fixes: tag; reroute to iwl-net; handle setup_fc() failure by\n skipping fc_enable() so stale FC state is never committed to hardware.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 210c7b9..fc3bae9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8029,6 +8029,13 @@ static void ixgbe_watchdog_update_link(struct ixgbe_adapter *adapter)\n \t\tpfc_en |= !!(adapter->ixgbe_ieee_pfc->pfc_en);\n \n \tif (link_up && !((adapter->flags & IXGBE_FLAG_DCB_ENABLED) && pfc_en)) {\n-\t\thw->mac.ops.fc_enable(hw);\n+\t\t/* Re-program flow-control autoneg before applying the result.\n+\t\t * If setup_fc() fails its output is invalid; skip fc_enable()\n+\t\t * to avoid committing stale capability bits that trigger MDD.\n+\t\t */\n+\t\tif (hw->mac.ops.setup_fc && hw->mac.ops.setup_fc(hw))\n+\t\t\te_warn(drv, \"setup_fc failed, skipping fc_enable\\n\");\n+\t\telse\n+\t\t\thw->mac.ops.fc_enable(hw);\n \t\tixgbe_set_rx_drop_en(adapter);\n \t}\n","prefixes":["iwl-net","v2","3/6"]}