{"id":2220923,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220923/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260408115922.48676-3-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260408115922.48676-3-pablo@netfilter.org>","date":"2026-04-08T11:59:19","name":"[nft,2/5] libnftables: add nft_run_cmd_release() helper and use it","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8ec57ba11354eeb7071ed0d081963b56ddc87479","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260408115922.48676-3-pablo@netfilter.org/mbox/","series":[{"id":499127,"url":"http://patchwork.ozlabs.org/api/1.1/series/499127/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499127","date":"2026-04-08T11:59:18","name":"support for several list and reset commands","version":1,"mbox":"http://patchwork.ozlabs.org/series/499127/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220923/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220923/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=jIGNd1J8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11726-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"jIGNd1J8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frMDS0NHnz1xv0\n\tfor ; Wed, 08 Apr 2026 22:04:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id AD567303BBF1\n\tfor ; Wed, 8 Apr 2026 11:59:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D03D63BB9F4;\n\tWed, 8 Apr 2026 11:59:33 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E570364EB2\n\tfor ; Wed, 8 Apr 2026 11:59:32 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id 968406033C;\n\tWed, 8 Apr 2026 13:59:30 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775649573; cv=none;\n b=PAhyTn8KEpnwbHW1ce7bZBZSTNct/eYksFxvXHmr8dmA+pbeJ0ZUefWeKFtFzYyEgc/E61kE+GO66egFHXcclLNq/rcAySiX2zkTS5Z2aylhHeRiJnHBiPlU6g+HQvbYOVeYRzszEfVo5C8Vz34nUwkv2khcBcBlo+gvFTKszYM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775649573; c=relaxed/simple;\n\tbh=x1fDM4WQ9j9LVEYvAYRygbdBu7tprFslEWWrJIrA0GE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=jdJ+khooT8rgwqWHX3RfoiZIaqNbAti7SvH3M6RclK0yXMsoXV2rjw/xmWUk2YSA7QgcLSqpAMRE3rhf40XenbzCQLv5FvR9IeIi/ae3jllkhnR19pXjZ1WYPaTN9rJxh8aKmfyDlkVtyHIMg7jcX0UfO2Ur/QKRFgxrwbwSQVU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=jIGNd1J8; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1775649570;\n\tbh=3BVTQz6obgyvalWWOXJPDxYjm1n5yX+bVTf6wsh1QBc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jIGNd1J83vw6T6qLWqGpwCpUOWbbQxTBuX1bZ//4P2p6wb8MvYEqCUrZMbjp8tLMK\n\t /2niy6+Hp5Cs8ivpltIf7ub+3HG4/RBlObQFSUjPP7BvE/NfK6kYcEmx6rgpQzACIq\n\t 5mqn2GAby7hI/oCLY6XvDMXvu3BWCr7eyrmSUECXEeOVkD4Zta4ntuTbIzXJtoQpLL\n\t m63QvSm1LRG0K8CB3zgx7q+7qvAF9xMzdVEBCRX7b+ZrizRgPdl+7R9UyQ4Q4essn1\n\t 3iR9IuKR8dalv3PnDWT6gaJ017TetExU+uUsERzl2jn3QBoMARHua8b4RbRtarug/t\n\t r8kYDWUUbq/jg==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"phil@nwl.cc,\n\tfw@strlen.de","Subject":"[PATCH nft 2/5] libnftables: add nft_run_cmd_release() helper and use\n it","Date":"Wed, 8 Apr 2026 13:59:19 +0200","Message-ID":"<20260408115922.48676-3-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260408115922.48676-1-pablo@netfilter.org>","References":"<20260408115922.48676-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Wrap the code to release the list of commands in a helper function, then\nuse it to consolidate codebase.\n\nSigned-off-by: Pablo Neira Ayuso \n---\n src/libnftables.c | 29 +++++++++++++++++------------\n 1 file changed, 17 insertions(+), 12 deletions(-)","diff":"diff --git a/src/libnftables.c b/src/libnftables.c\nindex e3218da9f48f..46d9c0df590b 100644\n--- a/src/libnftables.c\n+++ b/src/libnftables.c\n@@ -605,11 +605,23 @@ static int nft_evaluate(struct nft_ctx *nft, struct list_head *msgs,\n \treturn 0;\n }\n \n+static void nft_run_cmd_release(struct nft_ctx *nft,\n+\t\t\t\tstruct list_head *msgs,\n+\t\t\t\tstruct list_head *cmds)\n+{\n+\tstruct cmd *cmd, *next;\n+\n+\terec_print_list(&nft->output, msgs, nft->debug_mask);\n+\tlist_for_each_entry_safe(cmd, next, cmds, list) {\n+\t\tlist_del(&cmd->list);\n+\t\tcmd_free(cmd);\n+\t}\n+}\n+\n EXPORT_SYMBOL(nft_run_cmd_from_buffer);\n int nft_run_cmd_from_buffer(struct nft_ctx *nft, const char *buf)\n {\n \tint rc = -EINVAL, parser_rc;\n-\tstruct cmd *cmd, *next;\n \tLIST_HEAD(msgs);\n \tLIST_HEAD(cmds);\n \tchar *nlbuf;\n@@ -646,11 +658,8 @@ int nft_run_cmd_from_buffer(struct nft_ctx *nft, const char *buf)\n \tif (nft_netlink(nft, &cmds, &msgs) != 0)\n \t\trc = -1;\n err:\n-\terec_print_list(&nft->output, &msgs, nft->debug_mask);\n-\tlist_for_each_entry_safe(cmd, next, &cmds, list) {\n-\t\tlist_del(&cmd->list);\n-\t\tcmd_free(cmd);\n-\t}\n+\tnft_run_cmd_release(nft, &msgs, &cmds);\n+\n \tiface_cache_release();\n \tif (nft->scanner) {\n \t\tscanner_destroy(nft);\n@@ -739,7 +748,6 @@ static struct error_record *filename_is_useable(struct nft_ctx *nft, const char\n static int __nft_run_cmd_from_filename(struct nft_ctx *nft, const char *filename)\n {\n \tstruct error_record *erec;\n-\tstruct cmd *cmd, *next;\n \tint rc, parser_rc;\n \tLIST_HEAD(msgs);\n \tLIST_HEAD(cmds);\n@@ -783,11 +791,8 @@ static int __nft_run_cmd_from_filename(struct nft_ctx *nft, const char *filename\n \tif (nft_netlink(nft, &cmds, &msgs) != 0)\n \t\trc = -1;\n err:\n-\terec_print_list(&nft->output, &msgs, nft->debug_mask);\n-\tlist_for_each_entry_safe(cmd, next, &cmds, list) {\n-\t\tlist_del(&cmd->list);\n-\t\tcmd_free(cmd);\n-\t}\n+\tnft_run_cmd_release(nft, &msgs, &cmds);\n+\n \tiface_cache_release();\n \tif (nft->scanner) {\n \t\tscanner_destroy(nft);\n","prefixes":["nft","2/5"]}