{"id":2220922,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220922/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/3ff4de80fce72914eff23a169c974786858517e1.1775648406.git.ritesh.list@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<3ff4de80fce72914eff23a169c974786858517e1.1775648406.git.ritesh.list@gmail.com>","date":"2026-04-08T12:01:40","name":"[RFC,v2,10/10] pseries/papr-hvpipe: Fix error handling in case of init routine fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"199340cc6dcc41124ff4f944b8e144d277e33f93","submitter":{"id":79126,"url":"http://patchwork.ozlabs.org/api/1.1/people/79126/?format=json","name":"Ritesh Harjani (IBM)","email":"ritesh.list@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/3ff4de80fce72914eff23a169c974786858517e1.1775648406.git.ritesh.list@gmail.com/mbox/","series":[{"id":499129,"url":"http://patchwork.ozlabs.org/api/1.1/series/499129/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499129","date":"2026-04-08T12:01:30","name":"pseries/papr-hvpipe: Fix deadlock, races and misc cleanups","version":2,"mbox":"http://patchwork.ozlabs.org/series/499129/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220922/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2220922/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=KfiDg+te;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19506-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::436\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=KfiDg+te;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::436; helo=mail-pf1-x436.google.com;\n envelope-from=ritesh.list@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frMCK2YNPz1xv0\n\tfor ; Wed, 08 Apr 2026 22:03:09 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4frMBj568Gz30FR;\n\tWed, 08 Apr 2026 22:02:37 +1000 (AEST)","from mail-pf1-x436.google.com (mail-pf1-x436.google.com\n [IPv6:2607:f8b0:4864:20::436])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4frMBh6qP1z2yks\n\tfor ; Wed, 08 Apr 2026 22:02:36 +1000 (AEST)","by mail-pf1-x436.google.com with SMTP id\n d2e1a72fcca58-82ce0a9b3f7so2614497b3a.0\n for ;\n Wed, 08 Apr 2026 05:02:36 -0700 (PDT)","from Mac.localdomain ([49.205.216.49])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9b3e169sm21209322b3a.18.2026.04.08.05.02.30\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 08 Apr 2026 05:02:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775649757;\n\tcv=none;\n b=dTDwJ3biuYdb5BRLW6QcqeS4E2yfkPPnmGR7fjdmwlvxAZsClnRiOVh95lu/z6YhNgVoxIjrY8hHpqRQfWodLeFxhI4GI0EfE5Ooy8fOCt5giham42Var3Uwx+nNy40WJIc+0NE2046PmTejw8FnyoBZ6XtFFy32YqGBftPLjg/YeikYUjT0Y+L/EKzCl0V+ZQ26dgJIKKDCt31WZKYXwsOXI6/NIBr++gIOsAVxsDqXErkeFcwAdjLz3u9mUsJTOAKC56M+8TmtFweB5XqFe8rZLdCfh3DrP+Ll3VtSxV4sIIkRaBfbLBGH4RdQArtZPZD3OKgOs8P7K9JiVxfv0g==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775649757; c=relaxed/relaxed;\n\tbh=HxF/5xyzxh7moQ/DzCaZduABbVHgNK2NM9rE5Y5cP+w=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=mEbfegJvE4WWHWZ9Gm8659fAJbYIF3K0+Oyz0pMTQswe2eiXEM6H+90HVLEoJyUX/Mi0v6mnqE505o+XPrYPcY/K/nVuTLJgkz/8azYi31uOnOSsHbaJtf7qvENS3FkmNWOuf6XFlPL5htas2r8Pp4GxlSKeZzR1eIKXhH6Rm+xEJBKiP+N3TS6UtWGfUHygTNIF3ig348guK9FzqQic+P4Evh6AapsTxkrQBHIrwiuqDYRqBj7wXu76y3pvfYpWdiP0mSfyXFlcKva4is9pglGOC9kJ1iBRtuoDUe3oCz7z6ijua0TUxH955Z8w+7TEPlBuxlPyxwyD8XRpPKpljA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=KfiDg+te; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::436; helo=mail-pf1-x436.google.com;\n envelope-from=ritesh.list@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775649754; x=1776254554;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HxF/5xyzxh7moQ/DzCaZduABbVHgNK2NM9rE5Y5cP+w=;\n b=KfiDg+tesd6WxK95pRwbFLCorVmvKrr+btHt4550DB+G9A9nfquPO9/j2nbIn8TBvI\n fF8kk8Tuagq4UqaaBh/BOruU8Glcyt3R6vI0InCuo/P70cw+G23C1XyUNyYikzcLwjAe\n b7eIye+Xl98JxSzDfjQi/0TXTu8MV216gpmeGAFwD1FbEFZP9yR84RRHKNnld8cByVTE\n kr3wtRPJ54/Z8oT67TlpQUvRX08gLADl+1jSsdcZffwRTh6VMEZWq/rM5W9W70/j8Aih\n dZAC03U88iZ8HhXDiDyXpP+HNQxg2P5M9w0VBSgAw5ZVMz2w7Drm8kilRmmJaTaCF+EC\n DNCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775649754; x=1776254554;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HxF/5xyzxh7moQ/DzCaZduABbVHgNK2NM9rE5Y5cP+w=;\n b=ZUZ4Mu33kwSeF4oMYzt+Q3yC8LIJ0G7Xfplt3YckTRZZ3Pk3gn2d0nl0PwjWAfgVKq\n ue0pFFkv2UUjwylTTw9aw+EoT+lRVoT0ZIrAWp5BbH7mMDOvaid0uT9fwwGUZbSp4nUy\n qUUbVIYfJ1LHRM1Cpkx6k+JfWrgbUIyM33zD8z44liUCHP1MYwkxLteqKvdA6tRHXbuN\n uuJXkt1zFNTaS6c+tMUUDpzZWlO8keuasCfoDo/qjRkXnncViSOfRrgzVCyIsd+aJMli\n BIS7ZE0aKB6YUNB4XehxlDqEPm01BNZMEV0A8q5HZaTNQRiMRItPd4TPZgntcSZkYl7n\n HifQ==","X-Gm-Message-State":"AOJu0YzH7ZGFLNGHLN7m26PsB6jXcJwUOc0R6s4asDagt6/Ze53kAp07\n\tYJXF8HltgeFEXB3+b7Racqidc7v7tD3HTHLOU7EleE1hYs3Vcv8niemncd+Aug==","X-Gm-Gg":"AeBDiesPbtL6PCVMeym04kNtyMXDFC3RD0ua0mrzewVC9BMTmqhdKSr6GnhcsgfBVQ3\n\tujEpCKE1O8KEDdYx2PtOLufIz7v397nLhc9fvyKZcCj0tjzgP9dqoM9WDomLBWiRMrGmg5vfz7N\n\tQ31/QpTZPM7MBHHq+GdO6kEye7s2KZpE9bEEcnYQqeD6MLOhOYk5OaB2MtzITbKHeNLw3/ogD+x\n\t3m/6fpsoio/kCIvWKDdZnVfiADC6dkC+hak3ko1LPBIBl1HO9IGXTbmxdidlAAo9ik65RGY8hkh\n\tIC8gTS4LuWgOw86gWukAUWmxTjEGFFlW0n1rsayxX05QcxPAya4/hg//LVKmKuNwKJfFVbDRSpX\n\t3oYI76Znp+h+8QQcBQCDwRfwDEoPaZof1K1xOg5NoFY1AsGV819lERyLL5lazx90z5mfGMhkOlM\n\tAVwQy6ocrPJ6mtfBDKsfWl5kd5pH2z2zr7g1SglShmZiDfxUvbACh/oMY=","X-Received":"by 2002:a05:6a00:3e12:b0:82c:7876:a03e with SMTP id\n d2e1a72fcca58-82d0da8f384mr20097042b3a.17.1775649754432;\n Wed, 08 Apr 2026 05:02:34 -0700 (PDT)","From":"\"Ritesh Harjani (IBM)\" ","To":"linuxppc-dev@lists.ozlabs.org,\n\tHaren Myneni ","Cc":"Madhavan Srinivasan ,\n\tChristophe Leroy ,\n\tVenkat Rao Bagalkote ,\n\tNicholas Piggin ,\n\tlinux-kernel@vger.kernel.org,\n\t\"Ritesh Harjani (IBM)\" ","Subject":"[RFC v2 10/10] pseries/papr-hvpipe: Fix error handling in case of\n init routine fails","Date":"Wed, 8 Apr 2026 17:31:40 +0530","Message-ID":"\n <3ff4de80fce72914eff23a169c974786858517e1.1775648406.git.ritesh.list@gmail.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"","References":"","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"We have already enabled interrupt sources and enabled hvpipe to received\ninterrupts, if misc_register() fails, we will destroy the workqueue, but\nthe HMC might send us a msg via hvpipe which will call, queue work on\nthe workqueue which might be destroyed.\n\nSo instead, let's reverse the order of enabling set_hvpipe_sys_param(1)\nand in case of an error let's remove the misc dev by calling\nmisc_deregister().\n\nSigned-off-by: Ritesh Harjani (IBM) \n---\n arch/powerpc/platforms/pseries/papr-hvpipe.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)\n\n--\n2.39.5","diff":"diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/platforms/pseries/papr-hvpipe.c\nindex c708869ca732..b6d0b36915c6 100644\n--- a/arch/powerpc/platforms/pseries/papr-hvpipe.c\n+++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c\n@@ -785,18 +785,20 @@ static int __init papr_hvpipe_init(void)\n \tif (ret)\n \t\tgoto out_wq;\n\n-\tret = set_hvpipe_sys_param(1);\n+\tret = misc_register(&papr_hvpipe_dev);\n \tif (ret)\n \t\tgoto out_wq;\n\n-\tret = misc_register(&papr_hvpipe_dev);\n+\tret = set_hvpipe_sys_param(1);\n \tif (ret)\n-\t\tgoto out_wq;\n+\t\tgoto out_misc;\n\n \tpr_info(\"hvpipe feature is enabled\\n\");\n \thvpipe_feature = true;\n \treturn 0;\n\n+out_misc:\n+\tmisc_deregister(&papr_hvpipe_dev);\n out_wq:\n \tdestroy_workqueue(papr_hvpipe_wq);\n out:\n","prefixes":["RFC","v2","10/10"]}