{"id":2220920,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220920/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/82eca9775d5c66104d7499aa877841cd89d5731d.1775648406.git.ritesh.list@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<82eca9775d5c66104d7499aa877841cd89d5731d.1775648406.git.ritesh.list@gmail.com>","date":"2026-04-08T12:01:38","name":"[RFC,v2,08/10] pseries/papr-hvpipe: Simplify error handling in papr_hvpipe_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2bdfcedc56c1c244109f53f4ab67354955b480f0","submitter":{"id":79126,"url":"http://patchwork.ozlabs.org/api/1.1/people/79126/?format=json","name":"Ritesh Harjani (IBM)","email":"ritesh.list@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/82eca9775d5c66104d7499aa877841cd89d5731d.1775648406.git.ritesh.list@gmail.com/mbox/","series":[{"id":499129,"url":"http://patchwork.ozlabs.org/api/1.1/series/499129/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499129","date":"2026-04-08T12:01:30","name":"pseries/papr-hvpipe: Fix deadlock, races and misc cleanups","version":2,"mbox":"http://patchwork.ozlabs.org/series/499129/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220920/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220920/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Ke0/EKhv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19504-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::42d\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Ke0/EKhv;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::42d; helo=mail-pf1-x42d.google.com;\n envelope-from=ritesh.list@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frMC2267lz1xv0\n\tfor ; Wed, 08 Apr 2026 22:02:54 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4frMBY0Mvyz303F;\n\tWed, 08 Apr 2026 22:02:29 +1000 (AEST)","from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n [IPv6:2607:f8b0:4864:20::42d])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4frMBX2Tmmz2yks\n\tfor ; Wed, 08 Apr 2026 22:02:28 +1000 (AEST)","by mail-pf1-x42d.google.com with SMTP id\n d2e1a72fcca58-82cf976ecacso2462533b3a.1\n for ;\n Wed, 08 Apr 2026 05:02:28 -0700 (PDT)","from Mac.localdomain ([49.205.216.49])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9b3e169sm21209322b3a.18.2026.04.08.05.02.22\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 08 Apr 2026 05:02:24 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775649748;\n\tcv=none;\n b=c6vMSAplekKfXdGlWPkssgy9sqqZUJOGfo6yonxkNdAfnvGMkLq2iFTw5dXK7CltI4hZcaguo9FaNuHBA7Rr/dAfnE/B5ZE+s2yW/dU2wC7Bt1CC9T4+OX6qNAwviDRz1Nq0xyiunlv712Cztw66NZVN9eyDa+UphEf7CJXgpIQENqzNudQkg1GDEXaE9ixkw0TYMkDcz7T2BH1Rio4z8es3z+HOKyxvA0f+gFYbqB5CFEhTNY0s2xd5qbMFw68EmzuyYU0o2xb9pZu+EXR3nQvNqXQ23Vqsp/eY8By6Drpkp9dGy0AqXeVVZkwDJwm6g1GmbAY56LSx2ykGDCvMFw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775649748; c=relaxed/relaxed;\n\tbh=LvwUSoCp81ob7OZ/uiYdZqYepJJ6XzLLo7Vd69vn/eY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=mgWfj+l4DIzQH6pSBDLy3uUIqsNIPgOHDiAlnF2DmdIBc/S6hlG4s+KYFrXVsFElETQIrDER4ExlBk5DOEKlO/M2hGrCQRnOEI8CP2mWg1f0LSkWIu2QlSuSipzRITJKleobPs7lREyuoS5RYMt1cxPVOiL0t92COd45L/RKLZFsixwIuPG3YzCHKgEbWzeoE/yBgxgB1tCCfVmT6+vXvsUDaforOQbYhsyN2dat2ot2GfThnTIdd6Gg3e02PqNj7nB7UGUM7ID36iBYR60j2G47Lq/2Sg9U6nfBKAuE4iTp4CR1aYWNQDTxRGirQ/ob7YATzrQTve0tzF9hokot7Q==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Ke0/EKhv; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::42d; helo=mail-pf1-x42d.google.com;\n envelope-from=ritesh.list@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775649746; x=1776254546;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LvwUSoCp81ob7OZ/uiYdZqYepJJ6XzLLo7Vd69vn/eY=;\n b=Ke0/EKhvzkn6PZUJ/GEYnyiQW4aHXVUuCmIM58vqCZT5OO/R2f2IZNR66Rt6IHeEBP\n Iw9KjIXojo/r2BWU8DAc2A/Fm6qMTPyFHnXwNAbN2ogfsnCAOeXWRrZPNvKwvSnUx9EI\n W68zQtZgOQer3o12cgxQSyWaE2aBJIIueSkiw3cUrAMGHauU80vdAOM5qTt16fXfUw4u\n SQHturyirRKzfiJ2LoX1piCuR4MPuVbEg2UOKWKkYmyYpKoAzdD6sSmlbnLBbpWjeYcQ\n 4BVSPAMwarDf9/FLF0J122Hpf/3WJSkDFhOLixy3knAO0NhrhPvkGsP6TkGPSeo1d8vO\n ntvg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775649746; x=1776254546;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LvwUSoCp81ob7OZ/uiYdZqYepJJ6XzLLo7Vd69vn/eY=;\n b=buxaazazAt+CYTT1ilsQKPIJz+WrHnXkdb4fIEAF2Popxo1Ra1NVAKDGuK/sxXUpqQ\n 8U9BqOEr/R01JO1JWdEuSHIXfnrhWdARSQvR6PEDmzCkG4bEm6rqS5DJp1a7veR7xsuz\n Z0gcIfRmgc/SrD8onVfA3/Ew4PJvdwqmsJypG8XAnm6+wzm2yY+2MtMOHsF68a1TGCTY\n MEFJi7hDl9RtmFxTiMtnD05JjqVlxhKWVIZDnixnNKO2wB1Zu2RX5rSHbf6pyuaEZytq\n R5e1K8KqQBc8eWoOxWPRukeCAd98ffto6HCTbJqbVQ34vLH2Iy7Mq+l7EwsLTAUZau/f\n K2Qw==","X-Gm-Message-State":"AOJu0Yz3bXtQUdOmUVkh4vrZQp6ANtTE+s4CG731e9BbJVUSo8NHUbRI\n\tiTMyT6Lqm4+Vmk1XrC5kPX9bT8zR5rojPbOwAnAU58HeRhAlo/wZ8WElYKmFwA==","X-Gm-Gg":"AeBDiese1tbzJWZ1nF+dINPQQD7Buzl3/jO93JoWKk678FMYqCoAtLobdlf/nbl62RJ\n\tt7egZGFv7qLUH2Tc5D1KmvPYj9ted8Aw8NpV+9jH0H3elqh7zcFLV+Olm6et1iobXP91PWgvYXz\n\tPJjYSTYf5MBF6nkFigI6IKn4xYd1SKG46vjJqcajHVyKaylxeeoLpCS8s+hRx2d+zVaCEBLtIsU\n\tCQqowAcRwnYFuYv1WpM+hWr2PRnK91jdsXX22DqJ2Xq4OfQFiCnNwX5CDoEFDq5LwDdn97LBmOY\n\tOG0NRiLHYaOunMUTwFGwa6+evc8iqdS/6QTJqSOXreCPBdRNcPWcuTzkamAaAP2SZ3eNMPDLmhc\n\tIuYVhcpfqV4R9hv90GxxsjO38+ApVEQoK3ZqB8kxuJ/b0+Ah3OyHsZXwoB8rbJprFRtbCgeOG6F\n\tdJsQVV+nm1URDzb9Kaciaouh6MGF+0Lw0J8GNbTyYWKZdC","X-Received":"by 2002:a05:6a00:6ca8:b0:82c:ae58:46ad with SMTP id\n d2e1a72fcca58-82d0dbc813emr20521123b3a.51.1775649745709;\n Wed, 08 Apr 2026 05:02:25 -0700 (PDT)","From":"\"Ritesh Harjani (IBM)\" ","To":"linuxppc-dev@lists.ozlabs.org,\n\tHaren Myneni ","Cc":"Madhavan Srinivasan ,\n\tChristophe Leroy ,\n\tVenkat Rao Bagalkote ,\n\tNicholas Piggin ,\n\tlinux-kernel@vger.kernel.org,\n\t\"Ritesh Harjani (IBM)\" ","Subject":"[RFC v2 08/10] pseries/papr-hvpipe: Simplify error handling in\n papr_hvpipe_init()","Date":"Wed, 8 Apr 2026 17:31:38 +0530","Message-ID":"\n <82eca9775d5c66104d7499aa877841cd89d5731d.1775648406.git.ritesh.list@gmail.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"","References":"","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Remove such 3 levels of nesting patterns to check success return values\nfrom function calls.\n\nret = enable_hvpipe_IRQ()\n if (!ret)\n\t ret = set_hvpipe_sys_param(1)\n\t if (!ret)\n\t\t ret = misc_register()\n\nInstead just bail out to \"out*:\" labels, in case of any error. This\nsimplifies the init flow.\n\nSigned-off-by: Ritesh Harjani (IBM) \n---\n arch/powerpc/platforms/pseries/papr-hvpipe.c | 26 +++++++++++---------\n 1 file changed, 15 insertions(+), 11 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/platforms/pseries/papr-hvpipe.c\nindex ac2c4b42b373..5d04d1fa4370 100644\n--- a/arch/powerpc/platforms/pseries/papr-hvpipe.c\n+++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c\n@@ -783,23 +783,27 @@ static int __init papr_hvpipe_init(void)\n \t}\n \n \tret = enable_hvpipe_IRQ();\n-\tif (!ret) {\n-\t\tret = set_hvpipe_sys_param(1);\n-\t\tif (!ret)\n-\t\t\tret = misc_register(&papr_hvpipe_dev);\n-\t}\n+\tif (ret)\n+\t\tgoto out_wq;\n \n-\tif (!ret) {\n-\t\tpr_info(\"hvpipe feature is enabled\\n\");\n-\t\thvpipe_feature = true;\n-\t\treturn 0;\n-\t}\n+\tret = set_hvpipe_sys_param(1);\n+\tif (ret)\n+\t\tgoto out_wq;\n \n-\tpr_err(\"hvpipe feature is not enabled %d\\n\", ret);\n+\tret = misc_register(&papr_hvpipe_dev);\n+\tif (ret)\n+\t\tgoto out_wq;\n+\n+\tpr_info(\"hvpipe feature is enabled\\n\");\n+\thvpipe_feature = true;\n+\treturn 0;\n+\n+out_wq:\n \tdestroy_workqueue(papr_hvpipe_wq);\n out:\n \tkfree(papr_hvpipe_work);\n \tpapr_hvpipe_work = NULL;\n+\tpr_err(\"hvpipe feature is not enabled %d\\n\", ret);\n \treturn ret;\n }\n machine_device_initcall(pseries, papr_hvpipe_init);\n","prefixes":["RFC","v2","08/10"]}