{"id":2220892,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220892/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/c70f2e9d8cbc4af419356ed022bc60a8c9cfc7d2.1775648513.git.pabeni@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2026-04-08T11:43:46","name":"[iwl-next,2/2] i40e: keep track of per queue gso counters.","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"21e27b39f52b7d4a1928db4283ad0ea379f19040","submitter":{"id":67312,"url":"http://patchwork.ozlabs.org/api/1.1/people/67312/?format=json","name":"Paolo Abeni","email":"pabeni@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/c70f2e9d8cbc4af419356ed022bc60a8c9cfc7d2.1775648513.git.pabeni@redhat.com/mbox/","series":[{"id":499122,"url":"http://patchwork.ozlabs.org/api/1.1/series/499122/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499122","date":"2026-04-08T11:43:44","name":"i40e: implement per-queue stats","version":1,"mbox":"http://patchwork.ozlabs.org/series/499122/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220892/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220892/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=1TaHsd6U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frLns4sNzz1yD3\n\tfor ; Wed, 08 Apr 2026 21:44:33 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 47F55822FF;\n\tWed, 8 Apr 2026 11:44:31 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bZBVMAHnYoUh; Wed, 8 Apr 2026 11:44:30 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 02A6382299;\n\tWed, 8 Apr 2026 11:44:30 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 3914E237\n for ; Wed, 8 Apr 2026 11:44:29 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 1F3FF82299\n for ; Wed, 8 Apr 2026 11:44:29 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id shFfMfFrV7fc for ;\n Wed, 8 Apr 2026 11:44:28 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 13D3082178\n for ; Wed, 8 Apr 2026 11:44:27 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-P6M8fJ2NMHqDWmenjB8qug-1; Wed,\n 08 Apr 2026 07:44:22 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 7812019560A1; Wed, 8 Apr 2026 11:44:20 +0000 (UTC)","from gerbillo.redhat.com (unknown [10.44.32.173])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 2A01E1800361; Wed, 8 Apr 2026 11:44:15 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 02A6382299","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 13D3082178"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775648670;\n\tbh=f7q0qRSRszARAN4LccnaXW/nt7S9HdGvFiuMTOZO9xM=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=1TaHsd6UHOHFC0GZVMJyYx8YGej4sfFohHW5KLH2uIQruVtqETFfZlQfSdLsRHL0D\n\t pIG95WR6/IIKPvyh6cZSBU8XMpz83vEv6LpukFUjXtZVy6IruXY6h6nTbF5rCG49dV\n\t m/BMxYsS2u/xJeK6/RZYmWt4RTuJbpsM/1kNqOMIlANYEABsQRNcbUJr/h4qYnVMfh\n\t x7zECs1YqcGJH+JT7v6HHLXk5SFvf0uc99ZB8401enmyw8hkWuwr/H3nJeJROgBCr3\n\t PsMEdIaq32h6yv0iG4l+1iRM20KrvscuaRvaL2g3+wvd8kFb4F3TBEdif1NRU5/Tvx\n\t itLG/3QAOGjZQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=pabeni@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 13D3082178","X-MC-Unique":"P6M8fJ2NMHqDWmenjB8qug-1","X-Mimecast-MFC-AGG-ID":"P6M8fJ2NMHqDWmenjB8qug_1775648660","From":"Paolo Abeni ","To":"intel-wired-lan@lists.osuosl.org","Cc":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Stanislav Fomichev , netdev@vger.kernel.org","Date":"Wed, 8 Apr 2026 13:43:46 +0200","Message-ID":"\n ","In-Reply-To":"","References":"","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-MFC-PROC-ID":"0g8ThZwiVH71QaZOa3G3qQB3h727bx_mnaCE5EcsP28_1775648660","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775648667;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=f7q0qRSRszARAN4LccnaXW/nt7S9HdGvFiuMTOZO9xM=;\n b=WJkTE3ek66i3ONE4Kfl8sWhx/9sPTa+BJhNQ6Ta6lkm6dRRrEKtNogyGbGDL42fv36RhwR\n xClfIy/C6FXxD+bnMHFK4Z+MQ23g1UywLAF5EejNiM4x1CUPluBG5dq8AIFw3OqpkWEa4D\n xM7xbbxk4Fiobqrn3Qc4oBwjoJ8Ip4A=","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp1.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=WJkTE3ek"],"Subject":"[Intel-wired-lan] [PATCH iwl-next 2/2] i40e: keep track of per\n queue gso counters.","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Track the number of GSO and wire packets transmitted and expose the\ncounters via the queue stats.\n\nSigned-off-by: Paolo Abeni \n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 ++\n drivers/net/ethernet/intel/i40e/i40e_main.c | 13 ++++++++++++-\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 +++++++-\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 2 ++\n drivers/net/ethernet/intel/i40e/i40e_txrx_common.h | 6 +++++-\n drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-\n 6 files changed, 29 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex fe642c464e9c..4a88c7d69f61 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -845,6 +845,8 @@ struct i40e_vsi {\n \tu64 tx_stopped_base;\n \tu64 tx_bytes;\n \tu64 tx_packets;\n+\tu64 tx_gso_packets;\n+\tu64 tx_gso_wire_packets;\n \tu64 rx_buf_failed;\n \tu64 rx_page_failed;\n \tu64 rx_page_reuse;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 0d0b3619ec56..7c2af738ccc5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11695,6 +11695,8 @@ static void i40e_vsi_aggregate_tx_counters(struct i40e_vsi *vsi,\n \n \tvsi->tx_bytes += tx_ring->stats.bytes;\n \tvsi->tx_packets += tx_ring->stats.packets;\n+\tvsi->tx_gso_packets += tx_ring->tx_stats.tx_gso_packets;\n+\tvsi->tx_gso_wire_packets += tx_ring->tx_stats.tx_gso_wire_packets;\n }\n \n static void i40e_vsi_aggregate_rx_counters(struct i40e_vsi *vsi,\n@@ -13684,6 +13686,8 @@ static void i40e_zero_tx_ring_stats(struct netdev_queue_stats_tx *tx)\n {\n \ttx->bytes = 0;\n \ttx->packets = 0;\n+\ttx->hw_gso_packets = 0;\n+\ttx->hw_gso_wire_packets = 0;\n \ttx->stop = 0;\n \ttx->wake = 0;\n \ttx->hw_drops = 0;\n@@ -13692,17 +13696,21 @@ static void i40e_zero_tx_ring_stats(struct netdev_queue_stats_tx *tx)\n static void i40e_add_tx_ring_stats(struct i40e_ring *tx_ring,\n \t\t\t\t struct netdev_queue_stats_tx *tx)\n {\n-\tu64 bytes, packets;\n+\tu64 bytes, packets, gso_packets, gso_wire_packets;\n \tunsigned int start;\n \n \tdo {\n \t\tstart = u64_stats_fetch_begin(&tx_ring->syncp);\n \t\tbytes = tx_ring->stats.bytes;\n \t\tpackets = tx_ring->stats.packets;\n+\t\tgso_packets = tx_ring->tx_stats.tx_gso_packets;\n+\t\tgso_wire_packets = tx_ring->tx_stats.tx_gso_wire_packets;\n \t} while (u64_stats_fetch_retry(&tx_ring->syncp, start));\n \n \ttx->bytes += bytes;\n \ttx->packets += packets;\n+\ttx->hw_gso_packets += gso_packets;\n+\ttx->hw_gso_wire_packets += gso_wire_packets;\n \n \ttx->stop += tx_ring->tx_stats.tx_stopped;\n \ttx->wake += tx_ring->tx_stats.restart_queue;\n@@ -13743,6 +13751,9 @@ static void i40e_get_base_stats(struct net_device *dev,\n \n \ttx->bytes = vsi->tx_bytes;\n \ttx->packets = vsi->tx_packets;\n+\ttx->hw_gso_packets = vsi->tx_gso_packets;\n+\ttx->hw_gso_wire_packets = vsi->tx_gso_wire_packets;\n+\n \ttx->wake = vsi->tx_restart_base;\n \ttx->stop = vsi->tx_stopped_base;\n \ttx->hw_drops = vsi->tx_busy_base;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 894f2d06d39d..ec61cc43ae39 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -928,6 +928,7 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \t\t\t struct i40e_ring *tx_ring, int napi_budget,\n \t\t\t unsigned int *tx_cleaned)\n {\n+\tunsigned int total_gso_packets = 0, total_gso_wire_packets = 0;\n \tint i = tx_ring->next_to_clean;\n \tstruct i40e_tx_buffer *tx_buf;\n \tstruct i40e_tx_desc *tx_head;\n@@ -959,6 +960,10 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \t\t/* update the statistics for this packet */\n \t\ttotal_bytes += tx_buf->bytecount;\n \t\ttotal_packets += tx_buf->gso_segs;\n+\t\tif (tx_buf->gso_segs > 1) {\n+\t\t\ttotal_gso_packets++;\n+\t\t\ttotal_gso_wire_packets += tx_buf->gso_segs;\n+\t\t}\n \n \t\t/* free the skb/XDP data */\n \t\tif (ring_is_xdp(tx_ring))\n@@ -1018,7 +1023,8 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \n \ti += tx_ring->count;\n \ttx_ring->next_to_clean = i;\n-\ti40e_update_tx_stats(tx_ring, total_packets, total_bytes);\n+\ti40e_update_tx_stats(tx_ring, total_packets, total_bytes,\n+\t\t\t total_gso_packets, total_gso_wire_packets);\n \ti40e_arm_wb(tx_ring, vsi, budget);\n \n \tif (ring_is_xdp(tx_ring))\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex 1e5fd63d47f4..15c608378467 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -295,6 +295,8 @@ struct i40e_tx_queue_stats {\n \tu64 tx_linearize;\n \tu64 tx_force_wb;\n \tu64 tx_stopped;\n+\tu64 tx_gso_packets;\n+\tu64 tx_gso_wire_packets;\n \tint prev_pkt_ctr;\n };\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx_common.h b/drivers/net/ethernet/intel/i40e/i40e_txrx_common.h\nindex e26807fd2123..24220594ff1a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx_common.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx_common.h\n@@ -45,11 +45,15 @@ static inline __le64 build_ctob(u32 td_cmd, u32 td_offset, unsigned int size,\n **/\n static inline void i40e_update_tx_stats(struct i40e_ring *tx_ring,\n \t\t\t\t\tunsigned int total_packets,\n-\t\t\t\t\tunsigned int total_bytes)\n+\t\t\t\t\tunsigned int total_bytes,\n+\t\t\t\t\tunsigned int total_gso,\n+\t\t\t\t\tunsigned int total_gso_wire)\n {\n \tu64_stats_update_begin(&tx_ring->syncp);\n \ttx_ring->stats.bytes += total_bytes;\n \ttx_ring->stats.packets += total_packets;\n+\ttx_ring->tx_stats.tx_gso_packets += total_gso;\n+\ttx_ring->tx_stats.tx_gso_wire_packets += total_gso_wire;\n \tu64_stats_update_end(&tx_ring->syncp);\n \ttx_ring->q_vector->tx.total_bytes += total_bytes;\n \ttx_ring->q_vector->tx.total_packets += total_packets;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\nindex 9f47388eaba5..c2a465416a33 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n@@ -599,7 +599,7 @@ static bool i40e_xmit_zc(struct i40e_ring *xdp_ring, unsigned int budget)\n \ti40e_set_rs_bit(xdp_ring);\n \ti40e_xdp_ring_update_tail(xdp_ring);\n \n-\ti40e_update_tx_stats(xdp_ring, nb_pkts, total_bytes);\n+\ti40e_update_tx_stats(xdp_ring, nb_pkts, total_bytes, 0, 0);\n \n \treturn nb_pkts < budget;\n }\n","prefixes":["iwl-next","2/2"]}