{"id":2220716,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407195922.196410-16-pierrick.bouvier@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407195922.196410-16-pierrick.bouvier@linaro.org>","date":"2026-04-07T19:59:16","name":"[v10,15/21] target/arm/tcg/translate.c: replace TCGv with TCGv_va","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"43d6db1b859699cffe62ed44fd7908c498652aa1","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/1.1/people/85798/?format=json","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407195922.196410-16-pierrick.bouvier@linaro.org/mbox/","series":[{"id":499034,"url":"http://patchwork.ozlabs.org/api/1.1/series/499034/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499034","date":"2026-04-07T19:59:01","name":"target/arm: single-binary","version":10,"mbox":"http://patchwork.ozlabs.org/series/499034/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220716/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220716/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=LU6vK0f4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxvR05n0z1xtJ\n\tfor ; Wed, 08 Apr 2026 06:02:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wACaV-0004Ff-Rj; Tue, 07 Apr 2026 15:59:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wACaS-0004AM-MJ\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 15:59:48 -0400","from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wACaQ-0007OR-6k\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 15:59:48 -0400","by mail-pj1-x1033.google.com with SMTP id\n 98e67ed59e1d1-35d9c7bf9a1so4848456a91.3\n for ; Tue, 07 Apr 2026 12:59:45 -0700 (PDT)","from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35e27c9855csm126911a91.3.2026.04.07.12.59.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 12:59:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775591985; x=1776196785; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=P49JgMXtfvI/QxKp8JO4alWiNFfw7eGmQBelecFaY5M=;\n b=LU6vK0f4o1vu9ouOCfr6DvbCucey7ReJsHdXqivcCai41Sck2rCMwgnkUC/jwHi5Z4\n fGGXYvYW6Mc8n2cgpD+HHRqshD/wLaXogR8UMozgIw0kFmam/0k/9+uCVYzWH80IBDBx\n hqTOUTEGnsZ5kXQC5xoXybLclzCQQru9bPr2mhcAi/Jcgae++uAW/ZysQtX5NC1nQ7HJ\n eGn4SVLKbehIj3wo2aq/dhekMEWt/Iqx8IFQiwEmQo9lPaoFSknHNuwLDYW+XiaBlz2c\n JQx/f5mOqErVYYxY5FhogxceakyQ2Yjg1qJMdmwyQ6vrJyBWbCpwrqkMJQ562JjH7n6C\n DQRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775591985; x=1776196785;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=P49JgMXtfvI/QxKp8JO4alWiNFfw7eGmQBelecFaY5M=;\n b=AKQ11PTuZqaD/HHNMvcu/qPwe16o61VSDwNHlFCo2XIYfrPSccpcUdFNwiHObEaIJ8\n TAX1KHBKCKJbmexGwScZ6QU/zEAimvkU4QIJAoCPY3Tk1OSZDCSe7oDBIADJ3L1jtqJe\n r/VnA4mv/jVkEu/gpV0SglO351+nLwU6PLiEnOz/u7qZyu1ZkuiA6V5jC5BAESQQsUE+\n 3ASUqn7ONH/EhQV2rjNuK7gTxKNF1GtnkSheQQS3kOy/WcGHH1FZxRHcu9yaMrlLGK8K\n xnJIY+uYo+5whMqTx8RL9qg9zyG7POjcer0dkVKkxHHVePIPWyu0kYOKc+6ZxTI1FOTn\n n+ZQ==","X-Gm-Message-State":"AOJu0YzOwrvdg/pN7arLzEbDx6koMPLP5BvgKK4/hgUlk9cKnLFWI/C8\n lKJ4S8+k2cmb41W++4Ps2cYAnzojF9pxmEsiYeoYiYX9wiHTZJ8tlJ0CRgQ6cn03bzTo1ot4XPp\n rMGSwJig=","X-Gm-Gg":"AeBDietxhtJSNyiq1gpmegqRxIDEJVt2R2ktPMzwQ1G2Yr2eY1pU6rSieRt1a+L5JmH\n 3o5cJG/lN3hcS2N9P10IUiRG0aG++q/EKV38t+3WbesWSZGh5zk3AjJhy6tnuNikowMK3EpHh/j\n HqkxBxaXv9umffnOrVMWBPCuxV+vQ9vXLl17ClmQl7SAcizfHV9GR2jyogtU800LYXDTHjUz77G\n DICO+/LQq8Nw8tQu9OMhssvhcZiPkKrbXgpCZs4EM40vIisDAJfDWtwyDy0Cz28TPAEMq+XvYBY\n KGB8gjhBFQV9vyYUB2WT3cDVLusjahltEy6BVr/+p2GTzW3IeXOG5uOk+MUHTTB4nZmOaFnla2b\n 1RDV1QmBGBKfP2/DNw4l2TD5KyjJEtsFrkOvBpnupbgyc3pRP+nuz9njkkCQr6kPJujQDLJLrpc\n YUVmPXjH/Bo5uUYZfJqSi+g+0ihA/XmBYS1oaBQ5uuB8jpwQJlJ7DPdEXrX46n4nwbbTmbzP+MB\n XUt","X-Received":"by 2002:a17:90b:4f43:b0:359:f3b1:6811 with SMTP id\n 98e67ed59e1d1-35de67db862mr16989873a91.1.1775591984669;\n Tue, 07 Apr 2026 12:59:44 -0700 (PDT)","From":"Pierrick Bouvier ","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell , jim.macarthur@linaro.org,\n Richard Henderson , philmd@linaro.org,\n Pierrick Bouvier , qemu-arm@nongnu.org,\n Paolo Bonzini ","Subject":"[PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","Date":"Tue, 7 Apr 2026 12:59:16 -0700","Message-ID":"<20260407195922.196410-16-pierrick.bouvier@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1033;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1033.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We know this file is for 32-bit runtime target, so we can set\nTCG_ADDRESS_BITS. TCG_TYPE_VA is derived accordingly and is already\npassed to translator_loop.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Pierrick Bouvier \n---\n target/arm/tcg/translate.c | 29 +++++++++++++++--------------\n 1 file changed, 15 insertions(+), 14 deletions(-)","diff":"diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\nindex fa4c7907dcd..0b3b4ab86be 100644\n--- a/target/arm/tcg/translate.c\n+++ b/target/arm/tcg/translate.c\n@@ -22,7 +22,8 @@\n \n #include \"translate.h\"\n #include \"translate-a32.h\"\n-#include \"tcg/tcg-op.h\"\n+#define TCG_ADDRESS_BITS 32\n+#include \"tcg/tcg-op-mem.h\"\n #include \"qemu/log.h\"\n #include \"arm_ldst.h\"\n #include \"semihosting/semihost.h\"\n@@ -910,14 +911,14 @@ MemOp pow2_align(unsigned i)\n * that the address argument is TCGv_i32 rather than TCGv.\n */\n \n-static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n+static TCGv_va gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n {\n- TCGv addr = tcg_temp_new();\n- tcg_gen_extu_i32_tl(addr, a32);\n+ TCGv_va addr = tcgv_va_temp_new();\n+ tcg_gen_mov_i32(addr, a32);\n \n /* Not needed for user-mode BE32, where we use MO_BE instead. */\n if (!IS_USER_ONLY && s->sctlr_b && (op & MO_SIZE) < MO_32) {\n- tcg_gen_xori_tl(addr, addr, 4 - (1 << (op & MO_SIZE)));\n+ tcg_gen_xori_i32(addr, addr, 4 - (1 << (op & MO_SIZE)));\n }\n return addr;\n }\n@@ -929,21 +930,21 @@ static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n void gen_aa32_ld_internal_i32(DisasContext *s, TCGv_i32 val,\n TCGv_i32 a32, int index, MemOp opc)\n {\n- TCGv addr = gen_aa32_addr(s, a32, opc);\n+ TCGv_va addr = gen_aa32_addr(s, a32, opc);\n tcg_gen_qemu_ld_i32(val, addr, index, opc);\n }\n \n void gen_aa32_st_internal_i32(DisasContext *s, TCGv_i32 val,\n TCGv_i32 a32, int index, MemOp opc)\n {\n- TCGv addr = gen_aa32_addr(s, a32, opc);\n+ TCGv_va addr = gen_aa32_addr(s, a32, opc);\n tcg_gen_qemu_st_i32(val, addr, index, opc);\n }\n \n void gen_aa32_ld_internal_i64(DisasContext *s, TCGv_i64 val,\n TCGv_i32 a32, int index, MemOp opc)\n {\n- TCGv addr = gen_aa32_addr(s, a32, opc);\n+ TCGv_va addr = gen_aa32_addr(s, a32, opc);\n \n tcg_gen_qemu_ld_i64(val, addr, index, opc);\n \n@@ -956,7 +957,7 @@ void gen_aa32_ld_internal_i64(DisasContext *s, TCGv_i64 val,\n void gen_aa32_st_internal_i64(DisasContext *s, TCGv_i64 val,\n TCGv_i32 a32, int index, MemOp opc)\n {\n- TCGv addr = gen_aa32_addr(s, a32, opc);\n+ TCGv_va addr = gen_aa32_addr(s, a32, opc);\n \n /* Not needed for user-mode BE32, where we use MO_BE instead. */\n if (!IS_USER_ONLY && s->sctlr_b && (opc & MO_SIZE) == MO_64) {\n@@ -2036,7 +2037,7 @@ static void gen_load_exclusive(DisasContext *s, int rt, int rt2,\n * architecturally 64-bit access, but instead do a 64-bit access\n * using MO_BE if appropriate and then split the two halves.\n */\n- TCGv taddr = gen_aa32_addr(s, addr, opc);\n+ TCGv_va taddr = gen_aa32_addr(s, addr, opc);\n \n tcg_gen_qemu_ld_i64(t64, taddr, get_mem_index(s), opc);\n tcg_gen_mov_i64(cpu_exclusive_val, t64);\n@@ -2065,7 +2066,7 @@ static void gen_store_exclusive(DisasContext *s, int rd, int rt, int rt2,\n {\n TCGv_i32 t0, t1, t2;\n TCGv_i64 extaddr;\n- TCGv taddr;\n+ TCGv_va taddr;\n TCGLabel *done_label;\n TCGLabel *fail_label;\n MemOp opc = size | MO_ALIGN | s->be_data;\n@@ -3792,7 +3793,7 @@ static void do_ldrd_load(DisasContext *s, TCGv_i32 addr, int rt, int rt2)\n */\n int mem_idx = get_mem_index(s);\n MemOp opc = MO_64 | MO_ALIGN_4 | MO_ATOM_SUBALIGN | s->be_data;\n- TCGv taddr = gen_aa32_addr(s, addr, opc);\n+ TCGv_va taddr = gen_aa32_addr(s, addr, opc);\n TCGv_i64 t64 = tcg_temp_new_i64();\n TCGv_i32 tmp = tcg_temp_new_i32();\n TCGv_i32 tmp2 = tcg_temp_new_i32();\n@@ -3847,7 +3848,7 @@ static void do_strd_store(DisasContext *s, TCGv_i32 addr, int rt, int rt2)\n */\n int mem_idx = get_mem_index(s);\n MemOp opc = MO_64 | MO_ALIGN_4 | MO_ATOM_SUBALIGN | s->be_data;\n- TCGv taddr = gen_aa32_addr(s, addr, opc);\n+ TCGv_va taddr = gen_aa32_addr(s, addr, opc);\n TCGv_i32 t1 = load_reg(s, rt);\n TCGv_i32 t2 = load_reg(s, rt2);\n TCGv_i64 t64 = tcg_temp_new_i64();\n@@ -4068,7 +4069,7 @@ DO_LDST(STRH, store, MO_UW)\n static bool op_swp(DisasContext *s, arg_SWP *a, MemOp opc)\n {\n TCGv_i32 addr, tmp;\n- TCGv taddr;\n+ TCGv_va taddr;\n \n opc |= s->be_data;\n addr = load_reg(s, a->rn);\n","prefixes":["v10","15/21"]}