{"id":2220695,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220695/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407043614.372871-6-alistair.francis@wdc.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407043614.372871-6-alistair.francis@wdc.com>","date":"2026-04-07T04:36:14","name":"[5/5] target/riscv: Use ELEN for Fractional LMUL check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e9a08c36f8d274d2b0e2bde3956d3928d8bd3926","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/1.1/people/64571/?format=json","name":"Alistair Francis","email":"alistair23@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407043614.372871-6-alistair.francis@wdc.com/mbox/","series":[{"id":499030,"url":"http://patchwork.ozlabs.org/api/1.1/series/499030/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499030","date":"2026-04-07T04:36:12","name":"target/riscv: A collection of bug fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499030/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220695/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220695/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=i/acd2kn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxKB6cYSz1yGM\n\tfor ; Wed, 08 Apr 2026 05:36:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wABXd-0000Hm-3Y; Tue, 07 Apr 2026 14:52:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wABUK-0003xC-5U\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:49:24 -0400","from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w9yDY-0007J1-Mc\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 00:39:14 -0400","by mail-pg1-x52f.google.com with SMTP id\n 41be03b00d2f7-c70e27e2b74so1347949a12.0\n for ; Mon, 06 Apr 2026 21:39:12 -0700 (PDT)","from toolbx.alistair23.me ([2403:581e:fdf9:0:6209:4521:6813:45b7])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c6491fedsm15809963a12.8.2026.04.06.21.39.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 21:39:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775536750; x=1776141550; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2fXiHcneXVMhhF9C2Wl25YfbV2lULaA+TaRNA3rGmZ8=;\n b=i/acd2kn55cKfTVMDLAyi70MMI7eaoVjvL/lUUX7h9rN0fM7Ky9RvzfRJH9RhCz2ii\n wbTqOy0CzePRoZqMFeEzfku3jd2o41o3d2AOyDHIY5Xcg1maOb/tlPso3exWWNnSa9HT\n 9GurUKGzq/G25O/Pu+S7RkztyYyKTwE7lCgfD8UOC/SaepZTFKPjGig48+aGqjHDX2G3\n E1cEOyKQEa8t1juCAaDu9bBF3w9+F6TqC8V39lkqiI0beZU/KEOcALHA3FBkTZjarK+g\n 4FxpSwAgcL3JvaugUX82iAjXb0qjWBfhex6iS/UEZE4j8y6pzYwxKcQPraVCqk7zI6HY\n Ksjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775536750; x=1776141550;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=2fXiHcneXVMhhF9C2Wl25YfbV2lULaA+TaRNA3rGmZ8=;\n b=Tk6bsz+2jVq6Y6woClhNefEgWhWIvTxRJN13+r2g0TC5UgNqoCbqujd4JmnJTnLha5\n /2/aqhBd4jxpmGT7D8tuK1DyfIlS+LNv9nguG9B1mO7rWmQfyDhd/WJQ9hd9ghI3RFVy\n xh7vqJFWkajvpg8fendIeJ2rZ5rmP0Er/k9FLbmbVm09AIg3Io1+8Z7Z8rTCjc2RgOTQ\n q2ASiA5i0TdEaSypLJcGMjjhtpw03Ybbm0wMa0afFxpducqGmpPzgy0Uuo3Y70bmUcxU\n jdMda0ZroE8qQMKhVSOp05YSKZQTsM+py/0J0Fyw5PJd3wxuTasuZ1uOVFQhzYCBNY76\n IRow==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXZbTQoYftn4vj3wU406WQhosWZvyEgVYubEzDsLv5Eo4Q5QDo2xClwNEYIUCdBZ4RUVS8q1ij0Jan1@nongnu.org","X-Gm-Message-State":"AOJu0Yxh3YfUYgQqLvivi4CnEhqPdXmIR1XIddUSKCZQIJU3kCuI8Ib7\n r4GYkSaSE1R1g00xD+DN/T8RkbfKFwe1ct3RiuRbZZpGi4ca0M6WrZNH","X-Gm-Gg":"AeBDievGfzJMYjcrblJMYJU4KCDlB3Ujk1pE2zQ2DqC6s7WYErrAIL0Qhz4+QFc46MB\n Di0cjFSJy2kUGh8hYUp2pWC+LU4YCNHs6KVQ57UU3rwwtaIIVdN4KNmE+Oh1sge58RYT3FbVNeA\n yYyrjI8JfZEfs6pfVXHvYnaxAbRnDi1ESy/vgSrItJfujbREK5n0Kod2QPVIfDhta0odimRDRcL\n fkLLjRAhZodwFCR1mdgUtqfulFoQq495xxhKZMMGg8xmX9CxAiZUTqA2sr5CuXFIr6CkzNrItex\n IFxgBF2+SxOcHYVWsF6YozM+bloC2n58/NQz5kquGgl+bwufgzAWGn3nByCGQ2POFtkphMMCbES\n DR8xfhGKRA2tKW81/PaerDDw5bVv9HL1x0+QPQqH5a866nX8HHMIUggg2NdtAm4hTf/H4xrhhZ3\n qso8t6UBAUVWGVdZh1g3cnwu91vWtpkc5sRGADERto","X-Received":"by 2002:a05:6a20:3d8b:b0:39b:949d:6078 with SMTP id\n adf61e73a8af0-39f2ed105f1mr16825857637.6.1775536750544;\n Mon, 06 Apr 2026 21:39:10 -0700 (PDT)","From":"alistair23@gmail.com","X-Google-Original-From":"alistair.francis@wdc.com","To":"palmer@dabbelt.com, liwei1518@gmail.com, daniel.barboza@oss.qualcomm.com,\n zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com,\n qemu-riscv@nongnu.org, qemu-devel@nongnu.org","Cc":"alistair23@gmail.com,\n\tAlistair Francis ","Subject":"[PATCH 5/5] target/riscv: Use ELEN for Fractional LMUL check","Date":"Tue, 7 Apr 2026 14:36:14 +1000","Message-ID":"<20260407043614.372871-6-alistair.francis@wdc.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260407043614.372871-1-alistair.francis@wdc.com>","References":"<20260407043614.372871-1-alistair.francis@wdc.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::52f;\n envelope-from=alistair23@gmail.com; helo=mail-pg1-x52f.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Alistair Francis \n\nThe RISC-V spec states that\n\n\"\"\"\nFor a given supported fractional LMUL setting, implementations\nmust support SEW settings between SEWMIN and LMUL * ELEN, inclusive.\n\"\"\"\n\nWe were previously checking VLEN, instead of ELEN, so let's update to\ncheck ELEN instead of VLEN for fractional scaling.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3196\nSigned-off-by: Alistair Francis \n---\n target/riscv/vector_helper.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c\nindex 83dd26314d..b4fc791eb7 100644\n--- a/target/riscv/vector_helper.c\n+++ b/target/riscv/vector_helper.c\n@@ -47,18 +47,17 @@ target_ulong HELPER(vsetvl)(CPURISCVState *env, target_ulong s1,\n target_ulong reserved = s2 &\n MAKE_64BIT_MASK(R_VTYPE_RESERVED_SHIFT,\n xlen - 1 - R_VTYPE_RESERVED_SHIFT);\n- uint16_t vlen = cpu->cfg.vlenb << 3;\n int8_t lmul;\n \n if (vlmul & 4) {\n /*\n * Fractional LMUL, check:\n *\n- * VLEN * LMUL >= SEW\n- * VLEN >> (8 - lmul) >= sew\n- * (vlenb << 3) >> (8 - lmul) >= sew\n+ * ELEN * LMUL >= SEW\n+ * ELEN >> (8 - vlmul) >= sew\n */\n- if (vlmul == 4 || (vlen >> (8 - vlmul)) < sew) {\n+ if (vlmul == 4 ||\n+ (cpu->cfg.elen >> (8 - vlmul)) < sew) {\n vill = true;\n }\n }\n","prefixes":["5/5"]}