{"id":2220688,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220688/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407141809.16862-14-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407141809.16862-14-mohamed@unpredictable.fr>","date":"2026-04-07T14:18:09","name":"[v8,13/13] whpx: i386: interrupt priority support","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ea91e5f0bee5c43c9a841c07a3f4bf2b8d0d61ed","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407141809.16862-14-mohamed@unpredictable.fr/mbox/","series":[{"id":499029,"url":"http://patchwork.ozlabs.org/api/1.1/series/499029/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499029","date":"2026-04-07T14:17:59","name":"whpx: i386: bug fixes, feature probing and CPUID","version":8,"mbox":"http://patchwork.ozlabs.org/series/499029/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220688/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220688/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=UM/3yrGI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxGj0flQz1xtJ\n\tfor ; Wed, 08 Apr 2026 05:34:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wABUp-0006hH-Pk; Tue, 07 Apr 2026 14:49:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wABT6-0003uc-A1\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:48:15 -0400","from qs-2004g-snip4-11.eps.apple.com ([57.103.84.73]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wA7GE-0005An-1b\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 10:18:35 -0400","from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-9 (Postfix) with ESMTPS id\n 52D4A1800162; Tue, 07 Apr 2026 14:18:30 +0000 (UTC)","from localhost.localdomain (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-9 (Postfix) with ESMTPSA id\n F24C61800170; Tue, 07 Apr 2026 14:18:27 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775571513; x=1778163513;\n bh=Fwf2hc0HM6piMD7inQigrhq7YGVI+KQPRiX4MHhsvB8=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=UM/3yrGIkgNj7jgYmuqAnQr3JrbtXnM8vqfB2GhPxfY7FxxebRxxbA9spPOz2m64xREYi8PUyZuIPLd4M6GEHf+d4bGc/wxK50o7OeY4cLJlJpwD32oLG/wzc1AZKRbIS2jJTFSE4P+qDbq3I1bDDLulxuT6Ozgv4gpJGijynMPx8S5LAaASIWPe4KZmh1rsJSQKTmGs//WyoWXYygEwwqshASUcb5Gqr/CzIcc7Zg/XIHNGxeIJP8yZy8W982360+GDrrkFDIbd+RieapoKn3wPOZDn+Kmny8PRyWNq/ibi6lFUB9Y1oZM/u5C/4/PCh7BL5LNV1STL19YfdWIE0g==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Mohamed Mediouni ,\n Roman Bolshakov ,\n Phil Dennis-Jordan , Zhao Liu ,\n Paolo Bonzini , Wei Liu ,\n Pedro Barbuda ","Subject":"[PATCH v8 13/13] whpx: i386: interrupt priority support","Date":"Tue, 7 Apr 2026 16:18:09 +0200","Message-ID":"<20260407141809.16862-14-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260407141809.16862-1-mohamed@unpredictable.fr>","References":"<20260407141809.16862-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"1gZlW2i7FudcfQaZmlM67Y0bnWx2_PPp","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA3MDEzMSBTYWx0ZWRfX3ol8t+dfO4en\n FsdpHuSL8m0FxrHvqtIi/YACgnFI75BFjJf+ve7tH/FfGFGN+N9OThUxyuYbRc5eOIJbNhlZ41a\n iGRFDxQpcyKNpJBMlzg+9iRglatuTlgIFNH1klQqfZFLY3W2SC1NITEYrLaD0648YJZICBrLCv5\n OlVE0mRwisDDanvjAGQlc5lp2HOF7+jV/lBQfLyn9au76ptZQkq3omvekAaEA7kC1MxEXSWBHg5\n 2xht8i7zRiiNT1fTA9gZDD828l4KHJQZlsBxezrrlUP8K3F8snEb9xNU6twqEOweUKpfUUl9tHm\n H+gMHAEo0XQTe9/pP/+1fOw5s+0qn5QMY0ipMFeDZQPksq1LeLxpfSsTVNXAX8=","X-Proofpoint-GUID":"1gZlW2i7FudcfQaZmlM67Y0bnWx2_PPp","X-Authority-Info-Out":"v=2.4 cv=Wf0BqkhX c=1 sm=1 tr=0 ts=69d51237\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=NuKELtICf0aykZwt-QIA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-07_03,2026-04-07_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 bulkscore=0\n mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1030 adultscore=0\n lowpriorityscore=0 suspectscore=0 mlxlogscore=667 classifier=spam authscore=0\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604070131","Received-SPF":"pass client-ip=57.103.84.73;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Implement APIC IRR interrupt priorities.\n\nEven with kernel-irqchip=off, Hyper-V is aware of interrupt priorities\nand implements CR8/TPR, with the InterruptPriority field being followed.\n\nSigned-off-by: Mohamed Mediouni \n---\n target/i386/whpx/whpx-all.c | 27 +++++++++++++++++++++++----\n 1 file changed, 23 insertions(+), 4 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 7a31dc6427..569da3b90d 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -1588,6 +1588,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu)\n UINT32 reg_count = 0;\n WHV_REGISTER_VALUE reg_values[3];\n WHV_REGISTER_NAME reg_names[3];\n+ int irr = apic_get_highest_priority_irr(x86_cpu->apic_state);\n \n memset(&new_int, 0, sizeof(new_int));\n memset(reg_values, 0, sizeof(reg_values));\n@@ -1623,10 +1624,23 @@ static void whpx_vcpu_pre_run(CPUState *cpu)\n }\n }\n \n+ if (irr == -1) {\n+ if (!(!apic_accept_pic_intr(x86_cpu->apic_state) || !pic_get_output(isa_pic))) {\n+ /* In case it's a PIC interrupt not going through APIC */\n+ irr = 0;\n+ } else if (whpx_irqchip_in_kernel()) {\n+ /* if kernel-irqchip=on, APIC interrupts aren't injected here. */\n+ irr = 0;\n+ } else if (cpu_test_interrupt(cpu, CPU_INTERRUPT_HARD)) {\n+ abort();\n+ }\n+ }\n+\n /* Get pending hard interruption or replay one that was overwritten */\n if (!whpx_irqchip_in_kernel()) {\n if (!vcpu->interruption_pending &&\n- vcpu->interruptable && (env->eflags & IF_MASK)) {\n+ vcpu->interruptable && (env->eflags & IF_MASK)\n+ && (vcpu->tpr < irr || irr == 0)) {\n assert(!new_int.InterruptionPending);\n if (cpu_test_interrupt(cpu, CPU_INTERRUPT_HARD)) {\n cpu_reset_interrupt(cpu, CPU_INTERRUPT_HARD);\n@@ -1683,13 +1697,17 @@ static void whpx_vcpu_pre_run(CPUState *cpu)\n }\n \n /* Update the state of the interrupt delivery notification */\n- if (!vcpu->window_registered &&\n+ if ((!vcpu->window_registered ||\n+ (vcpu->window_priority < irr && vcpu->window_priority != 0) ||\n+ (irr == 0 && vcpu->window_priority != 0)) &&\n cpu_test_interrupt(cpu, CPU_INTERRUPT_HARD)) {\n reg_values[reg_count].DeliverabilityNotifications =\n (WHV_X64_DELIVERABILITY_NOTIFICATIONS_REGISTER) {\n- .InterruptNotification = 1\n+ .InterruptNotification = 1,\n+ .InterruptPriority = irr >> 4\n };\n vcpu->window_registered = 1;\n+ vcpu->window_priority = irr;\n reg_names[reg_count] = WHvX64RegisterDeliverabilityNotifications;\n reg_count += 1;\n }\n@@ -1703,7 +1721,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu)\n reg_names, reg_count, reg_values);\n if (FAILED(hr)) {\n error_report(\"WHPX: Failed to set interrupt state registers,\"\n- \" hr=%08lx\", hr);\n+ \" hr=%08lx, InterruptPriority=%i\", hr, irr >> 4);\n }\n }\n }\n@@ -1919,6 +1937,7 @@ int whpx_vcpu_run(CPUState *cpu)\n case WHvRunVpExitReasonX64InterruptWindow:\n vcpu->ready_for_pic_interrupt = 1;\n vcpu->window_registered = 0;\n+ vcpu->window_priority = 0;\n ret = 0;\n break;\n \n","prefixes":["v8","13/13"]}