{"id":2220612,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220612/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260407165206.1121317-3-jtornosm@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407165206.1121317-3-jtornosm@redhat.com>","date":"2026-04-07T16:52:04","name":"[net,v2,2/4] i40e: skip unnecessary VF reset when setting trust","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"b0094f653fc86665ab2424289712e3d4c32af0bb","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/1.1/people/93070/?format=json","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260407165206.1121317-3-jtornosm@redhat.com/mbox/","series":[{"id":499007,"url":"http://patchwork.ozlabs.org/api/1.1/series/499007/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499007","date":"2026-04-07T16:52:02","name":"Fix i40e/ice/iavf VF bonding after netdev lock changes","version":2,"mbox":"http://patchwork.ozlabs.org/series/499007/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220612/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220612/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=imTbl90d;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqsh00gymz1yGM\n\tfor ; Wed, 08 Apr 2026 02:52:48 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 4E34C60DA8;\n\tTue, 7 Apr 2026 16:52:46 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id nSeWOzFsv8VZ; Tue, 7 Apr 2026 16:52:45 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7D9FB60A9F;\n\tTue, 7 Apr 2026 16:52:45 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 1426F2EF\n for ; Tue, 7 Apr 2026 16:52:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 0577C40550\n for ; Tue, 7 Apr 2026 16:52:45 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id LLihmFusOgwx for ;\n Tue, 7 Apr 2026 16:52:44 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id EF2E5401CC\n for ; Tue, 7 Apr 2026 16:52:43 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-467aH6BKPJuklHHfbL38QQ-1; Tue,\n 07 Apr 2026 12:52:39 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A644E195605B; Tue, 7 Apr 2026 16:52:37 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.48.48])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 12085300019F; Tue, 7 Apr 2026 16:52:33 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7D9FB60A9F","OpenDKIM Filter v2.11.0 smtp2.osuosl.org EF2E5401CC"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775580765;\n\tbh=9mJAFR2P64r9/LOJtwiqZN1rPSkz3fb8OpCJmbM7VKg=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=imTbl90do1RIhYFV8f1hQ4gRF0qnQV0uU+wYe3sLkmpv3KwvbXmKRcT7iSdDRfS60\n\t BzzOaqnsIXLS8n5qgzjS2XRb2/a0O64CScAXNxYW0EJmNjyul0m9BzyWxnYJ+UPSTS\n\t YfJ33cjqobA/RUZIJw94xqLtebS6onhSFftDBmQXyMhwURpG1CmeMXwPA5Q1wTneXH\n\t 89q8K3secvkVFPqec8PcoWZVndxYW3riS/4NKdLIVIO6WKrykEEJGvsu9Q1wh0iyBC\n\t xuuRK3tw7UZI/ulHyh0mLoD8oH9HUnOVqWMnJjW+C5SpaKheiLw9DyC3U1PuEjHv5H\n\t RzRQCOGV8zMwQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org EF2E5401CC","X-MC-Unique":"467aH6BKPJuklHHfbL38QQ-1","X-Mimecast-MFC-AGG-ID":"467aH6BKPJuklHHfbL38QQ_1775580757","From":"Jose Ignacio Tornos Martinez ","To":"netdev@vger.kernel.org","Cc":"intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,\n anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com,\n Jose Ignacio Tornos Martinez ","Date":"Tue, 7 Apr 2026 18:52:04 +0200","Message-ID":"<20260407165206.1121317-3-jtornosm@redhat.com>","In-Reply-To":"<20260407165206.1121317-1-jtornosm@redhat.com>","References":"<20260407165206.1121317-1-jtornosm@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-MFC-PROC-ID":"ytTFWzBcYoSt-eMsc2sKnfWy27Xr9obuQFYNCh8xrBQ_1775580757","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775580762;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9mJAFR2P64r9/LOJtwiqZN1rPSkz3fb8OpCJmbM7VKg=;\n b=IS2Xgec0hE3OK5v1YdMv3LhkbfJeXRY2yqhDRlF2RcQJQTKUGKTuy8nZlx9BC1YYWMb/wT\n ysXkHlC6kP1ZUqsVzGDqXJKjo41aII/GE+pr9alI/DkgRJWWL0nn/j43xUFmEfJvTBsJQR\n nGZvvtxg/k+EDTi0zo3FZW9iGjAyaME=","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=IS2Xgec0"],"Subject":"[Intel-wired-lan] [PATCH net v2 2/4] i40e: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"When VF trust is changed, i40e_ndo_set_vf_trust() always calls\ni40e_vc_reset_vf() to sync MAC/VLAN filters. However, this reset is\nonly necessary when trust is removed from a VF that has ADQ (advanced\nqueue) filters, which need to be deleted\n\nIn all other cases, the reset causes a ~10 second delay during which:\n- VF must reinitialize completely\n- Any in-progress operations (like bonding enslave) fail with timeouts\n- VF is unavailable\n\nThe MAC/VLAN filter sync will happen naturally through the normal VF\noperations and doesn't require a forced reset.\n\nFix by only resetting when actually needed: when removing trust from a\nVF that has ADQ cloud filters. For all other trust changes, just update\nthe trust flag and let normal operation continue.\n\nSigned-off-by: Jose Ignacio Tornos Martinez \n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex a26c3d47ec15..fea267af7afe 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -4987,16 +4987,21 @@ int i40e_ndo_set_vf_trust(struct net_device *netdev, int vf_id, bool setting)\n \tset_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state);\n \tpf->vsi[vf->lan_vsi_idx]->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n \n-\ti40e_vc_reset_vf(vf, true);\n \tdev_info(&pf->pdev->dev, \"VF %u is now %strusted\\n\",\n \t\t vf_id, setting ? \"\" : \"un\");\n \n+\t/* Only reset VF if we're removing trust and it has ADQ cloud filters.\n+\t * Cloud filters can only be added when trusted, so they must be\n+\t * removed when trust is revoked. Other trust changes don't require\n+\t * reset - MAC/VLAN filter sync happens through normal operation.\n+\t */\n \tif (vf->adq_enabled) {\n \t\tif (!vf->trusted) {\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"VF %u no longer Trusted, deleting all cloud filters\\n\",\n \t\t\t\t vf_id);\n \t\t\ti40e_del_all_cloud_filters(vf);\n+\t\t\ti40e_vc_reset_vf(vf, true);\n \t\t}\n \t}\n \n","prefixes":["net","v2","2/4"]}