{"id":2220584,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220584/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/a72f02560aadca368b8f136d635ff5144b690517.1775571957.git.metze@samba.org/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2026-04-07T14:46:27","name":"[1/8] smb: smbdirect: change smbdirect_socket_parameters.{initiator_depth,responder_resources} to __u16","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a60b063c7f0dc63d11d92140367df720faaa4a12","submitter":{"id":8149,"url":"http://patchwork.ozlabs.org/api/1.1/people/8149/?format=json","name":"Stefan Metzmacher","email":"metze@samba.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/a72f02560aadca368b8f136d635ff5144b690517.1775571957.git.metze@samba.org/mbox/","series":[{"id":498990,"url":"http://patchwork.ozlabs.org/api/1.1/series/498990/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=498990","date":"2026-04-07T14:46:28","name":"smb: add kernel internal IPPROTO_SMBDIRECT","version":1,"mbox":"http://patchwork.ozlabs.org/series/498990/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220584/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220584/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (3072-bit key;\n secure) header.d=samba.org header.i=@samba.org header.a=rsa-sha256\n header.s=42 header.b=gj+xa9px;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10699-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org\n header.b=\"gj+xa9px\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=144.76.82.148","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=samba.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=samba.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqqDD3RkTz1xy1\n\tfor ; Wed, 08 Apr 2026 01:02:04 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CF5613044BA6\n\tfor ; Tue, 7 Apr 2026 14:55:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9754533CEA5;\n\tTue, 7 Apr 2026 14:55:25 +0000 (UTC)","from hr2.samba.org (hr2.samba.org [144.76.82.148])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E787733D51D\n\tfor ; Tue, 7 Apr 2026 14:55:23 +0000 (UTC)","from [127.0.0.2] (localhost [127.0.0.1])\n\tby hr2.samba.org with esmtpsa\n (TLS1.3:ECDHE_SECP256R1__ECDSA_SECP256R1_SHA256__CHACHA20_POLY1305:256)\n\t(Exim)\n\tid 1wA7hv-00000007WOm-1Cjg;\n\tTue, 07 Apr 2026 14:47:11 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775573725; cv=none;\n b=iOxyYokzOp5F87DJJJpb270pGBWPKEzh4ww9JLaOJZPd2S3bqbiXrbIQhL/x8z05Yjp0YEMyyWFw58MhLhebXL9CrEdOpu7vgHfjM5ZuNJHPweWbDqNGqAhIqcLrF7ddAb3Jo/xZewMYYBmnmeusT4FXMeOKioRq+3Gok1XVpSQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775573725; c=relaxed/simple;\n\tbh=qShIrCSLo9hc5XiLmctUzLf6l1j5HmqLLb9rQsB2mAY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=YHjV2Mv+hHmw+fQyTYT6iFcCrmtneohR81yJN8oSPM72Egp4rPy/TDdkVJjNdnfCtmmHmNwTwyit+PayKKEM0LsjGL4mwhvq4CfffOtkAZAD3mCu6moJQQP8t6zf5p0XoVZBNnbRBumOmaRJtb1FSN4x4e8G3aESKIwKuY+VEro=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=samba.org;\n spf=pass smtp.mailfrom=samba.org;\n dkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org\n header.b=gj+xa9px; arc=none smtp.client-ip=144.76.82.148","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org;\n\ts=42; h=Message-ID:Date:Cc:To:From;\n\tbh=SqP2ejoZrmlZEjm9zwXZG0rMc9+LIgTmP7z3fQgvZDU=; b=gj+xa9pxtecX+b0ilO113+G/Aa\n\t1k2bF3h5Kfrsr+Cvye/ILEdH4dSOL0Vzt6nZNJaK8sVq4NFNXkCukR92rJpcI1vgkriqqWzGvpZlj\n\tXlcfmQQVN9ZAy6nsCDnPyzy5OkdYLx/kc9qAZFRez1WTxuRcT9Sp02/pWPMV0QW3idjhBcydX76Yg\n\t8U+euwPMZFBVRQ3bU6dNHwiFO9qzlFgz/21ZRJlJj5XD8LYadsy4elir1S+64hWweEGGa/jYCv24c\n\t1FgePp/x8Ed8Y2C/M5uUzmRAeHEhX8/0UxutMAnVnF49No3wt3UihDopqaopHpZvRl7jn6mjQChaN\n\tYwhkHZz8kwr4VN27m8FAsnZx/NX+vwZ2WIHA2zYGc14145agaz4gfBaQRWDUN6+O/jJPXz8EWAwqe\n\tvg5YIf+i6F7pRod6SDTolwGz5y8GoYHQGqn/vClWJlMh2WVtiEUFqUiTYH2DhUlJvVCxkJlB4LjlI\n\t/OtkOQHx/9Bg0sHXcMdiNimV;","From":"Stefan Metzmacher ","To":"linux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org","Cc":"metze@samba.org,\n\tSteve French ,\n\tTom Talpey ,\n\tLong Li ,\n\tNamjae Jeon ,\n\tDavid Howells ,\n\tHenrique Carvalho ","Subject":"[PATCH 1/8] smb: smbdirect: change\n smbdirect_socket_parameters.{initiator_depth,responder_resources} to __u16","Date":"Tue, 7 Apr 2026 16:46:27 +0200","Message-ID":"\n ","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"","References":"","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"We still limit this to U8_MAX as the rdma api only uses __u8\nand that's also the limit for Infiniband and RoCE*,\nwhile iWarp would be able to support larger values at\nthe protocol level.\n\nAs struct smbdirect_socket_parameters will be part\nof the uapi for IPPROTO_SMBDIRECT in future, change it\nnow even if userspace sockets won't be supported yet.\n\nCc: Steve French \nCc: Tom Talpey \nCc: Long Li \nCc: Namjae Jeon \nCc: David Howells \nCc: Henrique Carvalho \nCc: linux-cifs@vger.kernel.org\nCc: samba-technical@lists.samba.org\nSigned-off-by: Stefan Metzmacher \n---\n fs/smb/common/smbdirect/smbdirect.h | 4 ++--\n fs/smb/common/smbdirect/smbdirect_socket.c | 5 +++++\n 2 files changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/smb/common/smbdirect/smbdirect.h b/fs/smb/common/smbdirect/smbdirect.h\nindex e70a21eb57f0..8fbffe3eb845 100644\n--- a/fs/smb/common/smbdirect/smbdirect.h\n+++ b/fs/smb/common/smbdirect/smbdirect.h\n@@ -32,8 +32,8 @@ struct smbdirect_socket_parameters {\n \t__u32 resolve_route_timeout_msec;\n \t__u32 rdma_connect_timeout_msec;\n \t__u32 negotiate_timeout_msec;\n-\t__u8 initiator_depth;\n-\t__u8 responder_resources;\n+\t__u16 initiator_depth; /* limited to U8_MAX */\n+\t__u16 responder_resources; /* limited to U8_MAX */\n \t__u16 recv_credit_max;\n \t__u16 send_credit_target;\n \t__u32 max_send_size;\ndiff --git a/fs/smb/common/smbdirect/smbdirect_socket.c b/fs/smb/common/smbdirect/smbdirect_socket.c\nindex 1e3b361728cc..4003753bea26 100644\n--- a/fs/smb/common/smbdirect/smbdirect_socket.c\n+++ b/fs/smb/common/smbdirect/smbdirect_socket.c\n@@ -166,6 +166,11 @@ int smbdirect_socket_set_initial_parameters(struct smbdirect_socket *sc,\n \tif (sp->flags & ~SMBDIRECT_FLAG_PORT_RANGE_MASK)\n \t\treturn -EINVAL;\n \n+\tif (sp->initiator_depth > U8_MAX)\n+\t\treturn -EINVAL;\n+\tif (sp->responder_resources > U8_MAX)\n+\t\treturn -EINVAL;\n+\n \tif (sp->flags & SMBDIRECT_FLAG_PORT_RANGE_ONLY_IB &&\n \t sp->flags & SMBDIRECT_FLAG_PORT_RANGE_ONLY_IW)\n \t\treturn -EINVAL;\n","prefixes":["1/8"]}