{"id":2220531,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220531/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260407130450.1489318-3-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260407130450.1489318-3-18255117159@163.com>","date":"2026-04-07T13:04:49","name":"[v7,2/3] PCI: Move pci_bus_speed2lnkctl2() to public header","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"08b81a88274452b007fdcfe2e4924027886c4740","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/1.1/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260407130450.1489318-3-18255117159@163.com/mbox/","series":[{"id":498981,"url":"http://patchwork.ozlabs.org/api/1.1/series/498981/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=498981","date":"2026-04-07T13:04:48","name":"PCI: Refactor PCIe speed validation and conversion functions","version":7,"mbox":"http://patchwork.ozlabs.org/series/498981/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220531/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220531/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=B1GcZFqB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52065-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"B1GcZFqB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.4","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqmhM3Qn0z1xy1\n\tfor ; Tue, 07 Apr 2026 23:07:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 6426130338A7\n\tfor ; Tue, 7 Apr 2026 13:05:48 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 293A63B636E;\n\tTue, 7 Apr 2026 13:05:47 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 076B83932CE;\n\tTue, 7 Apr 2026 13:05:43 +0000 (UTC)","from Precision-7960.. (unknown [])\n\tby gzga-smtp-mtada-g1-1 (Coremail) with SMTP id\n _____wC33bQHAdVpBqSeDg--.5276S4;\n\tTue, 07 Apr 2026 21:05:15 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775567147; cv=none;\n b=HpqcYki/jIhfTfUJBwGWaBSRKfrLFt58UoKmS+HqjeCtBQzY3jJhfufoQt8+SHAM4ZucCXbJf/3rNQWc/n7vJGtH/SBJgLZxOkY/VDXPJLTZo69WbAoJwiZ5vjl76OteFFerZAuOGYuBlrKEKyWhcWYMLMsr4+r0ikQpbHxfGHo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775567147; c=relaxed/simple;\n\tbh=aV4/PfQ0MMsxmwGCANhfhW0+XLmKLLxwbvgZJ3/pe+s=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=pGkpN/sxwi3uM2X/22xqCJVCw7RPYEWcZBHh3tkGB52JCnGydhCrRPbXj1sta41vxBVBp2qRVjsv+JrOYtXYsCxOWr1LPjK4AtGtnn5fm/RsvzdV8n8DFz0Qbg1wuAVsW1uz8A/s58EjccrrlSCqvaBy+wdzc8ddTDnEmZemVr0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=B1GcZFqB; arc=none smtp.client-ip=220.197.31.4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=+2\n\tNxNNebefVVPcox12b5aqVRfl/zr6eJpvMHbIcrZV4=; b=B1GcZFqBPQEwyutQxJ\n\tyfZf9DB6XS5opaMvzuftkqjn5Ske5fdy3WmYDBQvVSjN5HiyEnfkszqerENkKblv\n\tgoFjjaaey3DLFjTVP/gNU3nkM9rvZzUjtWzyrem8TQ5g0BX5P86bkt8D/ul7ZOIt\n\tWSdXkccfRY1Y7Ae428o87Dx98=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkw@linux.com,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tilpo.jarvinen@linux.intel.com,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>,\n\tShawn Lin ","Subject":"[PATCH v7 2/3] PCI: Move pci_bus_speed2lnkctl2() to public header","Date":"Tue, 7 Apr 2026 21:04:49 +0800","Message-Id":"<20260407130450.1489318-3-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260407130450.1489318-1-18255117159@163.com>","References":"<20260407130450.1489318-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wC33bQHAdVpBqSeDg--.5276S4","X-Coremail-Antispam":"1Uf129KBjvJXoWxWF48JFWUJw1fCry8Cw17ZFb_yoW5XF4rpa\n\t9xCFy5AF18Aw13AFZ0g3Wvqa45XFn3JFWUCrW3W395XFyay3s5Ga42vrWFyryaqrW0kry8\n\tJ3WUJF48C3WUtr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0piNzV5UUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbCwwsStWnVAQvN+QAA3t"},"content":"Move the static array-based pci_bus_speed2lnkctl2() function from\nbwctrl.c to pci.h as a public inline function.\n\nThis provides efficient O(1) speed-to-LNKCTL2 value conversion using\nstatic array lookup, maintaining optimal performance while enabling\ncode reuse by other PCIe drivers.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\nReviewed-by: Shawn Lin \n---\n drivers/pci/pci.h | 18 ++++++++++++++++++\n drivers/pci/pcie/bwctrl.c | 17 -----------------\n 2 files changed, 18 insertions(+), 17 deletions(-)","diff":"diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex f0a082bfd6f1..e0c2630e93f2 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -2,6 +2,7 @@\n #ifndef DRIVERS_PCI_H\n #define DRIVERS_PCI_H\n \n+#include \n #include \n #include \n #include \n@@ -611,6 +612,23 @@ static inline bool pcie_valid_speed(enum pci_bus_speed speed)\n \treturn (speed >= PCIE_SPEED_2_5GT) && (speed <= PCIE_SPEED_64_0GT);\n }\n \n+static inline u16 pci_bus_speed2lnkctl2(enum pci_bus_speed speed)\n+{\n+\tstatic const u8 speed_conv[] = {\n+\t\t[PCIE_SPEED_2_5GT] = PCI_EXP_LNKCTL2_TLS_2_5GT,\n+\t\t[PCIE_SPEED_5_0GT] = PCI_EXP_LNKCTL2_TLS_5_0GT,\n+\t\t[PCIE_SPEED_8_0GT] = PCI_EXP_LNKCTL2_TLS_8_0GT,\n+\t\t[PCIE_SPEED_16_0GT] = PCI_EXP_LNKCTL2_TLS_16_0GT,\n+\t\t[PCIE_SPEED_32_0GT] = PCI_EXP_LNKCTL2_TLS_32_0GT,\n+\t\t[PCIE_SPEED_64_0GT] = PCI_EXP_LNKCTL2_TLS_64_0GT,\n+\t};\n+\n+\tif (WARN_ON_ONCE(!pcie_valid_speed(speed)))\n+\t\treturn 0;\n+\n+\treturn speed_conv[speed];\n+}\n+\n static inline int pcie_dev_speed_mbps(enum pci_bus_speed speed)\n {\n \tswitch (speed) {\ndiff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c\nindex ea82e326f164..d48021bfd844 100644\n--- a/drivers/pci/pcie/bwctrl.c\n+++ b/drivers/pci/pcie/bwctrl.c\n@@ -48,23 +48,6 @@ struct pcie_bwctrl_data {\n /* Prevent port removal during Link Speed changes. */\n static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);\n \n-static u16 pci_bus_speed2lnkctl2(enum pci_bus_speed speed)\n-{\n-\tstatic const u8 speed_conv[] = {\n-\t\t[PCIE_SPEED_2_5GT] = PCI_EXP_LNKCTL2_TLS_2_5GT,\n-\t\t[PCIE_SPEED_5_0GT] = PCI_EXP_LNKCTL2_TLS_5_0GT,\n-\t\t[PCIE_SPEED_8_0GT] = PCI_EXP_LNKCTL2_TLS_8_0GT,\n-\t\t[PCIE_SPEED_16_0GT] = PCI_EXP_LNKCTL2_TLS_16_0GT,\n-\t\t[PCIE_SPEED_32_0GT] = PCI_EXP_LNKCTL2_TLS_32_0GT,\n-\t\t[PCIE_SPEED_64_0GT] = PCI_EXP_LNKCTL2_TLS_64_0GT,\n-\t};\n-\n-\tif (WARN_ON_ONCE(!pcie_valid_speed(speed)))\n-\t\treturn 0;\n-\n-\treturn speed_conv[speed];\n-}\n-\n static inline u16 pcie_supported_speeds2target_speed(u8 supported_speeds)\n {\n \treturn __fls(supported_speeds);\n","prefixes":["v7","2/3"]}