{"id":2220520,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220520/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260407-treewide-fixes-v1-14-66c9744a56a3@oss.qualcomm.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407-treewide-fixes-v1-14-66c9744a56a3@oss.qualcomm.com>","date":"2026-04-07T12:50:05","name":"[libgpiod,14/14] dbus: manager: use the correct loop counter in error path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5651ed321cc7fa96ce19eac4a9b4d1a32cf7bd10","submitter":{"id":92196,"url":"http://patchwork.ozlabs.org/api/1.1/people/92196/?format=json","name":"Bartosz Golaszewski","email":"bartosz.golaszewski@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260407-treewide-fixes-v1-14-66c9744a56a3@oss.qualcomm.com/mbox/","series":[{"id":498978,"url":"http://patchwork.ozlabs.org/api/1.1/series/498978/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=498978","date":"2026-04-07T12:49:56","name":"libgpiod: assortment of fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498978/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220520/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220520/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=TmIr8Oh6;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Vuvm6iKM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34801-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"TmIr8Oh6\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"Vuvm6iKM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqmLV31XQz1xy1\n\tfor ; Tue, 07 Apr 2026 22:52:18 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 55BA730166DB\n\tfor ; Tue, 7 Apr 2026 12:51:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2ACF13B52F5;\n\tTue, 7 Apr 2026 12:51:35 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D09893B4EB1\n\tfor ; Tue, 7 Apr 2026 12:51:33 +0000 (UTC)","from pps.filterd (m0279866.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6376gUf2492494\n\tfor ; Tue, 7 Apr 2026 12:51:33 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n [209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr8tq31-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Tue, 07 Apr 2026 12:51:33 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n af79cd13be357-8cd722c1a69so1122931785a.0\n for ;\n Tue, 07 Apr 2026 05:51:32 -0700 (PDT)","from brgl-qcom.local ([2a01:cb1d:dc:7e00:b36f:5370:5f91:2d5])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887e83682fsm577526505e9.7.2026.04.07.05.51.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 05:51:30 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775566294; cv=none;\n b=M8o+q9TQBUcrz8x4ofXp4YsTPPZyoDFtAopKSRKy6Dvtm9wHfuzKI368Ob9UvLtXwKTl03MefCyXtAyh43A8cLChTsACNL3iz7rkGlrHTy5LkW75i+E6kGj7ivSzVMdSO6aaYqm/at8Z99ytxpuCyDOtIPtXnIG6MVH7PVxrdi0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775566294; c=relaxed/simple;\n\tbh=TWQfrs0e9dEhBtvqktC9bbmzHUHGE+Zx6BUUNN2PVtc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=F9Xs1l17TNu0GTs7alj7YMmtWOuiEVUCFzYJl9bg2P8e74ITc1xYMUfqyxnsNLCMlPH3+wTYGbEMt72rhBBXTTHrBuz9daEcW1OvOZSESPTyX6OS6OC0U/6HUhcQgut20idCIdrsU8oNGkFGWwb3qNBMQNLXaWNEUzgs6TsSk6g=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=TmIr8Oh6;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=Vuvm6iKM; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tWIn0Nd0KRxJoNJGoySq75CLbbZd40MAzLAkrYFlwrxM=; b=TmIr8Oh6VsXm4dKj\n\tYuPlH69gcPmnMzEIgy+O78L75wB2bmZRMq4M6LmC8zgxPbobU46GyacufyBLw/L/\n\t4GQfMFjTjd8agHMTPTHAOMyQIyVC3Ov/FfYX4ebInZZDF8/d7JlDjARri6NO7Rge\n\tHyLKViaDtjLuKptxaeu2klbOnwk4rvQgjay7cDZ1UDD4BL731lCJqsEzyiw6sHNN\n\t9ztEdecMzwfOoinNA8MJDQa9XOcfJNhb4BZbNOLTqQe4NSSl2Sb/7YhklUG5erFS\n\tE9sVmkly/9FnnG7ADJcN/s0yekI9rlCskIw6Ak1Q2jJAB8j98W4FlXbbcF4GJNAA\n\t0Rj7Gw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775566292; x=1776171092;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=WIn0Nd0KRxJoNJGoySq75CLbbZd40MAzLAkrYFlwrxM=;\n b=Vuvm6iKMnxL+3BamdDC0tXMHxxwROoOXzoQ6AH5JK2Fitiv+gbgQjhsMCKhm3DOAZ3\n ZeQMrGp0+pO36Qxc9DtR5pcXgf8LNsjMWkBZ6OZG5Hi62+eIOouw03Z9gjii0Mybd/yz\n /zeAbKKjBZ1DsohMx6qld86hxph2/e1SEkwKtq2ccAaij2pxuAHAww4CIq7Y96qrUjHt\n 9TzeXIRjgznEWyZPAepLFB5E+HHgXq0nYvkgKNilUH6M0CIKqcQAdWz+YJbJUCZR3XTD\n Ih032GRDmfpPqPZbjGQcjppwpOOrDhzirNKl+WkjJUqavocqooKvLCviAEK+d2XJfcSR\n 3mNw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775566292; x=1776171092;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=WIn0Nd0KRxJoNJGoySq75CLbbZd40MAzLAkrYFlwrxM=;\n b=bDpPMwh8ujX5cFIVVO5HIUD3snHEcjCnwrb0D0hzbDZ5Syxscevr5zIuDSX9gPBt/1\n EgI3YZ1Mtu6HIn66atDOeCqrvfEb6cNkLvW/D9yfaDOHTDUynA1tzKa/N8m/jxQhE92/\n ska8vkbj7Nn947CjknccT4jp+UlvLgD6hrDyb6D7O0a8REKPa0LV1OMTP/O3v6x7ZmCi\n GYmjFUZvidSB3qFs9q8pjfpKIJ5JG4QQmkMmNd2MMyVYf5miaNVpLxqq0eSU2aMCYzBR\n D/hr4nlki+Pwd8kdkdCW+PqZq+ecW6NYmGyio2TiqMaV0mk1wlnBgB5OZycGkZmyeEYi\n tviQ==","X-Gm-Message-State":"AOJu0YzFrWHd9cEXU9q+oJ/t1GTTtN44NK5pgkHCbfbHnIPlTjCoxd5G\n\thjy8mtcYhNwQ2eGPeuviq4hWXcV6PMnAe5k+eNRg8oMJxPAcsb/V94gh++a6ygpkHkPuTzKb4Hb\n\tkSmV/wbgHjveyTdvRl8ptEDduzokBi4oVu8myQqVrnXrrKYfuNZ2SMHX474PWf5zM","X-Gm-Gg":"AeBDiev8GwHMmjTqyGyenscrbZHmEqK04tggLsrkN2qw23A1WTNM00yreQKARXe+Ngr\n\tOGHXbXUKeOZsPj+rznObLLJArVdiJezU4jA8DpksZwqIaF4JUx1+iq0eMBbmpFac/t6f3idwCqq\n\tkhAL6iha14hPdlflmleg5Xpi/U/+/M/vYxhG+PjNrQNYPmjGbQr0tbQJibIpHidoNYPHFH/Om6j\n\tnWo4Wjxxvpu4v941nRbm5fNYOYeclvxseUvE3m2mLIVBAA2eSLvUxiaahAZ0jGTm7bmw6a+TcF6\n\tZE2cr6oWfPlRa1sPZROgIcI8ccPzKN9v/d6Le3+anm/bI3Tjl/a23DW31Lz+3/gBtpTPVWclfto\n\t8NtQfx8hm/5zjvCROK7U+JQaH9FNLOeNPTKmnwPKXn69sdSiksWE=","X-Received":["by 2002:a05:622a:e:b0:50b:4d01:fafe with SMTP id\n d75a77b69052e-50d767c83d3mr183177841cf.1.1775566291992;\n Tue, 07 Apr 2026 05:51:31 -0700 (PDT)","by 2002:a05:622a:e:b0:50b:4d01:fafe with SMTP id\n d75a77b69052e-50d767c83d3mr183177501cf.1.1775566291585;\n Tue, 07 Apr 2026 05:51:31 -0700 (PDT)"],"From":"Bartosz Golaszewski ","Date":"Tue, 07 Apr 2026 14:50:05 +0200","Subject":"[PATCH libgpiod 14/14] dbus: manager: use the correct loop counter\n in error path","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260407-treewide-fixes-v1-14-66c9744a56a3@oss.qualcomm.com>","References":"<20260407-treewide-fixes-v1-0-66c9744a56a3@oss.qualcomm.com>","In-Reply-To":"<20260407-treewide-fixes-v1-0-66c9744a56a3@oss.qualcomm.com>","To":"Linus Walleij , Bartosz Golaszewski ,\n Kent Gibson , 4fqr <4fqr@proton.me>,\n Vincent Fazio ","Cc":"linux-gpio@vger.kernel.org,\n Bartosz Golaszewski ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1196;\n i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id;\n bh=TWQfrs0e9dEhBtvqktC9bbmzHUHGE+Zx6BUUNN2PVtc=;\n b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp1P2/Un5tlDashDmxlUEGkJ+dXVNCxZGvVxkGW\n 0RnhvQ+cDqJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCadT9vwAKCRAFnS7L/zaE\n w1tJEACYYI4vklwE3Qxi6qstF8dTmZe74GicAB2+lJvDj0pWvm7VmY3u8itmYaCXhph5WNIOL8j\n E+X9Dz9GVFh0nFXdkxj60eNcRaAvTNIzAK2Xeb3WPkpdr5haGaAiJcHzxkq2hko5bsa6pdF7HpA\n DlDGCbbmP7UxCZ9BTCTkvrPmBjFMNg1BhMvSUyFkF9ftHGiDNUPjwipW4TpPPs+qiDCTd5aAAjy\n 4UnE4LbB9UHQ9AKlsmc2Tyb6Hdxo2dah59YqA8vwXSwDMxNb2OT/RjcdxWNbtfDzaAyYV6IS3Re\n yW7nCd6aNOTungNnLt5aSwpeAYJThHtIrmQqSq+hbSohgEBOvTIaIPwDEkJb7CRv09RjAuD9cpQ\n 0woFzXincg4BtJMLTDMVMyi9BisLWrJFQeazJuapc8jK/MQizF0ZZNnJ/uFVxG23F/y9D9bAo4A\n xc94rtUML6WQxaewZ1oKR8tCfMD3eewHhCFVYg9fYvR19D8XGlhcy3fEnJ3Rkc5VPa7/E5rg7HH\n hhyFc18wX3gBBSQ6aohFdRSVf80pEvFTJJKCARsyoBPfCZS9L2Cmoy4DhV8xsghNGBMBI81YZIZ\n 4KguCxJSbxAFf9ocKn5KSMgU9vokzCzugKO7E+p02GpcJ+AX64yvgpFOzJGwSF6aWO1F3gt9yLh\n zOIocm9iwIKj+EA==","X-Developer-Key":"i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp;\n fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772","X-Proofpoint-GUID":"Dbi0Ip6oqO8_saurDuo_AeEPnNupUex0","X-Proofpoint-ORIG-GUID":"Dbi0Ip6oqO8_saurDuo_AeEPnNupUex0","X-Authority-Analysis":"v=2.4 cv=c9abhx9l c=1 sm=1 tr=0 ts=69d4fdd5 cx=c_pps\n a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8\n a=c9hAuP_oBUhSImE421AA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA3MDEyMCBTYWx0ZWRfXzR3Q+aEQ+yOd\n 9z+GHfX8hBYPtbbb5JdIgqV48E1ayNCZtVMtzIai6J1HucVb4AkeSHyNgJXx8XnwOBXAbqf2sFK\n TlQdIFKhDxzdpUQHAO47DpPD94eIdv5tYCxmsJuX6+7/yrYW9PtSwybtX8NYB2Q9qcMUMzmFiel\n 2VZMoWGubILqWRK1Za6yHL3tBNdanT3goyUtp3KxmuCTuiApuFHCSoeDcbNmouJDjQt3ImYccCR\n 1scJfgWpipr3v6kzTJqP4rK05w6YE9ZHcCf5GEIHHpJfy/gVBq3zwO/6CD/0KH6yNvNErEo5gqt\n Ez1YhcRg9jyNlfPkKY9cTizRIWV070iCkrooeSw1IcW5Vsuu9xOzRVB/sbx+Ms8TtMXIYlA4sIf\n FLvMCGyNlLcoVMkTLqjTbC3hM8pqWXDb2eCbS/kfpfT2rWtnz/EKlmSDkryG749R23hTk7eyXlS\n vBQ7Xu7cDzQL/3j33Gg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501\n bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070120"},"content":"In gpiodbus_daemon_export_lines(), the daemon iterates over all GPIO\nlines on a chip and establishes kernel watch file descriptors for\nline-info events. On failure, it attempts to clean up previously\nestablished watches but it uses i instead of j to refer to the line it\nwants to unwatch. Use the correct counter variable for the inner loop.\n\nFixes: a5ab76da1e0a (\"dbus: add the D-Bus daemon, command-line client and tests\")\nReported-by: 4fqr <4fqr@proton.me>\nSigned-off-by: Bartosz Golaszewski \n---\n dbus/manager/daemon.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/dbus/manager/daemon.c b/dbus/manager/daemon.c\nindex b9c295a55751d7d37d8a93033e9e1ad7ec8ac5af..a702682e568d345c597e3a1a2462c85197307f78 100644\n--- a/dbus/manager/daemon.c\n+++ b/dbus/manager/daemon.c\n@@ -308,7 +308,7 @@ static gboolean gpiodbus_daemon_export_lines(GpiodbusDaemon *self,\n \t\t\tg_critical(\"failed to setup a line-info watch: %s\",\n \t\t\t\t err->message);\n \t\t\tfor (j = i; j >= 0; j--)\n-\t\t\t\tgpiodglib_chip_unwatch_line_info(chip, i, NULL);\n+\t\t\t\tgpiodglib_chip_unwatch_line_info(chip, j, NULL);\n \t\t\treturn FALSE;\n \t\t}\n \n","prefixes":["libgpiod","14/14"]}