{"id":2220518,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220518/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260407-treewide-fixes-v1-8-66c9744a56a3@oss.qualcomm.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407-treewide-fixes-v1-8-66c9744a56a3@oss.qualcomm.com>","date":"2026-04-07T12:49:59","name":"[libgpiod,08/14] tools: fix an integer overflow bug in parse_period()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bb96493fcf10f69f9b760a4475cb3c57bd6a21f2","submitter":{"id":92196,"url":"http://patchwork.ozlabs.org/api/1.1/people/92196/?format=json","name":"Bartosz Golaszewski","email":"bartosz.golaszewski@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260407-treewide-fixes-v1-8-66c9744a56a3@oss.qualcomm.com/mbox/","series":[{"id":498978,"url":"http://patchwork.ozlabs.org/api/1.1/series/498978/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=498978","date":"2026-04-07T12:49:56","name":"libgpiod: assortment of fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498978/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220518/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220518/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=alUurbFX;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=gL+6M3lz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34795-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"alUurbFX\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"gL+6M3lz\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqmLQ2fTcz1xy1\n\tfor ; Tue, 07 Apr 2026 22:52:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E6425303FF9D\n\tfor ; Tue, 7 Apr 2026 12:51:26 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BB5D03B4EAD;\n\tTue, 7 Apr 2026 12:51:26 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 635A73B388B\n\tfor ; Tue, 7 Apr 2026 12:51:25 +0000 (UTC)","from pps.filterd (m0279869.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6376vP2a4008704\n\tfor ; Tue, 7 Apr 2026 12:51:24 GMT","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n [209.85.160.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrktqbc-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Tue, 07 Apr 2026 12:51:24 +0000 (GMT)","by mail-qt1-f198.google.com with SMTP id\n d75a77b69052e-50d831e8083so44341861cf.3\n for ;\n Tue, 07 Apr 2026 05:51:24 -0700 (PDT)","from brgl-qcom.local ([2a01:cb1d:dc:7e00:b36f:5370:5f91:2d5])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887e83682fsm577526505e9.7.2026.04.07.05.51.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 05:51:22 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775566286; cv=none;\n b=mamc7XCm0vTjgI1McU+9gGXeHIk7ujplOOMPvSGjXbEG7DLzGvN/iF+EP0LYvuNYYWsdsT05aypQO5WbhxoXc7mZo59j1ueYopW38Ph8nJODQYAojh1rOtfYm2P+inKWVeFQbCgUZ/xgNzFdXHrdeCsqDr/zFC62tbq9DiwIhDA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775566286; c=relaxed/simple;\n\tbh=jWFvO3ds6WHSS03qLpBAv4z5ZvC4ZA1I1mbNefa7oVw=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=ZQCpSXErG64+ZpIpIIUxRhAmIvx3Y9Qbl8cDu4TFlWZ0KUcc6Bv3rrxajk1Ow1Xpd55Q0evj4lEUlhCF/sEMYVj+Cx/38SxnzMU115vdAGowN1QX91b7C2JBW+5leiBvYg+Hr9QjXKGKjMURqk16FPBYgi78GjwlgiovASeYboQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=alUurbFX;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=gL+6M3lz; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\t8m//UG8A5NdRA9BYkeLWw34DCeWGvFzzfjjmI6jBX2Q=; b=alUurbFXlUDvMj8i\n\tf9lK1uasv4kb8kbBpPQUy4wpcwWxDe5sqN2S1fASV4X/K6re9TqKvYNwuU5MVsHp\n\tkrGHC7DYT6aT/yVFwm0X5caG07gTgHynIuddhM3AEjwP3zgYuvVmlqRx08ssVfdZ\n\tghYYer6UxAguawtWVIHppxlITu65nbWgcqndO/Jf1VPg3UCAYBY0Vubs7r771kDe\n\td/1iAdiis5czDyjZe5LJRzuOEQhhKyqXZ6mSSyP5tjK/KEWStu4aL/5ljN7k0zpZ\n\tjAwq5bupS3VwLzlvsB+9xtobpTCpDD5V0jOmIN16+QAtj9cUaPPGdThl4UyAG59z\n\tEqbr2w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775566284; x=1776171084;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=8m//UG8A5NdRA9BYkeLWw34DCeWGvFzzfjjmI6jBX2Q=;\n b=gL+6M3lzOOTLPzBQZ63XMtau+Ke2BOK9Xk78iOFh0ZBS3hJAoHw2jjYe4aBOoH4oK+\n 7nTdyicpr8U+dWJFigOs220cDs7K0BvPVG1miIqje/fvoyY01xzjRkj7pYEzQ3mGwLyP\n soti77syT6TH9GYlgV45c5Lf8N1b+t9uHpNrFYvZ5AeYfzrrH/+QDMmkmPlxi9g2JnNH\n PjCVROfsskQpcrj45S2fbJz+XMqhzMEJ884yPr67z59sXFkatib42SvjEaWDkkuQw59o\n 6Gz+mwugZqaMYwsDVzKGOYeZ/TzOVXZ3FPR7sfDvw29HpYR7HzeFwGOuFjx8qLgTHP3v\n l/mQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775566284; x=1776171084;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=8m//UG8A5NdRA9BYkeLWw34DCeWGvFzzfjjmI6jBX2Q=;\n b=SjIr82OtojwiIQJIMz+RM/uonKPWnUcJPAV2gWDWSQJgCr9AQt6/PZnmgM5mPoy43f\n 5USRhWjJFgbWLw/PDxtTIW37XQYI6qcYMfbvTb522191P+TDiJxwPMF06LW3AfhGX5jz\n Lxgeaazd+YLWpfoxuiJ/vPxg4EPiQ8ZdoeGlho2mVsQFGqZTTdwiB6YfUIE4+jxywKix\n 5l9/YLsqSbFQryC1cTw7XfbTzwskLbN6mYuAeKcoTDNSXQvqWitbOrONNyqXtvxMq9eK\n A1/rrYfr8leKry6rn+AHEvKnkIA/OeHMZaZrkomiKZh/fEBCanAGiwJ2KKyxgkOTFPgh\n COoA==","X-Gm-Message-State":"AOJu0YyHirZmTqfWowujD2Bh1+0ldr1pvGDmvPzkzOcJHAba3pdX5lHX\n\tpp59A5KLIGx9W4ex2xu0YayYxhhxRrjG92dSE8SlMwQ3E+2xOKwvmdElHmV+sBKa9Kank2nPgLR\n\taby4tTx+6yZnUPCNupLGTs6770hqTJUAc79NfmAAHReTfWHIpySdpb99SNt+VSr/o","X-Gm-Gg":"AeBDieto3K7RQTSdROr5W5+ozZRowztipQdE4yV1tm5l2xt08Khw/1LZmVQMhUlSKRB\n\tzgYZDF2Y+P16qetx2dkdMT27edExh/hHCjzUHr6AVkPwuELFmbbn9PV7I5RFm87/hkYeUkIPL7C\n\tvlWplYE5UCFV7bMtpY0WVGCIK+FtVBQL1zHU2kpcrVUyHUCIUIxKf0SmoShibhzJM8do/2EyuRb\n\t8+vVQfIthBwt0WmGkA/+7M+Txbcnwe4QnYfpJBE+ur0hYSGW1HNy85FBnVCTFkPI0Nl64jdQGHR\n\tltxuzIApl89NUi8i4ehz+LfirUWUsGgbTtvPpfIiJmX7SXd6UE98XtgvI/77VQB3hZ5wgeVZJw6\n\tSkR0yMjfUfj4eDlBY3EmIODZmrs2E2/IptW3GyCzSXF6xir3RBik=","X-Received":["by 2002:a05:622a:3:b0:50b:2876:586 with SMTP id\n d75a77b69052e-50d62b51055mr253990191cf.5.1775566283867;\n Tue, 07 Apr 2026 05:51:23 -0700 (PDT)","by 2002:a05:622a:3:b0:50b:2876:586 with SMTP id\n d75a77b69052e-50d62b51055mr253989781cf.5.1775566283461;\n Tue, 07 Apr 2026 05:51:23 -0700 (PDT)"],"From":"Bartosz Golaszewski ","Date":"Tue, 07 Apr 2026 14:49:59 +0200","Subject":"[PATCH libgpiod 08/14] tools: fix an integer overflow bug in\n parse_period()","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260407-treewide-fixes-v1-8-66c9744a56a3@oss.qualcomm.com>","References":"<20260407-treewide-fixes-v1-0-66c9744a56a3@oss.qualcomm.com>","In-Reply-To":"<20260407-treewide-fixes-v1-0-66c9744a56a3@oss.qualcomm.com>","To":"Linus Walleij , Bartosz Golaszewski ,\n Kent Gibson , 4fqr <4fqr@proton.me>,\n Vincent Fazio ","Cc":"linux-gpio@vger.kernel.org,\n Bartosz Golaszewski ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=924;\n i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id;\n bh=jWFvO3ds6WHSS03qLpBAv4z5ZvC4ZA1I1mbNefa7oVw=;\n b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp1P2696xENUGxzSi6Q1i569OUQvcdnjodF+5uO\n 6+dQaGrNRCJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCadT9ugAKCRAFnS7L/zaE\n w9kvD/9gzv64O2Hfvky2D5MkBqhS3rIM/1giG8XBRVwi8CAFYuh0b4isDESreArhTadsKaxpE4p\n VkuSoVZKD73474nDCx4Whpy7Hnx3LvKElbKa1zjq3+vOApOPC95/6WaN5VYwz3OuSJOXaRD+hZP\n WJn0w98Ms4DeNtSrFTrFB+oTLUF0b89WY7HlkpLy0xnpC/fLngoOG127o8cVhhGhh+d10cQqvr1\n mTbpMXway9l0UbZ9P3090Lj1rG0vMZTw1ElK6w2w+fa5IVV+/qp85OFjelog2CwLeR9mTonfA9g\n RXp2r/581Cnr7k7Xcx+nF2Y1Cy7fpvu+yi4JeMJH8Vxvud3d4WuQTLyZm9UX1WS/+6o0yTZJFAs\n 2kJzNlfLZFPXaCwkiQienpIEGpTFl6nuQsR/DZtjd0OrBFXy4ACt2DoyAJ/KsqtblIPuSMfovko\n 9Fxt1eo4OoA9LUjliHsa0mJ93qlGcVJNObmSzcug5viBRnCzT4OJCz7tuCI5XFj8jqoebXX+1za\n GpCgD4TvzWT5viq8aYLhHWS7BojNsPGS6RnJIHoJE8dMqlXbFfFY1x5IBF2973YvU93DyKhHO6t\n fscsdbD1S7Oc329DnLitTWWniuLYvLeQTPzUJr3Lkahx2FuHSRetQjDG8VkX24Y8pkW0sh1jgpF\n meMLsWXphCcosNA==","X-Developer-Key":"i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp;\n fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772","X-Authority-Analysis":"v=2.4 cv=Rrz16imK c=1 sm=1 tr=0 ts=69d4fdcc cx=c_pps\n a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8\n a=OukjycU9b2i9HsgDL5QA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22","X-Proofpoint-ORIG-GUID":"hYwZb5vApyViM6Sta5E2lZmL8EYrAkEe","X-Proofpoint-GUID":"hYwZb5vApyViM6Sta5E2lZmL8EYrAkEe","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA3MDEyMCBTYWx0ZWRfX7vSv/6FT4JL5\n S7kqqZo11N4PRjqpVQtf0AcQvm3XrMKfMZd/Inzp1DTyWg/8JLhrIOedtLN66B9r18XsVKRyZ/d\n 2cnzewkX/FCqsbH20vNpGMEVbeC11rTdX91T0rMjE1k/JNlasiZCF86itMI2qTA0ZQHsqdoXFcP\n pBMd+p3wE+cYXjvZMNKxJluNKe1wd6gWU44KJahfXUnbw5JzQeWzv1mfiNp9yYkmCG5IA5j5tIC\n nt56Yfh1oI4KWvny523BMZT/mnfGOQYx80e5TRrFBIwgmeiqDXaa90iWQs3WDNwxtX/ylkjH6DF\n hbG7y1RDKRrxPlht4K7Q47HaqJQQ8iR4M1ShQJvXS1xTxjHWp8tUIcHU51qHvbXwa9MBXlzLQ5I\n UixiXhxoRXVt6vi+i814DqIOhTo3UQ1/DLboE6IIyUPKT7o9TnSvsAHGBHf0l9vGmw3uqVXaZKm\n OhCvDbCR29OetZ6v6jA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501\n phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604070120"},"content":"If p * m exceeds ULLONG_MAX, the result wraps modulo 2^64. The wrapped\nvalue may be less than LLONG_MAX, passing the guard and returning\na completely wrong period value. Check the overflow before the\nmultiplication.\n\nFixes: 8ffb6489286f (\"tools: line name focussed rework\")\nReported-by: 4fqr <4fqr@proton.me>\nSigned-off-by: Bartosz Golaszewski \n---\n tools/tools-common.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/tools/tools-common.c b/tools/tools-common.c\nindex 79950dd7cf968503548c8091bba4135b90ec821f..497c6ff0cbe3160c10903b24e98de142024a3833 100644\n--- a/tools/tools-common.c\n+++ b/tools/tools-common.c\n@@ -151,9 +151,9 @@ long long parse_period(const char *option)\n \t\tm = 1000;\n \t}\n \n-\tp *= m;\n-\tif (*end != '\\0' || p > LLONG_MAX)\n+\tif (m != 0 && p > ULLONG_MAX / m)\n \t\treturn -1;\n+\tp *= m;\n \n \treturn p;\n }\n","prefixes":["libgpiod","08/14"]}