{"id":2220516,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220516/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260407-treewide-fixes-v1-4-66c9744a56a3@oss.qualcomm.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407-treewide-fixes-v1-4-66c9744a56a3@oss.qualcomm.com>","date":"2026-04-07T12:49:55","name":"[libgpiod,04/14] core: fix parameter type in gpiod_line_mask_test_bit()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4b145742c28cc31f244941239f6dcaf55d135d66","submitter":{"id":92196,"url":"http://patchwork.ozlabs.org/api/1.1/people/92196/?format=json","name":"Bartosz Golaszewski","email":"bartosz.golaszewski@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260407-treewide-fixes-v1-4-66c9744a56a3@oss.qualcomm.com/mbox/","series":[{"id":498978,"url":"http://patchwork.ozlabs.org/api/1.1/series/498978/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=498978","date":"2026-04-07T12:49:56","name":"libgpiod: assortment of fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498978/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220516/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220516/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=frSOAa8v;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=CCc2tuSN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34791-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"frSOAa8v\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"CCc2tuSN\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqmLJ5brmz1xy1\n\tfor ; Tue, 07 Apr 2026 22:52:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C27CA303C4DE\n\tfor ; Tue, 7 Apr 2026 12:51:21 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 24C6E3B4E94;\n\tTue, 7 Apr 2026 12:51:21 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BA3163B47D8\n\tfor ; Tue, 7 Apr 2026 12:51:19 +0000 (UTC)","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6376RCKM3402372\n\tfor ; Tue, 7 Apr 2026 12:51:18 GMT","from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n [209.85.160.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrhtqxf-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Tue, 07 Apr 2026 12:51:18 +0000 (GMT)","by mail-qt1-f199.google.com with SMTP id\n d75a77b69052e-50d8e8c47a3so36447881cf.0\n for ;\n Tue, 07 Apr 2026 05:51:18 -0700 (PDT)","from brgl-qcom.local ([2a01:cb1d:dc:7e00:b36f:5370:5f91:2d5])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887e83682fsm577526505e9.7.2026.04.07.05.51.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 05:51:17 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775566280; cv=none;\n b=Bpvzxq3JIukZ7lnTc76nm44bYTCk6YFncK/6og3JFxPZJdAYvWvQnEd6c1GOKMGEqv8DmColpNEAHDcRg/WKjnDkFBWMwouv4gCjVytg3AWcI61RVaZWEcjnGLQUjbJNQLey+fly/FsdgVLy7sCxwLx2SbRmpjHrCnk+yyb7mvk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775566280; c=relaxed/simple;\n\tbh=+NZ9iYWO4CliY+9ApLbnSgOd0B4wReUZbNetDBvz5dc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=T0gSXsFFtMsnXvjvdNhelDkU1hww9fsRva+ulj+Xkqyaws8clUu2rdNZRnP1S5+Uhw7F+yXWOmad9POmK4EwbvTtOiGcWXYKCEtZgsCurEeLPMQNbLpdxCMSXsSpDe9JFC2uyfuVKqASTa1+HDamvzpw5UDeth5VRuZE+iuZaZw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=frSOAa8v;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=CCc2tuSN; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tI5nTdcMftUu9a+A+qMXm4sbHiqgdJDraneoNfnE+UhA=; b=frSOAa8v5Hrei9AJ\n\t9j2wD4N4zQv1hg65fQ7onE5CH+H5AJ0n28KSzMi6CrSj8P8wbtAJr5QE/Tt/RPdB\n\thaVITBjDthijNJQakbuONqHlAg1zd0DhQD4bpywhOYBUsdQdGiKIkn9leglXKCPA\n\toeyV4pQ4nB+MhE87+5H2eLO60TmnudEDye6ICuYFZIqn/7NPLqIAfmvjq7zUjUne\n\tSBGkMGgXK1uuwHAezDbYfbla7FiuCNbSrg37WaBeW42Ig0vdmlHhZAKaeoYLTpeg\n\t6l0emn4CaQouKCklmNfpTLnJU72fywkyj0Ab4lVETTpOUAlsJQBtZpO5n4AXmest\n\tLc919Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775566278; x=1776171078;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=I5nTdcMftUu9a+A+qMXm4sbHiqgdJDraneoNfnE+UhA=;\n b=CCc2tuSNOQKaHLR4KWXcjC1G8Fqjr/WrLwY9m8rT8RKzjdFLAvLKc0Sf3HdTTgwMvG\n k1Tm3Sa3LhBuWgl+yUCTdC32sMQQ0jrD8Zdk4rb2+tMH96l+z8wAumpiSSxHrLR+A2ko\n ZPN4dYZxRK1N/Bpj2KzaOxr9J+ZUwILH/YBe6D83kcGi+bXdQJ1QKgUl1ANiOBhEw4Ci\n WioUjMAJ2+8OfAygVazxA9bzFS0S4tK3e9NTR8t0dD5gIk3e/u5omkT4IXrsdiYcjRdB\n 5V61O84juotnPG9D3VE1lUDLX5RyPXTttBJAwZY54k2R3prOqfbMDVpDN7ElnkGg+5Sn\n YQJA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775566278; x=1776171078;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=I5nTdcMftUu9a+A+qMXm4sbHiqgdJDraneoNfnE+UhA=;\n b=lVVxp+kC44Bpc50+EyldgLhe7RFoltV0uM5kaFx13p6VQcTGXNWRmbcxAeikgrhY0L\n suq2Dw1z0rsenK7LLepQQFhd+VvOlu8spcgOtXKWqI4FdUtkcApque1SqtEUZDGzS3Wu\n S2umCIsvRFV9V5Nn/+ClbOPAhezMVNAmqXnXK0I4ql6jm81mRhTGq9bGC4zi8v9DRbW/\n IB0/9cLwRjDmSQWda3ancCwXISL8YeOxZ4vyC2uVu8WjnyhQqA7RytygtonW7UPbcGek\n GZ+15X4qYMMrrjKaGZ2Bb8tcCKFkKK+xaz6tyfMY/+eMsf/JDmWm/K1BdiIduVOqNeEc\n Oqlw==","X-Gm-Message-State":"AOJu0Yy8lKEta74JYz15Cp12s4JkWNDqPDoUzZmmFbnLO1wQimF3/s9o\n\tbYNSzlj/ippUbmEu5yOckPpTrGxFpeTLXNZyuCkB3NMUg2cQIAcoG8ouDQFBnjjA5HsO48lKozD\n\t7KVKvyfYxpp04YswU5FhgXO1p6N09XTlxULQiEL1BWuWknhEFjbu0KcSR1lU5STbS","X-Gm-Gg":"AeBDiescvDyMK5oxbWGadq+wLnru2ucr7+xqePrPZ640zxu0uEZqIUTBbSlc5XE15nm\n\tMMs5U2w+9o1hn5alm2fMftpfbEv8v9nx2W7SnPAHrxPHHouKmflbkbA7yEjNqHe4ZhlkCo7vFAj\n\trUtlIscbWeOaa02XTJTwwhw9jS1ojrcU6X5r4BZDlwMLmBqfTcGHiz3cLPLn6nTFSGp9YZ8qH1l\n\tYsgG76+0DB4g7lMEgcveztumoFy6bXj6nbgsFM9TsSiBydg5ZOPWq8hfrZMwqf8LJV24puuNoCD\n\tsSz/HsqLD8Zlp3ckQaBw+F92/EGGACrygvTwlhFdlo58pjeOkPw1hbZHXB/SFB6bQgAmsoRCEUs\n\t/24Dd5dGJT3CLkyxCz404GwKQ88mMokgclfPiuDniVHXVojwMA3Y=","X-Received":["by 2002:a05:622a:5c89:b0:509:2618:cefb with SMTP id\n d75a77b69052e-50d62cc031cmr252904311cf.38.1775566278234;\n Tue, 07 Apr 2026 05:51:18 -0700 (PDT)","by 2002:a05:622a:5c89:b0:509:2618:cefb with SMTP id\n d75a77b69052e-50d62cc031cmr252903911cf.38.1775566277845;\n Tue, 07 Apr 2026 05:51:17 -0700 (PDT)"],"From":"Bartosz Golaszewski ","Date":"Tue, 07 Apr 2026 14:49:55 +0200","Subject":"[PATCH libgpiod 04/14] core: fix parameter type in\n gpiod_line_mask_test_bit()","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260407-treewide-fixes-v1-4-66c9744a56a3@oss.qualcomm.com>","References":"<20260407-treewide-fixes-v1-0-66c9744a56a3@oss.qualcomm.com>","In-Reply-To":"<20260407-treewide-fixes-v1-0-66c9744a56a3@oss.qualcomm.com>","To":"Linus Walleij , Bartosz Golaszewski ,\n Kent Gibson , 4fqr <4fqr@proton.me>,\n Vincent Fazio ","Cc":"linux-gpio@vger.kernel.org,\n Bartosz Golaszewski ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1766;\n i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id;\n bh=+NZ9iYWO4CliY+9ApLbnSgOd0B4wReUZbNetDBvz5dc=;\n b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp1P2220m7r/66fsJujOsKIG4VCwpW7Zn6C6735\n 7SZpp35slmJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCadT9tgAKCRAFnS7L/zaE\n w9lOEACkkoavo90Y2gbW2HpELP8loWLMB2HEyU0Q5EBB8pwcSTmLTplHCCa+yK4c7B5wG/u+ldq\n H0+T9SXH/0+XjGhwaw3EQ4hqovifjpKX5JxeUUVN7c1aUet8wrOdmYXD7YeH2ZXyXVZMZ8oU+Ff\n QEn+Snaa+aNncfeB81Ey7WI8GllcV8IkRAHGyix3oqAtrMzgG06ggoA62vZfbthaTKfeqTDC5Pf\n xVJWmaMmJvXyS5cBAHFvL2aHWrVrISiwotuSpod/y9HYhGGeFGnplIl1vXzsu4rZpv+u4o5aWQw\n Qp66OrHvqWIpuO7nXGJ+nVbOmBhxcAhBM+E4BCwn/r6sUNX2DYlJUhQbRWNzjZ6GJGmO9BXc1ti\n dKNwBiI1LySmQN9HIzPXbusJ29nHX+0M0q/IK/Wdu+uNkFwM0yFYEWvmydT1VLhBASGTaXUHb6U\n rO4S/5PApAGwrCsNTYFNb8+sZ9sq7MU8PYkxEk4PDZuDAOuC4VnynJxoVi1dMtKvuFO1aQhCTDA\n PilmPZtZ7KoKpXEDafpMpXo1/mWgi+RJ+tF73Jkil+b0aB9F0XqgeF3GSmP1IikZ7y50CmwU3kY\n UpzzsDeE1fDrwSCLtPtB15ikU7mGEKS/iV2pd3KBMuYY7yAUj0ByrQA/BNkfd9PLRI21hvDfAoL\n ABnB/oxqltkdtMw==","X-Developer-Key":"i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp;\n fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA3MDEyMCBTYWx0ZWRfX+RVtScGWRgMQ\n cR4EIcNVp/hjYS8Kit53tMzZUYNvX91kuPvoagNCM6tf+XR9CWE6hRvV2y9rjecJSf8GhO9eKdk\n rh22xrbvp3ax6BxV5QbyOcf72S2nUdqihSUnt5VvQpaZDSMuSgsvkecJSXWnuQLueKl73c95OoV\n puN6KD4w/8CYxg5fhi3UMH7KXE3vHsQAOSTJWIsRHiFmNdKn825n3qc2mAs4x6wd5KUCpLaGTwQ\n vDhyNm7WB4QZyboYmTP9rIg2prxJYcv+VosIvLCLX8SDGbb8aC4WiABTuSRu1oBkeV/Om9rDjC0\n hOp2oOOMdt1PwmAIC7e8Q0f/K81xRslyF6Wx8Pc1BnXDdpCUiZD0B1M1AM6ImYMaiTTz0S/fiDY\n MgsF3NbNxwFl53PXe7Mb5iwwiN/5+I8aoSm9iyEenaW0yhgf1c3I3FHwEyghgmq7MirSo6nZAZk\n uF2ovFHnT7W9ekG2beQ==","X-Proofpoint-GUID":"oEEClKFxhp22U76b7_s335AgZQ2DkpFx","X-Authority-Analysis":"v=2.4 cv=XPUAjwhE c=1 sm=1 tr=0 ts=69d4fdc6 cx=c_pps\n a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8\n a=C7zo6o5BiNti6Iwtyq8A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22","X-Proofpoint-ORIG-GUID":"oEEClKFxhp22U76b7_s335AgZQ2DkpFx","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0\n clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 spamscore=0\n lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604070120"},"content":"Unlike other bit helpers, gpiod_line_mask_test_bit() takes a signed\ninteger as argument defining the bit to test. Shifting a value by a count\nthat is negative or >= the width of the promoted type is undefined\nbehavior. Make the type consistent with other helpers even though all\ncurrent callers are safe as they use variables of size_t as argument to\nthis function.\n\nFixes: b7ba732e6a93 (\"treewide: libgpiod v2 implementation\")\nReported-by: 4fqr <4fqr@proton.me>\nSigned-off-by: Bartosz Golaszewski \n---\n lib/internal.c | 2 +-\n lib/internal.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/lib/internal.c b/lib/internal.c\nindex 56cb8b9b44b6a81735b40b5a191631a00e0e8638..50d3df94444d622fb125ceb07ac40ca84d944a0c 100644\n--- a/lib/internal.c\n+++ b/lib/internal.c\n@@ -139,7 +139,7 @@ void gpiod_line_mask_zero(uint64_t *mask)\n \t*mask = 0ULL;\n }\n \n-bool gpiod_line_mask_test_bit(const uint64_t *mask, int nr)\n+bool gpiod_line_mask_test_bit(const uint64_t *mask, unsigned int nr)\n {\n \treturn *mask & (1ULL << nr);\n }\ndiff --git a/lib/internal.h b/lib/internal.h\nindex 420fbdda5ec05f2453842bd03ba093104934e556..12899bb85f9e674071c176cf195af81ebd849738 100644\n--- a/lib/internal.h\n+++ b/lib/internal.h\n@@ -41,7 +41,7 @@ int gpiod_set_output_value(enum gpiod_line_value in,\n int gpiod_ioctl(int fd, unsigned long request, void *arg);\n \n void gpiod_line_mask_zero(uint64_t *mask);\n-bool gpiod_line_mask_test_bit(const uint64_t *mask, int nr);\n+bool gpiod_line_mask_test_bit(const uint64_t *mask, unsigned int nr);\n void gpiod_line_mask_set_bit(uint64_t *mask, unsigned int nr);\n void gpiod_line_mask_assign_bit(uint64_t *mask, unsigned int nr, bool value);\n \n","prefixes":["libgpiod","04/14"]}