{"id":2220403,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220403/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260407075343.220555-3-acelan.kao@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/1.1/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260407075343.220555-3-acelan.kao@canonical.com>","date":"2026-04-07T07:53:43","name":"[SRU,Q,2/2] drm/amdgpu: Fix validating flush_gpu_tlb_pasid()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5e06d87dd33ab171e3d1b0b506c4dc720ff939ec","submitter":{"id":2976,"url":"http://patchwork.ozlabs.org/api/1.1/people/2976/?format=json","name":"AceLan Kao","email":"acelan.kao@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260407075343.220555-3-acelan.kao@canonical.com/mbox/","series":[{"id":498933,"url":"http://patchwork.ozlabs.org/api/1.1/series/498933/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=498933","date":"2026-04-07T07:53:41","name":"BUG: kernel NULL pointer dereference in amdgpu(regression)","version":1,"mbox":"http://patchwork.ozlabs.org/series/498933/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220403/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220403/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PErBrTvi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqdkf6CQCz1xy1\n\tfor ; Tue, 07 Apr 2026 17:54:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wA1GG-00021S-Ao; Tue, 07 Apr 2026 07:54:12 +0000","from mail-pj1-f43.google.com ([209.85.216.43])\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from ) id 1wA1GE-0001zZ-PO\n for kernel-team@lists.ubuntu.com; Tue, 07 Apr 2026 07:54:11 +0000","by mail-pj1-f43.google.com with SMTP id\n 98e67ed59e1d1-35da01fc0baso3226672a91.2\n for ; Tue, 07 Apr 2026 00:54:10 -0700 (PDT)","from localhost ([2001:67c:1562:8007::aac:4468])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35ddb973ffasm14967091a91.2.2026.04.07.00.54.05\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 00:54:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775548448; x=1776153248; darn=lists.ubuntu.com;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:sender:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+hLmUgdGPyPS1Zd753C2LFIroYv5ceStnp6FKkm9Csg=;\n b=PErBrTvilHU9pf1Y+j06+3wEaq+XfqFpWODYm/r6HFYmNXUCkuag4hQZ3AP8/wkQyZ\n oli9Lz3wrtRwxsJH/kmGC0vVgnDH/HiHnAe1nmUZRBpesnAOvIrKr9U/n9lgADDSz6la\n mu6UE+WS/40IIzqUHmIC2hrnqzs5aorPQV8lGjMUBFLkodBzQW76Bu8oMdjl65b62n2N\n tulolINWcUe3Ko4FMS7hYe6CXfRd2mv7AtKPSaAh61saYul0SO4Q6P2pvLlpYBtwgTcK\n q0mMiY7ucoLuHQv699MP2ND+Yn8W7p4LV4H2ZtL1AJZHI7tkl8xb17gs/DwX4Rrq9zHS\n wuxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775548448; x=1776153248;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:sender:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=+hLmUgdGPyPS1Zd753C2LFIroYv5ceStnp6FKkm9Csg=;\n b=OF9hRVyJz6miqTF3lcIToNxMHMThwtbMFMAOyyz5tdikKX7c5zInSv1YJ4KuwNC/bS\n qn631NLQx5uwDhnxaysxeLg524URnAIYX2NGVk71ZE9mIS97kEGrUQkoDaWTko8gtM9k\n eWzoV2NClwVrn0zFI/+fhNZ4znw5xDOqCDS2eur8UtxdGz1FcJ3qAX9et0eQ9eF16VqQ\n x/o5IX7ZlCgd279YrPV8aLwFrRrrWKEd9GvXBV/M/TEX8pLjXxp8v6lejmIxiFlY2xgp\n NfJQiUIqbZuSMSqjGyzq4lx+cqne2VgWlgQ4W+9ib36r5LCX/UwEN1zC/emnOkI+1Ao9\n QqpQ==","X-Gm-Message-State":"AOJu0YwMlitIP+/IV48WQ7w7bQpGbaTn1GmsLt+6/6+oNlvBrJBmmUUz\n 5Cses+y0JqGcaw59CK2zu79Hz5Z3wMRpLdtzx/bOqT1k1QAKMISwcNAlc5uQChqv","X-Gm-Gg":"AeBDiesL/nHyY/v0i7BL544Q+tRdCAhH0U0cdeGR3HbEAp09+OI4HJ8uGJ7mw81q/MY\n UxpEwJh9F9cdu5KiyV3DLMzEkEXSOxpHxt+l7oYbgrfeKevb9Yzw/hMgS1lvSqaoiWQGvdD6iRp\n D+qFWOSrOE2K0uri8YT5leqtZ7zD9cjWwSr9z+zy3yLaTVnNMd62koSoSZIDzMsflQLeeRBxjPb\n LEGHuSmgZEt/WyiC4z6E0KmLorkPBHAw4cdHk7rW8Lax43Ok/hE/UCsF9DR5BQyongL3cjVtB8k\n 36/nMNUMj/93bYdcWHSVRbG9Pq+/p96Ub3e86Q6RRQ+Ch5uWonE5RZ/wdnebFK6zUa4DvRXjz2L\n N9p3o09EDBYap+o4iARYRoCRcA7hvQ9c53lNbjBYkfxT1P/F+yOEy/sb3SueQzjMUokC8F5ifNW\n yfFtfiYPH4YL7JyETj","X-Received":"by 2002:a17:90b:3c85:b0:359:9014:99e7 with SMTP id\n 98e67ed59e1d1-35de69b84bamr14526015a91.29.1775548448164;\n Tue, 07 Apr 2026 00:54:08 -0700 (PDT)","From":"AceLan Kao ","To":"kernel-team@lists.ubuntu.com","Subject":"[SRU][Q][PATCH 2/2] drm/amdgpu: Fix validating flush_gpu_tlb_pasid()","Date":"Tue, 7 Apr 2026 15:53:43 +0800","Message-ID":"<20260407075343.220555-3-acelan.kao@canonical.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260407075343.220555-1-acelan.kao@canonical.com>","References":"<20260407075343.220555-1-acelan.kao@canonical.com>","MIME-Version":"1.0","Received-SPF":"pass client-ip=209.85.216.43; envelope-from=acelan@gmail.com;\n helo=mail-pj1-f43.google.com","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Timur Kristóf \n\nBugLink: https://bugs.launchpad.net/bugs/2144577\n\nWhen a function holds a lock and we return without unlocking it,\nit deadlocks the kernel. We should always unlock before returning.\n\nThis commit fixes suspend/resume on SI.\nTested on two Tahiti GPUs: FirePro W9000 and R9 280X.\n\nFixes: f4db9913e4d3 (\"drm/amdgpu: validate the flush_gpu_tlb_pasid()\")\nReported-by: kernel test robot \nReported-by: Dan Carpenter \nCloses: https://lore.kernel.org/r/202601190121.z9C0uml5-lkp@intel.com/\nSigned-off-by: Timur Kristóf \nSigned-off-by: Prike Liang \nReviewed-by: Prike Liang \nReviewed-by: Christian König \nSigned-off-by: Alex Deucher \n(cherry picked from commit e3a6eff92bbd960b471966d9afccb4d584546d17)\nSigned-off-by: Chia-Lin Kao (AceLan) \n---\n drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c\nindex 84ade0f9f2f89..cdf9eee20951f 100644\n--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c\n+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c\n@@ -733,8 +733,10 @@ int amdgpu_gmc_flush_gpu_tlb_pasid(struct amdgpu_device *adev, uint16_t pasid,\n \n \tif (!adev->gmc.flush_pasid_uses_kiq || !ring->sched.ready) {\n \n-\t\tif (!adev->gmc.gmc_funcs->flush_gpu_tlb_pasid)\n-\t\t\treturn 0;\n+\t\tif (!adev->gmc.gmc_funcs->flush_gpu_tlb_pasid) {\n+\t\t\tr = 0;\n+\t\t\tgoto error_unlock_reset;\n+\t\t}\n \n \t\tif (adev->gmc.flush_tlb_needs_extra_type_2)\n \t\t\tadev->gmc.gmc_funcs->flush_gpu_tlb_pasid(adev, pasid,\n","prefixes":["SRU","Q","2/2"]}