{"id":2220290,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220290/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260406-mtk-spi-nor-improvements-v1-4-66f675cbbd3e@baylibre.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260406-mtk-spi-nor-improvements-v1-4-66f675cbbd3e@baylibre.com>","date":"2026-04-06T20:13:30","name":"[4/8] spi: mtk_snor: check return value of mtk_snor_cmd_exec()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"682e55891d61bec69ed5e919d6143c72c38ae828","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/1.1/people/87228/?format=json","name":"David Lechner","email":"dlechner@baylibre.com"},"delegate":{"id":161331,"url":"http://patchwork.ozlabs.org/api/1.1/users/161331/?format=json","username":"dlech","first_name":"David","last_name":"Lechner","email":"dlechner@baylibre.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260406-mtk-spi-nor-improvements-v1-4-66f675cbbd3e@baylibre.com/mbox/","series":[{"id":498893,"url":"http://patchwork.ozlabs.org/api/1.1/series/498893/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498893","date":"2026-04-06T20:13:26","name":"spi: mtk_snor: various fixes and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/498893/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220290/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220290/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=jEV9KdUK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"jEV9KdUK\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqLDg1bcmz1xtJ\n\tfor ; Tue, 07 Apr 2026 06:15:47 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2C23584198;\n\tMon, 6 Apr 2026 22:14:54 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0DA998415C; Mon, 6 Apr 2026 22:14:50 +0200 (CEST)","from mail-ot1-x332.google.com (mail-ot1-x332.google.com\n [IPv6:2607:f8b0:4864:20::332])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D1B45840B0\n for ; Mon, 6 Apr 2026 22:14:36 +0200 (CEST)","by mail-ot1-x332.google.com with SMTP id\n 46e09a7af769-7dbd23bc684so1107056a34.2\n for ; Mon, 06 Apr 2026 13:14:36 -0700 (PDT)","from [127.0.1.1] ([2600:8803:e7e4:500:90d7:b13f:c53:8ca3])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-68597f6c7bdsm2642044eaf.3.2026.04.06.13.14.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 13:14:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775506475;\n x=1776111275;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=YiN9f9S0C/srNIAZNOMjkjZJ5/kwdKorA/UiXS05XLQ=;\n b=jEV9KdUKCcB5wmgQRFlDwPo3Gir/F47pLfz21B8dIs+tl5fkLVTBfqpiIkMFJVMWx9\n csxqRmvxNCiOcHQicwUoyKiKTZ0Nt4kRVSZxTj17UA9WLCjIWzw56YjCib1eFQQD1Vek\n +I70jNbnO8Vk++oT6lH+kkTnna52NXw7KC5/sEux0t6OU7tMnF78b/7snq6YqigGGYeu\n 4HEZDy0zMU+CxffjYucmmS4JQ8XrATw0TwXh9iNii+usuBi7F7L8urVMjtskCJO4NRcx\n ZDZVjAsLhn5jJ/4tn+2v/GRmtD5vLjV++JmaYpDTncuploZ+Ex9ZwCNNnA0FwLpbotae\n f/nA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775506475; x=1776111275;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=YiN9f9S0C/srNIAZNOMjkjZJ5/kwdKorA/UiXS05XLQ=;\n b=Xg0Vgoj/Dy7VCKxymfi0DLjaYCtTzPeIoYOQ8Mq4fCiI03DmjFW8avXiyhqON0FwEB\n WzCdrOTt4ngNukcNLRIaHP7uZz7QP3CKuWC1BfStvd51OcscovxlN48bR63BAqM/7TNq\n I24tsC7YnKOM9l8X52YlSGd/PuXSzYUS9Ud2ZamED7csCnivs0TRMmeExATsSLzRQ7r7\n /hYeMMW+zBXBcSqYtV+nekLNFjeyZx4neCzwGTPPj4oVQs9x/tWlHU0i/r0a/qy8SR4H\n sEKeiMxLb+tumlMZjbtBjuczYLWmMuaL/pK9du1cDI3abzT+2BM4fSCqg2nsvMcxBNwq\n YaeQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCU0lrSwdNjTNJ3RaHRVjCamk1sU/MVB7b5KJpB6V/O8uYpJ9AHjCNbVuPZw/Qp/Y7zVEN6zTBc=@lists.denx.de","X-Gm-Message-State":"AOJu0Yw7FDuPnnwBAv9Eln16qWy2gnV10Oddgm2vdZwqA0PehELITv32\n ruO2QGK4T/6kGmqKYmA7zk/UpdI1qRtFx/4B6ATJnCbbj3thjYXKIrZ0I110JDSj077vo0tCW2k\n yhtS3","X-Gm-Gg":"AeBDievMR0ZrklWRTLta/SmbZ55MWiVJZIjatOi3VFmzvsbafw8TAmr59uZUiT1S5Kz\n B8XcQSVoadnq/kGCLYvzUUdfnKrwhvAOoEvdhRf99I80a/In5AcyH1/w/8Z6xW9LQrp+unfHGl6\n GuL4yt63Wx0Dsk1UPO0xT2jz+63UUkdgpmFBsXug8qs9DDlUhNJyWLWjeJ73tTh29b+OFE9fy1a\n C6ZP3mln2aGhqOz4h8qXVfg7CLTvyzchItEhbPU04Wo/PnCQtey5Dc+nYUQvGTC9lK3znBxSgIf\n p7iNnAJdPbK65nSs9bikr2T9TTutz9oVGp7+oR6D2QLt32oMt4DnuNbuXHCjSqy+J8n18FH41gq\n z/gRrAfaNZH64EeSV/YnrTRB1ESnSrf380EaAU1oDDNvbRWXeuYOQSdlCUkNp4V1SM7lWdXuUKg\n cfc5Tsk/u57WbAX3BRM/ZKJdP/aA8=","X-Received":"by 2002:a05:6820:2218:b0:686:d107:285c with SMTP id\n 006d021491bc7-686d1073854mr1592151eaf.27.1775506475501;\n Mon, 06 Apr 2026 13:14:35 -0700 (PDT)","From":"David Lechner ","Date":"Mon, 06 Apr 2026 15:13:30 -0500","Subject":"[PATCH 4/8] spi: mtk_snor: check return value of mtk_snor_cmd_exec()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260406-mtk-spi-nor-improvements-v1-4-66f675cbbd3e@baylibre.com>","References":"<20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>","In-Reply-To":"\n <20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>","To":"Ryder Lee , Weijie Gao ,\n Chunfeng Yun ,\n Igor Belwon ,\n GSS_MTK_Uboot_upstream ,\n Tom Rini ","Cc":"Julien Stephan , u-boot@lists.denx.de,\n David Lechner , \"Noah.Shen\" ,\n \"Noah.Shen\" ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1534; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=BEgMHMX3xCXQDXqUYr0m/JBrE33O2zVhysyHsrMiEZM=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBp1BQFYjagVrBq5Xxv7wY3pov44McppGe/qcfd/\n Wxztb0/ODqJAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCadQUBRYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/AwvoH/0SY/4Szr96vsKbPTZPkkVFetgLqCkYO0eAib0S\n J82DJ5d7PTH/aGRT4Iz56S2t0oPECJs8E/mXFhDiUW5LrjvO6Vr149wG50lrOhwoGIF28AfFok0\n 994KRhL22akH5JXtb238beIqtGpqfkrcLTzC8nfJRpsyF+90I4fg538lFRXRZvfg8RgyfX53c60\n hDCGKcN7N+2rZnzgIKfWiVxMUWwqI5yMtjbcbPH+J8f5Ck+CvF4A24/8/asUvy91k1MZWRbgNe1\n mHMAkyPTwAimECpeTBEQd7TAGkL3s0t113t4OW5N2nmhUjJIsL7wQKkgvLqBsTr/E2QCYgn2fsK\n uK70=","X-Developer-Key":"i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: \"Noah.Shen\" \n\nAlways check the return value of mtk_snor_cmd_exec() and propagate the\nerror.\n\nSigned-off-by: Noah.Shen \nSigned-off-by: David Lechner \n---\n drivers/spi/mtk_snor.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/spi/mtk_snor.c b/drivers/spi/mtk_snor.c\nindex 674e723db01..babdb4600d5 100644\n--- a/drivers/spi/mtk_snor.c\n+++ b/drivers/spi/mtk_snor.c\n@@ -362,8 +362,12 @@ static int mtk_snor_pp_buffered(struct mtk_snor_priv *priv,\n \t\t buf[i];\n \t\twritel(val, priv->base + MTK_NOR_REG_PP_DATA);\n \t}\n-\tmtk_snor_cmd_exec(priv, MTK_NOR_CMD_WRITE,\n-\t\t\t (op->data.nbytes + 5) * BITS_PER_BYTE);\n+\n+\tret = mtk_snor_cmd_exec(priv, MTK_NOR_CMD_WRITE,\n+\t\t\t\t(op->data.nbytes + 5) * BITS_PER_BYTE);\n+\tif (ret)\n+\t\treturn ret;\n+\n \treturn mtk_snor_write_buffer_disable(priv);\n }\n \n@@ -386,7 +390,7 @@ static int mtk_snor_cmd_program(struct mtk_snor_priv *priv,\n \tint rx_len = 0;\n \tint reg_offset = MTK_NOR_REG_PRGDATA_MAX;\n \tint tx_len, prg_len;\n-\tint i;\n+\tint i, ret;\n \tvoid __iomem *reg;\n \tu8 val;\n \n@@ -435,7 +439,9 @@ static int mtk_snor_cmd_program(struct mtk_snor_priv *priv,\n \t/* trigger op */\n \twritel(prg_len * BITS_PER_BYTE, priv->base + MTK_NOR_REG_PRG_CNT);\n \n-\tmtk_snor_cmd_exec(priv, MTK_NOR_CMD_PROGRAM, prg_len * BITS_PER_BYTE);\n+\tret = mtk_snor_cmd_exec(priv, MTK_NOR_CMD_PROGRAM, prg_len * BITS_PER_BYTE);\n+\tif (ret)\n+\t\treturn ret;\n \n \t/* fetch read data */\n \treg_offset = 0;\n","prefixes":["4/8"]}