{"id":2220285,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220285/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260406-mtk-spi-nor-improvements-v1-3-66f675cbbd3e@baylibre.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260406-mtk-spi-nor-improvements-v1-3-66f675cbbd3e@baylibre.com>","date":"2026-04-06T20:13:29","name":"[3/8] spi: mtk_snor: conditionally copy tx/rx data","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2e1196d2d6c2f2472e120383d77225470bede12a","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/1.1/people/87228/?format=json","name":"David Lechner","email":"dlechner@baylibre.com"},"delegate":{"id":161331,"url":"http://patchwork.ozlabs.org/api/1.1/users/161331/?format=json","username":"dlech","first_name":"David","last_name":"Lechner","email":"dlechner@baylibre.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260406-mtk-spi-nor-improvements-v1-3-66f675cbbd3e@baylibre.com/mbox/","series":[{"id":498893,"url":"http://patchwork.ozlabs.org/api/1.1/series/498893/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498893","date":"2026-04-06T20:13:26","name":"spi: mtk_snor: various fixes and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/498893/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220285/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220285/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=i5QdGLTd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"i5QdGLTd\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqLCq0x3Qz1y2d\n\tfor ; Tue, 07 Apr 2026 06:15:03 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 021BF84101;\n\tMon, 6 Apr 2026 22:14:47 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 644C783FA3; Mon, 6 Apr 2026 22:14:45 +0200 (CEST)","from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com\n [IPv6:2001:4860:4864:20::2b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EA92183936\n for ; Mon, 6 Apr 2026 22:14:35 +0200 (CEST)","by mail-oa1-x2b.google.com with SMTP id\n 586e51a60fabf-40946982a78so1300313fac.2\n for ; Mon, 06 Apr 2026 13:14:35 -0700 (PDT)","from [127.0.1.1] ([2600:8803:e7e4:500:90d7:b13f:c53:8ca3])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-68597f6c7bdsm2642044eaf.3.2026.04.06.13.14.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 13:14:34 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775506475;\n x=1776111275;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=ImF7ETlJ17SJOnDKQIoOd1dK414rrbCe3DpDaDCBbnM=;\n b=i5QdGLTdrEHGU85ncLcWnwG9+Uyc/4PdjITVLZb2NbgP6JydpSUTWgTGhSJIqeI3vy\n CmzJ8aR6ZLArE8f41xEILKMF4yyBoYffaquWmiBarkkJe/kVlbfH74eEpUbJ9V5dA9ZA\n dkGUO2GFiyGx6RE6Q3MhdyURaLu7vMon4v+R9sCHM558cvPPr2qsVVU59kck6x5k4ZAY\n 75TTuAh2G6tP5cWiG+Xu5INNMOdQtx4xfBTn9wVsBAUIA64BqS9XG9hE2NJ27NOa3rsI\n wCa1u6ui7IyKzOXv3KIGh6ipNFWYZqNXyf0NdgG1M4KmSvj5OYx1q6fCydcWuIeBvyx3\n dIqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775506475; x=1776111275;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=ImF7ETlJ17SJOnDKQIoOd1dK414rrbCe3DpDaDCBbnM=;\n b=X9jsu/T7TCCXVrYu8bO94IRSkK5eqiQB9bvKIWr/RTuFdhOCOUWyFp3yqsPX7yyDiK\n inXHhpl6h/PFkd0+XWTDWAASAyPmSZoBMzEHR+wa0IHtczt+Yd8DWT2tsblYyc6DAJfE\n yCUo0mwG62oFfvWnvKNLbFENoZ0z6J82+lBZkHj7kx4qN6PGiwZ5y2pJjGucIxFBssd2\n Do8W4a9VVczRHW/YTMclLqyPzTFg26tMgnwePfH8XPJmaTpJ10rFFpRf8drSYmZru9np\n qek7lei+4aJpg0aJMjzfTEzAqq/0oO/BxdV7ATUY/V1O4hb4n4m7a/NEv/6ZaDQgKDE4\n /Ivw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUHjeSbBXsl35vKV3NvWkTOmuawEVsS5uQD9du1yjzCxHPRMK07n5royagqiQX1E/GaKMQ8Nq8=@lists.denx.de","X-Gm-Message-State":"AOJu0YxhALB8JqZpANAdg6bEqzF8rQLBporJY746zJlQnM6bphb+7rCl\n 744GKAGpIl1ok46P6x09KWFQxaHwxjiQv6kv766N3v+9NaekvzVmIUxX3yqK/yoAg90qZUQ2ZCJ\n dQ7zo","X-Gm-Gg":"AeBDiesiHmBIoJvDnZnO0Tjp7gWGQS+XCrSdeR0kZEUfoVikqwj6Sksju02BSqQw39B\n 4+JCTmZID/jVq4lkWEbRwjpMnfVLU6mAAkLarAiB7Jd2eKMHacz5riZchD+CHLQRAq9UuyI9voR\n wbDiKmwhqG/bg4U3SCBIYuodH9x0XGJ8NQd9GtJD7zGmNkL84LbsjonFOUFQ7n+e9rS2MykR1Bb\n i93OEHz4lNU1MkxLXzMVduk9oiWxCOUiyvN7U9o6MZF12gF6rs6ziLsQ+O8VMNk9pFmHgNU562X\n lCbse8FNkbkKHMbsheDhCOD5sCsSYXbaC3ZPRd4XOJp9IExxsk2Mqb9HTSfcdyQBD2wiijbfTJ9\n l94RAs9Rz0Ua9z6gdVoiuzUoMT4nD/qvlF6fMr9MlOhwhuzf+pIEv/im3tROqPE+Bdsy7GTlFFf\n i48U2Je71p2lyyaaC84avNWsZDmnY=","X-Received":"by 2002:a05:6820:198c:b0:67d:f55b:a992 with SMTP id\n 006d021491bc7-6822152ac2emr7976286eaf.46.1775506474576;\n Mon, 06 Apr 2026 13:14:34 -0700 (PDT)","From":"David Lechner ","Date":"Mon, 06 Apr 2026 15:13:29 -0500","Subject":"[PATCH 3/8] spi: mtk_snor: conditionally copy tx/rx data","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260406-mtk-spi-nor-improvements-v1-3-66f675cbbd3e@baylibre.com>","References":"<20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>","In-Reply-To":"\n <20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>","To":"Ryder Lee , Weijie Gao ,\n Chunfeng Yun ,\n Igor Belwon ,\n GSS_MTK_Uboot_upstream ,\n Tom Rini ","Cc":"Julien Stephan , u-boot@lists.denx.de,\n David Lechner , \"Noah.Shen\" ,\n \"Noah.Shen\" ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1830; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=0GVKm8oGpajxQoyxghfzk4OPul0gB7mx+9rPiJw9bjY=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBp1BP/qFhbnXi6GoeJFQivOFzYGNR9hVZBHv47O\n cQEXEWAl8qJAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCadQT/xYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/AA0MIAJtpunQxr0WujqkcWdJmxXBDHoAcb2Kl7DqwP8S\n nEZ3qTH4XUE4LLSmRAxcXAbKY4eLff3Sx9XRcZCakgzhxFByC5urSa1iDpN1kEgLb9PmXl8QLXU\n c2L4g9RKQYgz57lQvD3X50CEcnYQn/3NuXUYptBcskhGeRVpVRt2my3xhCXwWpjW/kqy/pC6UNa\n 51/fp3ok6x5lGk6qJPb3wDsQemmmRy+qUpbRJA/gZGK0Vx4AJguUVuCynp2M/77CAUT6LBsFjIb\n wkpwvTL5iFQvDvup6gZvbbDRb6I4oWSrWs221d25+KPFUsaxIW20pMBFDbZF7XNLSVZusYR6NCB\n 2C48=","X-Developer-Key":"i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: \"Noah.Shen\" \n\nOnly write out data for OUT command and read in data for IN commands.\n\nSigned-off-by: Noah.Shen \nSigned-off-by: David Lechner \n---\n drivers/spi/mtk_snor.c | 24 ++++++++++++++----------\n 1 file changed, 14 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/spi/mtk_snor.c b/drivers/spi/mtk_snor.c\nindex 0ff4a8b23d5..674e723db01 100644\n--- a/drivers/spi/mtk_snor.c\n+++ b/drivers/spi/mtk_snor.c\n@@ -415,14 +415,16 @@ static int mtk_snor_cmd_program(struct mtk_snor_priv *priv,\n \t\twriteb(val, reg);\n \t}\n \n-\tfor (i = 0; i < op->dummy.nbytes; i++, reg_offset--) {\n-\t\treg = priv->base + MTK_NOR_REG_PRGDATA(reg_offset);\n-\t\twriteb(0, reg);\n-\t}\n+\tif (op->data.dir == SPI_MEM_DATA_OUT) {\n+\t\tfor (i = 0; i < op->dummy.nbytes; i++, reg_offset--) {\n+\t\t\treg = priv->base + MTK_NOR_REG_PRGDATA(reg_offset);\n+\t\t\twriteb(0, reg);\n+\t\t}\n \n-\tfor (i = 0; i < op->data.nbytes; i++, reg_offset--) {\n-\t\treg = priv->base + MTK_NOR_REG_PRGDATA(reg_offset);\n-\t\twriteb(((const u8 *)(op->data.buf.out))[i], reg);\n+\t\tfor (i = 0; i < op->data.nbytes; i++, reg_offset--) {\n+\t\t\treg = priv->base + MTK_NOR_REG_PRGDATA(reg_offset);\n+\t\t\twriteb(((const u8 *)(op->data.buf.out))[i], reg);\n+\t\t}\n \t}\n \n \tfor (; reg_offset >= 0; reg_offset--) {\n@@ -437,9 +439,11 @@ static int mtk_snor_cmd_program(struct mtk_snor_priv *priv,\n \n \t/* fetch read data */\n \treg_offset = 0;\n-\tfor (i = op->data.nbytes - 1; i >= 0; i--, reg_offset++) {\n-\t\treg = priv->base + MTK_NOR_REG_SHIFT(reg_offset);\n-\t\t((u8 *)(op->data.buf.in))[i] = readb(reg);\n+\tif (op->data.dir == SPI_MEM_DATA_IN) {\n+\t\tfor (i = op->data.nbytes - 1; i >= 0; i--, reg_offset++) {\n+\t\t\treg = priv->base + MTK_NOR_REG_SHIFT(reg_offset);\n+\t\t\t((u8 *)(op->data.buf.in))[i] = readb(reg);\n+\t\t}\n \t}\n \n \treturn 0;\n","prefixes":["3/8"]}