{"id":2220284,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220284/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260406-mtk-spi-nor-improvements-v1-1-66f675cbbd3e@baylibre.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260406-mtk-spi-nor-improvements-v1-1-66f675cbbd3e@baylibre.com>","date":"2026-04-06T20:13:27","name":"[1/8] spi: mtk_snor: clean up comments","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ab1e4c5324934bc06caea84e11168c6f880add0b","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/1.1/people/87228/?format=json","name":"David Lechner","email":"dlechner@baylibre.com"},"delegate":{"id":161331,"url":"http://patchwork.ozlabs.org/api/1.1/users/161331/?format=json","username":"dlech","first_name":"David","last_name":"Lechner","email":"dlechner@baylibre.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260406-mtk-spi-nor-improvements-v1-1-66f675cbbd3e@baylibre.com/mbox/","series":[{"id":498893,"url":"http://patchwork.ozlabs.org/api/1.1/series/498893/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498893","date":"2026-04-06T20:13:26","name":"spi: mtk_snor: various fixes and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/498893/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220284/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220284/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=R1Evhtsk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"R1Evhtsk\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqLCg0Thfz1y2d\n\tfor ; Tue, 07 Apr 2026 06:14:55 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EA5B683E36;\n\tMon, 6 Apr 2026 22:14:46 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 38C28840BE; Mon, 6 Apr 2026 22:14:40 +0200 (CEST)","from mail-ot1-x331.google.com (mail-ot1-x331.google.com\n [IPv6:2607:f8b0:4864:20::331])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2841183F98\n for ; Mon, 6 Apr 2026 22:14:34 +0200 (CEST)","by mail-ot1-x331.google.com with SMTP id\n 46e09a7af769-7dbb89ab229so3005104a34.1\n for ; Mon, 06 Apr 2026 13:14:34 -0700 (PDT)","from [127.0.1.1] ([2600:8803:e7e4:500:90d7:b13f:c53:8ca3])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-68597f6c7bdsm2642044eaf.3.2026.04.06.13.14.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 13:14:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775506473;\n x=1776111273;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=+h7lhIpBgiiFE6Z5wj/ru8J/4UP+A7QCgf93BchKfxc=;\n b=R1Evhtsk1DAzx1VAgUIhtT+LhepLjKar8ZXunN+t/ljQ2s3/pI/UHkqoChCUrOHfSs\n yWfCOkUl3nzPwIk9BqLdmlDF4wt5E8jxRnWUYGZ2c3fUZLeyPQ0K7NVAYP3s8h+u/wUq\n aFodXYrtTH5JuKeElBhtpCOYmSHdOvtforRQsR1mufYAui+3wDUpS1dFP2+oSz+EEyUq\n zt+4aKT6V8Zr/YQf1tYm1x9fW/hd8nTEY0yrlJ+6XezWgohNVHsdvrNcmhr3X6teLCIw\n dTA/PKayQqhUkygHJiVGJrb3/McjdUge9XO/tZsrX10NQLyquAGYtO579Qgf9uHNrX76\n GYEA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775506473; x=1776111273;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=+h7lhIpBgiiFE6Z5wj/ru8J/4UP+A7QCgf93BchKfxc=;\n b=nwg7qOTvAPCmQraM7i/zPn/OUtPd4ahTliiwwhgA9TDbS/zQZcUVDKEZUuMzY54owU\n zOnkADfcCATPX0r2TN5XbPbzgJsqyunMuPklGjyaQC16A71LzI2uvetOFAuy8mi8VcoV\n Ra5FX2J/fr5fqgJt7LaouvxY47Eu1C4zXxorvHCcJ4AyD1C/S9NyL6mpevacgjamYjTO\n hN8bgstdsks8ev1TjvOTAiAlHYBNDriQQOvVBTCDyOHQDO9xrFNtKu2mRKXzKbUMSuvK\n B7HtctwHFH4KTPi9n3hamL5mmrkK92Lhdmz17he3vLfdLq6m4Yk9aMprmA9Ek2JmB0LO\n Sgfg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUjhaRNTBGj8Js5HqNgOwiiKuAMMnrm6dI8o2crWvqveRd3LWguyWNIDLpQC75JLrgWpBFAyw8=@lists.denx.de","X-Gm-Message-State":"AOJu0YxSLAZOs7q0C+fJASRp06gAMTp3o6n/riPYll2+8DcRIiFhcIFg\n cGaX1NjuoUHha6pTjZj3qJaEroVA0WnWOurJpMGP1UYBKO/Lx0jxFMiO8TkgSgqsp7iox04DQSM\n gqcuQ","X-Gm-Gg":"AeBDiesVyuVzByMq8JZIZqD1jAWi5NS2h2jNWPHEtdR0cwDqDn/j2uD4uCTxaG4zoC7\n O/PAWjzKdE9aimr8fFstwvo2md77K5cycaFVdPC4KH6gf7CJgETrmKIFI8h1Eo8c4CoHFjr+Iz/\n ir2o2DClTjkUjiqebmUspLRCHMkCJOTwjz60fQEn2WJpMHvMBUm11LRo95M1ypTvRRlNXVkY7Ub\n NYCtjuXFLBHez97HDKMmLAzblY3lJjH5jFX/r6g9jDPUp/ZSndoPCI3HQvMIFWRuzmU99a9GjvI\n pZu+wNoP/cdqocM7f7JTuP3TyUMZbZod6lI7VueU+4uIl76WOYV3/wf5oxTpW2pFKNYuZPheAdb\n KFWE9D0iu668WNFyfxpHoqRF2BrFNwrClpIxwwGV7H/n73J+1kYGzK6O4srLoSukqpYKthy6iBv\n p1Vj8vATPoioL2BpfHvtfVVcicfQM=","X-Received":"by 2002:a05:6820:168d:b0:680:aa7c:ac0c with SMTP id\n 006d021491bc7-6821f487dddmr8068095eaf.43.1775506472799;\n Mon, 06 Apr 2026 13:14:32 -0700 (PDT)","From":"David Lechner ","Date":"Mon, 06 Apr 2026 15:13:27 -0500","Subject":"[PATCH 1/8] spi: mtk_snor: clean up comments","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260406-mtk-spi-nor-improvements-v1-1-66f675cbbd3e@baylibre.com>","References":"<20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>","In-Reply-To":"\n <20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>","To":"Ryder Lee , Weijie Gao ,\n Chunfeng Yun ,\n Igor Belwon ,\n GSS_MTK_Uboot_upstream ,\n Tom Rini ","Cc":"Julien Stephan , u-boot@lists.denx.de,\n David Lechner , \"Noah.Shen\" ,\n \"Noah.Shen\" ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3605; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=7FKiLIsWrE5M09dO22Anx5t9LOBM17EPAAsIQzZDDEc=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBp1BPyJBWwGe/4nIWzzzl/rCs/nroBfkTu+B1vh\n TrtAnuFt+SJAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCadQT8hYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/A7VIIAIysvkIFVIaj4zs8CGxqtNIihbxUMe4JsW1v7x9\n S5NAAY6b8JsFHhQl+Lk2Z0p0TMNoBss5BPSRsmXqQ896EhID66eE47K9lPRxAmIROdL/xeL1gbv\n ea/E3RQKvz4PbiZHJ/rve6w7PJ4BGl+Y7IVWoUs8Bzcw93M8JXM7sR2zkW1XfXPvuwmOW7g4Ion\n Ckv439HIUq20MM2VmB0fjJgTx0Tb/c2CzJdGSGMI+oP8wj5tD55bbSFgxyBOoJXf5eeiKz8skHT\n /ii/DsQPe/5qqrA3p3JHKmeZZUB9Adb7jXy1vhdAA7wvHfHH/WDbkQbYsH1+GXZta9rkrAdKLzX\n v9mI=","X-Developer-Key":"i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: \"Noah.Shen\" \n\nAvoid use of C++-style comments and fix multi-line comment style.\n\nSigned-off-by: Noah.Shen \nSigned-off-by: David Lechner \n---\n drivers/spi/mtk_snor.c | 35 +++++++++++++++++++----------------\n 1 file changed, 19 insertions(+), 16 deletions(-)","diff":"diff --git a/drivers/spi/mtk_snor.c b/drivers/spi/mtk_snor.c\nindex f202b2f49f5..eb36c9dd5e8 100644\n--- a/drivers/spi/mtk_snor.c\n+++ b/drivers/spi/mtk_snor.c\n@@ -1,10 +1,11 @@\n // SPDX-License-Identifier: GPL-2.0\n-//\n-// Mediatek SPI-NOR controller driver\n-//\n-// Copyright (C) 2020 SkyLake Huang \n-//\n-// Some parts are based on drivers/spi/spi-mtk-nor.c of linux version\n+/*\n+ * Mediatek SPI-NOR controller driver\n+ *\n+ * Copyright (C) 2020 SkyLake Huang \n+ *\n+ * Some parts are based on drivers/spi/spi-mtk-nor.c of linux version\n+ */\n \n #include \n #include \n@@ -89,13 +90,13 @@\n #define MTK_NOR_REG_DMA_END_DADR 0x724\n \n #define MTK_NOR_PRG_MAX_SIZE 6\n-// Reading DMA src/dst addresses have to be 16-byte aligned\n+/* Reading DMA src/dst addresses have to be 16-byte aligned */\n #define MTK_NOR_DMA_ALIGN 16\n #define MTK_NOR_DMA_ALIGN_MASK (MTK_NOR_DMA_ALIGN - 1)\n-// and we allocate a bounce buffer if destination address isn't aligned.\n+/* and we allocate a bounce buffer if destination address isn't aligned. */\n #define MTK_NOR_BOUNCE_BUF_SIZE PAGE_SIZE\n \n-// Buffered page program can do one 128-byte transfer\n+/* Buffered page program can do one 128-byte transfer */\n #define MTK_NOR_PP_SIZE 128\n \n #define CLK_TO_US(priv, clkcnt) DIV_ROUND_UP(clkcnt, (priv)->spi_freq / 1000000)\n@@ -168,8 +169,8 @@ static int mtk_snor_adjust_op_size(struct spi_slave *slave,\n \t\treturn 0;\n \n \tif (op->addr.nbytes == 3 || op->addr.nbytes == 4) {\n-\t\tif (op->data.dir == SPI_MEM_DATA_IN) { //&&\n-\t\t\t// limit size to prevent timeout calculation overflow\n+\t\tif (op->data.dir == SPI_MEM_DATA_IN) {\n+\t\t\t/* limit size to prevent timeout calculation overflow */\n \t\t\tif (op->data.nbytes > 0x400000)\n \t\t\t\top->data.nbytes = 0x400000;\n \t\t\tif (op->addr.val & MTK_NOR_DMA_ALIGN_MASK ||\n@@ -496,7 +497,8 @@ static int mtk_snor_probe(struct udevice *bus)\n \tpriv->spi_freq = clk_get_rate(&priv->spi_clk);\n \tprintf(\"spi frequency: %d Hz\\n\", priv->spi_freq);\n \n-\t/* With this setting, we issue one command at a time to\n+\t/*\n+\t * With this setting, we issue one command at a time to\n \t * accommodate to SPI-mem framework.\n \t */\n \twritel(MTK_NOR_ENABLE_SF_CMD, priv->base + MTK_NOR_REG_WP);\n@@ -504,7 +506,8 @@ static int mtk_snor_probe(struct udevice *bus)\n \tmtk_snor_rmw(priv, MTK_NOR_REG_CFG3,\n \t\t MTK_NOR_DISABLE_WREN | MTK_NOR_DISABLE_SR_POLL, 0);\n \n-\t/* Unlock all blocks using write status command.\n+\t/*\n+\t * Unlock all blocks using write status command.\n \t * SPI-MEM hasn't implemented unlock procedure on MXIC devices.\n \t * We may remove this later.\n \t */\n@@ -521,7 +524,8 @@ static int mtk_snor_probe(struct udevice *bus)\n \n static int mtk_snor_set_speed(struct udevice *bus, uint speed)\n {\n-\t/* MTK's SNOR controller does not have a bus clock divider.\n+\t/*\n+\t * MTK's SNOR controller does not have a bus clock divider.\n \t * We setup maximum bus clock in dts.\n \t */\n \n@@ -530,8 +534,7 @@ static int mtk_snor_set_speed(struct udevice *bus, uint speed)\n \n static int mtk_snor_set_mode(struct udevice *bus, uint mode)\n {\n-\t/* We set up mode later for each transmission.\n-\t */\n+\t/* We set up mode later for each transmission. */\n \treturn 0;\n }\n \n","prefixes":["1/8"]}