{"id":2220153,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220153/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260406142411.2992618-3-daniel@thingy.jp/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260406142411.2992618-3-daniel@thingy.jp>","date":"2026-04-06T14:24:08","name":"[v2,2/5] m68k: Fix writew(), writel(), readw(), readl() endianness","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"56624647c13d5660b99f596c53ade1846652c5a8","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/1.1/people/85408/?format=json","name":"Daniel Palmer","email":"daniel@thingy.jp"},"delegate":{"id":14103,"url":"http://patchwork.ozlabs.org/api/1.1/users/14103/?format=json","username":"spectrum","first_name":"Angelo","last_name":"Dureghello","email":"sysamfw@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260406142411.2992618-3-daniel@thingy.jp/mbox/","series":[{"id":498861,"url":"http://patchwork.ozlabs.org/api/1.1/series/498861/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498861","date":"2026-04-06T14:24:06","name":"Add virtio-mmio support to m68k virt machine","version":2,"mbox":"http://patchwork.ozlabs.org/series/498861/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220153/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220153/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=jvlnlxsA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"jvlnlxsA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBRr3QXHz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 00:24:56 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9EC158406D;\n\tMon,  6 Apr 2026 16:24:35 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 2A8F38406D; Mon,  6 Apr 2026 16:24:35 +0200 (CEST)","from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com\n [IPv6:2607:f8b0:4864:20::62c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 00EE18341A\n for <u-boot@lists.denx.de>; Mon,  6 Apr 2026 16:24:33 +0200 (CEST)","by mail-pl1-x62c.google.com with SMTP id\n d9443c01a7336-2b0afa0210bso19374745ad.2\n for <u-boot@lists.denx.de>; Mon, 06 Apr 2026 07:24:32 -0700 (PDT)","from kinako.work.home.arpa\n (p1866070-ipxg00f01sizuokaden.shizuoka.ocn.ne.jp. [180.1.30.70])\n by smtp.googlemail.com with ESMTPSA id\n d9443c01a7336-2b27478cb4fsm156885295ad.29.2026.04.06.07.24.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 07:24:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1775485471; x=1776090271; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dOI1OYw5L9OgSAUVFCFOz1abNqr83KHrn1G2y294vG0=;\n b=jvlnlxsAac8my78Lq0pezNJx51HRTmaGZ5OSTbnuMLo8klr+x+BH9aUPUIs40A2owm\n rdSaR8+yU84vsDm/g5Q3chTm/MLD0LiJUBeyp0VfU9goL3zxFIusn+4/FR5Xz+ohTvGp\n 6LRSauVB6N1KLHf3my4JkMW17Ujm4sU/waMew=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775485471; x=1776090271;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=dOI1OYw5L9OgSAUVFCFOz1abNqr83KHrn1G2y294vG0=;\n b=RPNWEa8gBpJJgB24OqTv7A1avrY/910hPKGML4vJo4yr3S6UM5IQ5CB4SSXJg+vQES\n ZxNrlqOgBDSujph0nN/A6oFcNEsvsY0r5UZ+Gj6ZtRzoGwqLMCc6kb3jcSYGwvrw9JgG\n i8DftkhFyif1RJTi99fEPqbmdYTKE5gZ3WYMs7KL+jU0QPPvkasxZIHxcp4tDkwSovo3\n e3yOkMdftGW24OGux3R9ixDnk2bnpdJTOeq8pCOzZNLH8dRuDnNlqqD8gHgiDfkNouta\n Jz35FrOPHxPh/gg5Y8WG3vIRvG6jyxy7M4hEo/RXrk5Ejf7UcVikrtdjbbMt61G01paU\n KL6Q==","X-Gm-Message-State":"AOJu0Yx6OCEdmpZ1Wph4F++Z4Ii+ijiuD7eWw6gI76twTtP12M1F4b1c\n GtpmqB1DCRwzOB0sX8Prt+FFuJfm0tqOtvve9Z62TOmXWFfLcQlePzcb7m97MKj9E4M=","X-Gm-Gg":"AeBDieu5eqx9iGXZgfy2Y/NbHmzoOG2d29Vbhh21lpxW9RJDCn2jkOrIgk/5sVhRCBZ\n aw2N8Y9p0O7pBXdi843sNzldpR6ZzZZAGWnBCUiUSDmB/pikx1Lhu97OBKNnk8HLxD8oN9FISKZ\n kVTTRubpCL41HS5dHHlu6ts18qWDbqfItcpj4eGJOKwme35rYfDzPoUbLVSYXYfuTiEfGa6aPiV\n hXvo7L+reDpkQiPImtYqOY/e2Ny793OECYweociLwSViyAzC6j2/1IcpEKMaL5nrZ46b6w7jcQD\n MW19SqY1JyhONiJYXrJWPQT1PrSMZulKYKA2m9hj/Zqcdgkc1gV29MSqk7g8qBISoBlIeO9JWU1\n LmahwHVIi5/GGJq0pRO5Tur2RjhZU6o059+LUYJDYu1M394Py5knCbQ9tf4jblS048kFDr1Hgo/\n eAD2eLOLph7QJVxVoLLMPmLd7U/9nOMivI50VgJQHSF2q7pp9ByFqPcLf1JW4CHUFBlbQqp7w79\n I/kAcAqDJc=","X-Received":"by 2002:a17:903:1a30:b0:2b0:c90f:449b with SMTP id\n d9443c01a7336-2b2817d8a15mr129536815ad.10.1775485471387;\n Mon, 06 Apr 2026 07:24:31 -0700 (PDT)","From":"Daniel Palmer <daniel@thingy.jp>","To":"visitorckw@gmail.com,\n\tangelo@kernel-space.org,\n\tbmeng.cn@gmail.com","Cc":"u-boot@lists.denx.de,\n\tDaniel Palmer <daniel@thingy.jp>","Subject":"[PATCH v2 2/5] m68k: Fix writew(), writel(), readw(),\n readl() endianness","Date":"Mon,  6 Apr 2026 23:24:08 +0900","Message-ID":"<20260406142411.2992618-3-daniel@thingy.jp>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260406142411.2992618-1-daniel@thingy.jp>","References":"<20260406142411.2992618-1-daniel@thingy.jp>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"In Linux these are meant to read a little-endian value and swap\nto the CPU endian.\n\nIn u-boot for m68k this is currently borken and prevents\nvirtio-mmio from functioning.\n\nSigned-off-by: Daniel Palmer <daniel@thingy.jp>\n---\n arch/m68k/include/asm/io.h | 17 +++++------------\n 1 file changed, 5 insertions(+), 12 deletions(-)","diff":"diff --git a/arch/m68k/include/asm/io.h b/arch/m68k/include/asm/io.h\nindex 35ad4a1c0444..f4877b0446cf 100644\n--- a/arch/m68k/include/asm/io.h\n+++ b/arch/m68k/include/asm/io.h\n@@ -24,18 +24,11 @@\n #define __raw_writel(l,addr) ((*(volatile u32 *) (addr)) = (l))\n \n #define readb(addr)\t\tin_8((volatile u8 *)(addr))\n-#define writeb(b,addr)\t\tout_8((volatile u8 *)(addr), (b))\n-#if !defined(__BIG_ENDIAN)\n-#define readw(addr)\t\t(*(volatile u16 *) (addr))\n-#define readl(addr)\t\t(*(volatile u32 *) (addr))\n-#define writew(b,addr)\t\t((*(volatile u16 *) (addr)) = (b))\n-#define writel(b,addr)\t\t((*(volatile u32 *) (addr)) = (b))\n-#else\n-#define readw(addr)\t\tin_be16((volatile u16 *)(addr))\n-#define readl(addr)\t\tin_be32((volatile u32 *)(addr))\n-#define writew(b,addr)\t\tout_be16((volatile u16 *)(addr),(b))\n-#define writel(b,addr)\t\tout_be32((volatile u32 *)(addr),(b))\n-#endif\n+#define writeb(b, addr)\t\tout_8((volatile u8 *)(addr), (b))\n+#define readw(addr)\t\tin_le16((volatile u16 *)(addr))\n+#define readl(addr)\t\tin_le32((volatile u32 *)(addr))\n+#define writew(b, addr)\t\tout_le16((volatile u16 *)(addr), (b))\n+#define writel(b, addr)\t\tout_le32((volatile u32 *)(addr), (b))\n \n /*\n  * The insw/outsw/insl/outsl macros don't do byte-swapping.\n","prefixes":["v2","2/5"]}