{"id":2220145,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220145/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-10-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260406141735.25844-10-armenon@redhat.com>","date":"2026-04-06T14:17:34","name":"[v3,09/10] tpm: Extend TPM TIS buffer size to 8192 bytes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d30b3241f1703569bcf26a30b38bb794e6d43c8f","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.1/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-10-armenon@redhat.com/mbox/","series":[{"id":498860,"url":"http://patchwork.ozlabs.org/api/1.1/series/498860/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498860","date":"2026-04-06T14:17:28","name":"hw/tpm: CRB chunking capability to handle PQC","version":3,"mbox":"http://patchwork.ozlabs.org/series/498860/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220145/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220145/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Cuc6uc26;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=AY6mdoq6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBK710J5z1y2d\n\tfor ; Tue, 07 Apr 2026 00:19:07 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9kn9-000598-68; Mon, 06 Apr 2026 10:19:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9kn8-00058W-0F\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:19:02 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9kn6-0005Fn-2x\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:19:01 -0400","from mail-pl1-f198.google.com (mail-pl1-f198.google.com\n [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-591-v5rrIPv4MceRL9aJKZVDuw-1; Mon, 06 Apr 2026 10:18:58 -0400","by mail-pl1-f198.google.com with SMTP id\n d9443c01a7336-2b24e9b4d82so51142445ad.1\n for ; Mon, 06 Apr 2026 07:18:58 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([152.59.100.84])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27478cb4fsm156732905ad.29.2026.04.06.07.18.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 07:18:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775485139;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=X5BfOb29CchgA3O8cD3d/CWCo4Ox5ZAg0ea68Q66Ig0=;\n b=Cuc6uc261GsJuUWQabYiZQwRZLmXHUmnUeMaQQ1i3U7Je7R06chzsZKoTpJ0Rl/XVcHT/t\n BvWS7Eg5pSmeHMAks2P7ve6nC6dQx3JkoNaNr6MWf1LoH6t/g3Shqn0h+IYeY0aSv0ebKC\n TP93fXSsupwDd0NfLWA/LZva5fIEoKQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775485137; x=1776089937; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=X5BfOb29CchgA3O8cD3d/CWCo4Ox5ZAg0ea68Q66Ig0=;\n b=AY6mdoq6zD71DR9DALychDnXMhF0H5RUmyypL2aJd82CMQmEKJA1J57kSJgGoEcQVF\n sVv3oWRGgV+YMpkQjssEn6qGwdDtl2LhJNHlGqpYTVHY561be8/zziRkcvXFaXIv5cju\n XFNP+kPh3C9cSUrixTlnoUDi3KqVEEBMPo258zIZph2MimfXoyjqs5h8m0NCLb+hogvs\n Bu/e3cB4mUDfooU1ji6yrhaCIhvkbGn6ORtLZMlWvADobsSN/OEyGVbynBZcjxdQAGht\n WOeHR1nfVaV/geN+0GMnTtu1XktWh99SlKmpzQ378BTVPFKtL5hJ0c5rvh7sS1ZCsyxu\n +6MQ=="],"X-MC-Unique":"v5rrIPv4MceRL9aJKZVDuw-1","X-Mimecast-MFC-AGG-ID":"v5rrIPv4MceRL9aJKZVDuw_1775485137","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775485137; x=1776089937;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=X5BfOb29CchgA3O8cD3d/CWCo4Ox5ZAg0ea68Q66Ig0=;\n b=TrWvzaUBdogGhfiwnN6MQox4Fxp4tAQjgQap/vuoqQJXd/g5iiMXE3g+zl1g0l5TA6\n F2YMW5dk1l61Rypnt4h9WdPPCQnlO9gT8EhSBEhLszv7dFz5dWokX6iyZ7tFHd/6CQEI\n j5JQQ/soU3Yn9qWJh1RLct1e6fgsBWsNnGAE+IUSm0xdR9XLLcI6qZ7vLZFmA9kj5Rpz\n MMP+sC9oKYnVkOc2WS3jW6HU2dSMrR3o6birOrjkyVkg54mqjekwab5bU0aCkmK8gwQq\n dksQLqfLyhySzqMsyPSOpj5W2xQpJLHW9Zki+ZgJOJ1obmCfC4cLW1ESPmLoHpO2nVgQ\n G/xA==","X-Gm-Message-State":"AOJu0YxBAf9STpcN6Isjo+dD/4lh7fBagRAdtVhwsoNVTunD30OYbead\n BriigfjBSAkB91rBT+BNcYTdkEp1ezeMwS1SD1JWI8RSD0JKFD17YKAzKpGzK1RFMwyt7Vy4hhf\n ryW0CENgoDyrNGDPIRO9vdJorDberyAODXcvroZ+3T1aSjnd2Sb0QNnDRiWpMux3iGqGc9klFQy\n N2+NzssogNFDrygcH2nQyi7ABxCXkTMwOxiYJSVh0=","X-Gm-Gg":"AeBDievLYpfUhXIGOp20PlXWAHJX/Bwhx5QK01V8nmaJ7YP/S6rLXiP136GOwlOd26R\n jkh5ceyYRwp3eZ1/qe1pJWF20aE3XdHhAC5h8dcQOxzNZVzVfRAfROoatNYWDqqpNJMsFOUXqKF\n F9TxHt2BTrXheNI5+8COOm+Snhs5c+ILdyeDcPpYbkvQ8n+FIElJ2VkuNLAg/G/8iPsCdddwBj3\n bPIoqrZleq230YQIqQZu421bd1RyzQS0XspXyKiT3kPHp18p0OpoodZWXk97xV8WOl0uIc4VCGp\n obujG+Pzut/jqCr9n76WQhooJxTksPXwv+OS7vtGvvKp7smbzXBKONwyNYTijI9PXe0ueG7kWdk\n RsvUX0kgcoAI5OrK2pzeEzx65cLs6iYkCS/mu3KvgdIU4tWporA7D5Sn4cWQ7JH8kqzg=","X-Received":["by 2002:a17:902:f70c:b0:2b0:4fb3:c771 with SMTP id\n d9443c01a7336-2b277d6372emr149470805ad.6.1775485136598;\n Mon, 06 Apr 2026 07:18:56 -0700 (PDT)","by 2002:a17:902:f70c:b0:2b0:4fb3:c771 with SMTP id\n d9443c01a7336-2b277d6372emr149470345ad.6.1775485135989;\n Mon, 06 Apr 2026 07:18:55 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Ani Sinha , Laurent Vivier ,\n Zhao Liu , Stefan Berger ,\n Marcel Apfelbaum ,\n Paolo Bonzini , Fabiano Rosas ,\n marcandre.lureau@redhat.com, \"Michael S. Tsirkin\" ,\n Yanan Wang , Igor Mammedov ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Arun Menon , Stefan Berger ","Subject":"[PATCH v3 09/10] tpm: Extend TPM TIS buffer size to 8192 bytes","Date":"Mon, 6 Apr 2026 19:47:34 +0530","Message-ID":"<20260406141735.25844-10-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260406141735.25844-1-armenon@redhat.com>","References":"<20260406141735.25844-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Stefan Berger \n\nExtend the TIS buffer size to 8192 bytes and store the first 4096 bytes\nusing VMSTATE_PARTIAL_BUFFER and the rest using VMSTATE_BUFFER_START_MIDDLE\nwhen necessary. It is necessary to store the buffer beyond original 4096\nbytes when:\n\n - the user has written more than 4096 bytes to the buffer\n - the TPM 2 response is larger than 4096 bytes\n\nUse the .needed function of the VMStateDescription interface to check\nwhether the bytes in the buffer beyond 4096 bytes needed to be saved.\nThe .pre_save function is called before the .needed function so that we\ncan be sure to have received any response packet from the TPM.\n\nSigned-off-by: Stefan Berger \n[ Arun Menon - Removed WIP tag and TODO for submission ]\nSigned-off-by: Arun Menon \n---\n hw/tpm/tpm_tis.h | 2 ++\n hw/tpm/tpm_tis_common.c | 23 +++++++++++++++++++++++\n hw/tpm/tpm_tis_i2c.c | 24 +++++++++++++++++++++++-\n hw/tpm/tpm_tis_isa.c | 24 +++++++++++++++++++++++-\n hw/tpm/tpm_tis_sysbus.c | 24 +++++++++++++++++++++++-\n 5 files changed, 94 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h\nindex 184632ff66..d35c332287 100644\n--- a/hw/tpm/tpm_tis.h\n+++ b/hw/tpm/tpm_tis.h\n@@ -90,4 +90,6 @@ uint32_t tpm_tis_read_data(TPMState *s, hwaddr addr, unsigned size);\n void tpm_tis_write_data(TPMState *s, hwaddr addr, uint64_t val, uint32_t size);\n uint16_t tpm_tis_get_checksum(TPMState *s);\n \n+bool tpm_tis_ext_buffer_migration_needed(struct TPMState *s);\n+\n #endif /* TPM_TPM_TIS_H */\ndiff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_common.c\nindex f594b15b8a..dffb0a411e 100644\n--- a/hw/tpm/tpm_tis_common.c\n+++ b/hw/tpm/tpm_tis_common.c\n@@ -890,3 +890,26 @@ const VMStateDescription vmstate_locty = {\n }\n };\n \n+bool tpm_tis_ext_buffer_migration_needed(struct TPMState *s)\n+{\n+ if (!TPM_TIS_IS_VALID_LOCTY(s->active_locty)) {\n+ return false;\n+ }\n+\n+ switch (s->loc[s->active_locty].state) {\n+ case TPM_TIS_STATE_IDLE:\n+ case TPM_TIS_STATE_READY:\n+ return false;\n+ case TPM_TIS_STATE_RECEPTION:\n+ return s->rw_offset >= 4096;\n+ case TPM_TIS_STATE_EXECUTION:\n+ /*\n+ * TPM is executing: we cannot know the size of TPM response.\n+ * .pre_save must have been called before (should never get here).\n+ */\n+ return false;\n+ case TPM_TIS_STATE_COMPLETION:\n+ return (tpm_cmd_get_size(&s->buffer) >= 4096);\n+ }\n+ return false;\n+}\ndiff --git a/hw/tpm/tpm_tis_i2c.c b/hw/tpm/tpm_tis_i2c.c\nindex 9f13e0ec12..a01df7e5a0 100644\n--- a/hw/tpm/tpm_tis_i2c.c\n+++ b/hw/tpm/tpm_tis_i2c.c\n@@ -110,13 +110,31 @@ static int tpm_tis_i2c_post_load(void *opaque, int version_id)\n return 0;\n }\n \n+static bool tpm_tis_ext_buffer_migration_needed_i2c(void *opaque)\n+{\n+ TPMStateI2C *i2cst = opaque;\n+\n+ return tpm_tis_ext_buffer_migration_needed(&i2cst->state);\n+}\n+\n+static const VMStateDescription vmstate_tpm_tis_ext_buffer_i2c = {\n+ .name = \"tpm-tis/ext_buffer\",\n+ .version_id = 0,\n+ .needed = tpm_tis_ext_buffer_migration_needed_i2c,\n+ .pre_save = tpm_tis_i2c_pre_save,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_BUFFER_START_MIDDLE(state.buffer, TPMStateI2C, 4096),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n static const VMStateDescription vmstate_tpm_tis_i2c = {\n .name = \"tpm-tis-i2c\",\n .version_id = 0,\n .pre_save = tpm_tis_i2c_pre_save,\n .post_load = tpm_tis_i2c_post_load,\n .fields = (const VMStateField[]) {\n- VMSTATE_BUFFER(state.buffer, TPMStateI2C),\n+ VMSTATE_PARTIAL_BUFFER(state.buffer, TPMStateI2C, 4096),\n VMSTATE_UINT16(state.rw_offset, TPMStateI2C),\n VMSTATE_UINT8(state.active_locty, TPMStateI2C),\n VMSTATE_UINT8(state.aborting_locty, TPMStateI2C),\n@@ -133,6 +151,10 @@ static const VMStateDescription vmstate_tpm_tis_i2c = {\n VMSTATE_UINT8(csum_enable, TPMStateI2C),\n \n VMSTATE_END_OF_LIST()\n+ },\n+ .subsections = (const VMStateDescription *const[]) {\n+ &vmstate_tpm_tis_ext_buffer_i2c,\n+ NULL,\n }\n };\n \ndiff --git a/hw/tpm/tpm_tis_isa.c b/hw/tpm/tpm_tis_isa.c\nindex 61e95434f5..73038f1a10 100644\n--- a/hw/tpm/tpm_tis_isa.c\n+++ b/hw/tpm/tpm_tis_isa.c\n@@ -49,12 +49,30 @@ static int tpm_tis_pre_save_isa(void *opaque)\n return tpm_tis_pre_save(&isadev->state);\n }\n \n+static bool tpm_tis_ext_buffer_migration_needed_isa(void *opaque)\n+{\n+ TPMStateISA *isadev = opaque;\n+\n+ return tpm_tis_ext_buffer_migration_needed(&isadev->state);\n+}\n+\n+static const VMStateDescription vmstate_tpm_tis_ext_buffer_isa = {\n+ .name = \"tpm-tis/ext_buffer\",\n+ .version_id = 0,\n+ .needed = tpm_tis_ext_buffer_migration_needed_isa,\n+ .pre_save = tpm_tis_pre_save_isa,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_BUFFER_START_MIDDLE(state.buffer, TPMStateISA, 4096),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n static const VMStateDescription vmstate_tpm_tis_isa = {\n .name = \"tpm-tis\",\n .version_id = 0,\n .pre_save = tpm_tis_pre_save_isa,\n .fields = (const VMStateField[]) {\n- VMSTATE_BUFFER(state.buffer, TPMStateISA),\n+ VMSTATE_PARTIAL_BUFFER(state.buffer, TPMStateISA, 4096),\n VMSTATE_UINT16(state.rw_offset, TPMStateISA),\n VMSTATE_UINT8(state.active_locty, TPMStateISA),\n VMSTATE_UINT8(state.aborting_locty, TPMStateISA),\n@@ -64,6 +82,10 @@ static const VMStateDescription vmstate_tpm_tis_isa = {\n vmstate_locty, TPMLocality),\n \n VMSTATE_END_OF_LIST()\n+ },\n+ .subsections = (const VMStateDescription *const[]) {\n+ &vmstate_tpm_tis_ext_buffer_isa,\n+ NULL,\n }\n };\n \ndiff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c\nindex e9372e7316..86fc5a592c 100644\n--- a/hw/tpm/tpm_tis_sysbus.c\n+++ b/hw/tpm/tpm_tis_sysbus.c\n@@ -48,12 +48,30 @@ static int tpm_tis_pre_save_sysbus(void *opaque)\n return tpm_tis_pre_save(&sbdev->state);\n }\n \n+static bool tpm_tis_ext_buffer_migration_needed_sysbus(void *opaque)\n+{\n+ TPMStateSysBus *sbdev = opaque;\n+\n+ return tpm_tis_ext_buffer_migration_needed(&sbdev->state);\n+}\n+\n+static const VMStateDescription vmstate_tpm_tis_ext_buffer_sysbus = {\n+ .name = \"tpm-tis/ext_buffer\",\n+ .version_id = 0,\n+ .needed = tpm_tis_ext_buffer_migration_needed_sysbus,\n+ .pre_save = tpm_tis_pre_save_sysbus,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_BUFFER_START_MIDDLE(state.buffer, TPMStateSysBus, 4096),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n static const VMStateDescription vmstate_tpm_tis_sysbus = {\n .name = \"tpm-tis\",\n .version_id = 0,\n .pre_save = tpm_tis_pre_save_sysbus,\n .fields = (const VMStateField[]) {\n- VMSTATE_BUFFER(state.buffer, TPMStateSysBus),\n+ VMSTATE_PARTIAL_BUFFER(state.buffer, TPMStateSysBus, 4096),\n VMSTATE_UINT16(state.rw_offset, TPMStateSysBus),\n VMSTATE_UINT8(state.active_locty, TPMStateSysBus),\n VMSTATE_UINT8(state.aborting_locty, TPMStateSysBus),\n@@ -63,6 +81,10 @@ static const VMStateDescription vmstate_tpm_tis_sysbus = {\n 0, vmstate_locty, TPMLocality),\n \n VMSTATE_END_OF_LIST()\n+ },\n+ .subsections = (const VMStateDescription *const[]) {\n+ &vmstate_tpm_tis_ext_buffer_sysbus,\n+ NULL,\n }\n };\n \n","prefixes":["v3","09/10"]}