{"id":2220141,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220141/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-3-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260406141735.25844-3-armenon@redhat.com>","date":"2026-04-06T14:17:27","name":"[v3,02/10] hw/tpm: Refactor CRB_CTRL_START register access","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8d5cb0685490287ba9f8b3eae0e3e56bce630a55","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.1/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-3-armenon@redhat.com/mbox/","series":[{"id":498860,"url":"http://patchwork.ozlabs.org/api/1.1/series/498860/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498860","date":"2026-04-06T14:17:28","name":"hw/tpm: CRB chunking capability to handle PQC","version":3,"mbox":"http://patchwork.ozlabs.org/series/498860/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220141/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220141/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RsaOQX/a;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Di7eiQl8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBJy39lNz1y2d\n\tfor ; Tue, 07 Apr 2026 00:18:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9kmF-0003tG-QJ; Mon, 06 Apr 2026 10:18:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9kmE-0003t1-Fn\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:18:06 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9kmD-0004zl-0q\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:18:06 -0400","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-122-Y66hmqORO8eoDzLycXi9cw-1; Mon, 06 Apr 2026 10:18:03 -0400","by mail-pl1-f197.google.com with SMTP id\n d9443c01a7336-2b250d3699aso98568845ad.2\n for ; Mon, 06 Apr 2026 07:18:02 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([152.59.100.84])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27478cb4fsm156732905ad.29.2026.04.06.07.17.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 07:18:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775485084;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9wWSyFDxGNwzId7cZzvHY1e6vgl0Aec6Tzqgrzda1Nw=;\n b=RsaOQX/ab5Pl9aISHO0VYimJx7SNc4KhXdW/snzvj2TKeWmcrxAyIsbPLeYrpWP79S2MXr\n T+ozSpDDo1t3g3/5JeEUUCz8mf102j1YUlLYZY6ItWvQetmcKF18lPaNYurZvGVA98DRqg\n RshvV5Wr+KHVJoUsn0mZNnNHK8NhjXM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775485082; x=1776089882; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9wWSyFDxGNwzId7cZzvHY1e6vgl0Aec6Tzqgrzda1Nw=;\n b=Di7eiQl80DYVo4dZyJJDxh5viHCF22IwFXqqr9/MZgWZ9NPki0oikOyHxi2yF0SE0V\n cE2IUdjRSfxFSmqVFFmf9Fc4nyEwqLv5Cdbp9Bo9uqq3mWkoOXj4r2Cb57vrUmvsV8eS\n 8eyrI6Z0lMmhDwTejZtCnxuMZZpOX7vLR3+JvLomz6NbyVPmWAwT4k8nkA/s0gmyJfAi\n WVCZlC4qt8WoD/CRTSlcHwYRNcYOzpWVt1VCWdik0IV34OUFqrRrefNd5m0v5cwj2Y2O\n R3/eOdrKk34Qs77uMg51Rvx8PSZf+eVz8G//rUonKMKfwLb1lwcCEO0RwhwbSYr0weA7\n UX/A=="],"X-MC-Unique":"Y66hmqORO8eoDzLycXi9cw-1","X-Mimecast-MFC-AGG-ID":"Y66hmqORO8eoDzLycXi9cw_1775485082","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775485082; x=1776089882;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9wWSyFDxGNwzId7cZzvHY1e6vgl0Aec6Tzqgrzda1Nw=;\n b=CCmtP6HDmNLvYDfULny6bgQXsypzc+Z2NyIj7ejyX6Ry8asoeBP7XwPambMRIX555l\n UJm34+43Ic4qtwzS2Y4qbxWRx7MHvop3KuvFhx2Z8fN7P8ZXHFnX6opiMmvsSgysnF/9\n RtcSPriQO8x5SP9MXccwk81ip87of8IxGaouPXt/DlRWeMu6Rudt1kBy1WSRd2PNY6f3\n rWa6yxI48ly8jPzmZEWD+LC907bUa2xTVqPdnIpnJ4KWnkx7FH/lm2QLB4po6hSaG5pe\n 3tBD241d7uuNixdov1vreYVuZX0SZSrYwh+g7eeoL+AYJIGewfSE8AMq9dygcob0GoD9\n Fzyw==","X-Gm-Message-State":"AOJu0Yxe4ISL5tzaynsgK8jQ3it4COSYgoEgPVecTksm7Oub9FSPVvC0\n JRk0N+Gy+T+RFcNm0x54Z8xbSoPbIb39eX3BFEc5D+t6mzWjiFXkCqNq65xl0dwKq70srTlzGw/\n IKaqpG+jdA83Y1pCp5l1pwc47O1n26vH2cY9IPlC1bYeRpQ5Qq+VwuyuOLBtDUYqOlyTFHWjaWe\n M6xH1/oHGJ8hwdIxSwRcsZbFFRBc+KgV87AAnd0HQ=","X-Gm-Gg":"AeBDiet67jngJR2oa31oLZ1/HEbTKl8OrxXTUcJ37szgrAfdEVFDlgl1ja//aCjRK7H\n AE8wbqRLNf3/6NSq/RM3s4bLXnHB5AdrCw/1beHyLS/k7Q7hoSnoIKTQgTfkEyA1vGPgcoJXFbp\n uHArBA8akX9+6SlADbZkhPGAaekkv+hMpkATu9CavIe5P1WOgZhCuhFUOSBEv5p2hXGei3oTI3B\n sViQjmErAevRPH6qh+w7P+lw7AOV0PU9oqMH/DZcdVXWzglTi0s2xoD308ewEZmM7MFp1spZwvh\n 8EomHiSFqCN6KhbpOHMA16M2A6MqqMkFw8gXfADTr4Ft++XyU35oUp8wgjOC3WAHW4e1BAQ1FOJ\n NAoiFt61eqY94SkVufIKDfb7cOiq+TXIpOyKqHX1PB3kfdbDmW4HzKyLryBK1yXDFAvk=","X-Received":["by 2002:a17:903:32cd:b0:2b2:51e8:2c20 with SMTP id\n d9443c01a7336-2b281760833mr134315345ad.21.1775485081805;\n Mon, 06 Apr 2026 07:18:01 -0700 (PDT)","by 2002:a17:903:32cd:b0:2b2:51e8:2c20 with SMTP id\n d9443c01a7336-2b281760833mr134314845ad.21.1775485081217;\n Mon, 06 Apr 2026 07:18:01 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Ani Sinha , Laurent Vivier ,\n Zhao Liu , Stefan Berger ,\n Marcel Apfelbaum ,\n Paolo Bonzini , Fabiano Rosas ,\n marcandre.lureau@redhat.com, \"Michael S. Tsirkin\" ,\n Yanan Wang , Igor Mammedov ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Arun Menon , Stefan Berger ","Subject":"[PATCH v3 02/10] hw/tpm: Refactor CRB_CTRL_START register access","Date":"Mon, 6 Apr 2026 19:47:27 +0530","Message-ID":"<20260406141735.25844-3-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260406141735.25844-1-armenon@redhat.com>","References":"<20260406141735.25844-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\nReplace manual bitwise operations with ARRAY_FIELD_DP32 macros\nNo functional changes.\n\nSigned-off-by: Arun Menon \nReviewed-by: Stefan Berger \n---\n hw/tpm/tpm_crb.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex 0a1c7ecdc6..bc55908786 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -145,7 +145,7 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n tpm_crb_get_active_locty(s) == locty) {\n void *mem = memory_region_get_ram_ptr(&s->cmdmem);\n \n- s->regs[R_CRB_CTRL_START] |= CRB_START_INVOKE;\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 1);\n s->cmd = (TPMBackendCmd) {\n .in = mem,\n .in_len = MIN(tpm_cmd_get_size(mem), s->be_buffer_size),\n@@ -194,7 +194,7 @@ static void tpm_crb_request_completed(TPMIf *ti, int ret)\n {\n CRBState *s = CRB(ti);\n \n- s->regs[R_CRB_CTRL_START] &= ~CRB_START_INVOKE;\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 0);\n if (ret != 0) {\n ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,\n tpmSts, 1); /* fatal error */\n","prefixes":["v3","02/10"]}