{"id":2220140,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2220140/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-4-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260406141735.25844-4-armenon@redhat.com>","date":"2026-04-06T14:17:28","name":"[v3,03/10] hw/tpm: Add internal buffer state for chunking","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ee13969c2f1368087985f4a0e165801e47b6068c","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.1/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-4-armenon@redhat.com/mbox/","series":[{"id":498860,"url":"http://patchwork.ozlabs.org/api/1.1/series/498860/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498860","date":"2026-04-06T14:17:28","name":"hw/tpm: CRB chunking capability to handle PQC","version":3,"mbox":"http://patchwork.ozlabs.org/series/498860/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220140/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220140/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=g3Q1LunX;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=GnEd6Uae;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBJy3DpWz1yGn\n\tfor ; Tue, 07 Apr 2026 00:18:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9kmN-0003tu-Ev; Mon, 06 Apr 2026 10:18:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9kmM-0003te-5l\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:18:14 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9kmK-00053X-L5\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:18:13 -0400","from mail-pl1-f198.google.com (mail-pl1-f198.google.com\n [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-84-B_zLYUWuONyMW_wZAikp8g-1; Mon, 06 Apr 2026 10:18:11 -0400","by mail-pl1-f198.google.com with SMTP id\n d9443c01a7336-2adef9d486bso62579045ad.2\n for ; Mon, 06 Apr 2026 07:18:10 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([152.59.100.84])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27478cb4fsm156732905ad.29.2026.04.06.07.18.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 07:18:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775485092;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jLLYAnrleD9NK24SJY9DaTHQk/BqQZ5iTJMqFUtwcT0=;\n b=g3Q1LunXN/P19YzVOWYSUUY2Z4AkyzQ/TaKXNPrwhcIEFMKGkVi2qvh6/xNrghvSjCSd/5\n dqa0K9SS/c4Kizb2bCpvaiodBFc0YhLpuprXJUBd5qPvu0HtR/KxbsYbsjbb3FIrSvPt4/\n +sRrmy/izXzuv812L98APvKKgkOnbnI=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775485090; x=1776089890; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jLLYAnrleD9NK24SJY9DaTHQk/BqQZ5iTJMqFUtwcT0=;\n b=GnEd6UaeJV2bJWqEFxZtfv/u86u/kkeFE/1+YWj8yjeP72fHTuzpe6XSEHcm1YDNpK\n xkc7rN3USfHPV2WD25mPPPpu2rGBB4zE88akP7e5/MKFhHlnIvn6WsoV0PNa7baTNuYx\n a9xj8wnWrVDQazx8sN874Xz8fuDHt+SlW8d47GWRTiHchEktd0NBL5dVYEqzmqtUtg5q\n tCtvxh5DJsXlsXzjyFOsixpizpIqI6Zv1w6oB79u+54f3iXYJv2x2ZpzTbALTVLRFA4I\n wDYVeKlPfFPqiJglKeZcikLXXgPmk5uknJUb+LXX1uOTPdYRgPD+CgOnafoquSZigfY7\n q1Eg=="],"X-MC-Unique":"B_zLYUWuONyMW_wZAikp8g-1","X-Mimecast-MFC-AGG-ID":"B_zLYUWuONyMW_wZAikp8g_1775485090","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775485090; x=1776089890;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=jLLYAnrleD9NK24SJY9DaTHQk/BqQZ5iTJMqFUtwcT0=;\n b=G63hV0+VW4jjc8ARNKKgrji7r9KJr+aGVln3THlhpHw/vLd25dWzh0hZq2PSqOoPW4\n AZoiTlmzKxABpYFvgDLakfsHcd955dRWCQkk+EAl+4jf+Uej/un9azn16/uTlAlWD1N1\n AopvkfYQMbNwd/349nkm9M9+fVyftziAk75M986E2ArVsQJ8JqxogzVypFV4f86lmxKE\n pjTey03FlsxzI5fkJZF388J8LDpUDn911dodyGCUWz5K3rv/jCKwkUVfDlWeWJFECK7S\n mLzWg+xyvm/KJiLVk3OiWzxOIQ3ngZs2A5wfdBNWX31BJoAz5Y37wikZO8kOy0kuH3AI\n Tibg==","X-Gm-Message-State":"AOJu0YxUiY9f9rJJtLsCKZoDmHFJEDy/kucu20toNUtrqDSwiy5QJlcQ\n /LLH0Nf9t3FkbhyLZi7wrnoFrSo3nHzgI5FyKSl5p480ymRi2fs8M2c0cHgkBMMVW68bR10BHBi\n tbIMr9tqr6tB6FvGKa+dVRR7aKo5+Bp0Nlqr7gLnpX5i25/8/4yEwUVopbZaEMlTfG2jkswYPfO\n e5RMI7eMW/9GeE2ScddHpmIpyFBZ7l10siGxS3PaI=","X-Gm-Gg":"AeBDieuRhRUL62/5jzaNOM16Kw8Trf1nEYAQFK5gFq9axaNVNSy46mcxEIoh4lsuTIP\n ywUWdCO+kgcLMpJxaPlNK4TVectV9f/679EVG/uIRdwjJBIEBLSvK+ws495edjqu2uDEGR5bdWl\n 9hhiaAQL9K20DCjp3mPD5zpGCRCvnLGuVLIQoBBc3wMB8Ui5m9tp+lv7Te3lZXcqv27dXsCGTlt\n niuHrXS0bvODTxCHV0pqSzVC9Vx1gGMTP4D0LqS11ZI/Yan3JKf2cDdWw6x0oFvA8KtKFmCyKYj\n tjfeTEXqK2aqkdcsyoDd0KnF+icR190vGtUAWH40ttjiQp4eet0rH0CNMSHCJWfthWJwQNINPA/\n ZdCOy0J8yWqTgmxWzwrYDtFqScMDvz09/37IN7NyqygFILzAWTCoJfTEqDIzzQ+1KDvw=","X-Received":["by 2002:a17:902:d50e:b0:2b0:5520:f497 with SMTP id\n d9443c01a7336-2b28164ceeemr137327305ad.9.1775485089463;\n Mon, 06 Apr 2026 07:18:09 -0700 (PDT)","by 2002:a17:902:d50e:b0:2b0:5520:f497 with SMTP id\n d9443c01a7336-2b28164ceeemr137326875ad.9.1775485088830;\n Mon, 06 Apr 2026 07:18:08 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Ani Sinha , Laurent Vivier ,\n Zhao Liu , Stefan Berger ,\n Marcel Apfelbaum ,\n Paolo Bonzini , Fabiano Rosas ,\n marcandre.lureau@redhat.com, \"Michael S. Tsirkin\" ,\n Yanan Wang , Igor Mammedov ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Arun Menon ","Subject":"[PATCH v3 03/10] hw/tpm: Add internal buffer state for chunking","Date":"Mon, 6 Apr 2026 19:47:28 +0530","Message-ID":"<20260406141735.25844-4-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260406141735.25844-1-armenon@redhat.com>","References":"<20260406141735.25844-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\n- Introduce GByteArray buffers to hold the command request and response\n data during chunked TPM CRB transactions.\n- Add helper function to clean them.\n\nSigned-off-by: Arun Menon \n---\n hw/tpm/tpm_crb.c | 34 ++++++++++++++++++++++++++++++----\n 1 file changed, 30 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex bc55908786..d65b3e2cc1 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -38,10 +38,13 @@ struct CRBState {\n TPMBackend *tpmbe;\n TPMBackendCmd cmd;\n uint32_t regs[TPM_CRB_R_MAX];\n+ size_t be_buffer_size;\n MemoryRegion mmio;\n MemoryRegion cmdmem;\n \n- size_t be_buffer_size;\n+ GByteArray *command_buffer;\n+ GByteArray *response_buffer;\n+ uint32_t response_offset;\n \n bool ppi_enabled;\n TPMPPI ppi;\n@@ -85,6 +88,13 @@ enum crb_cancel {\n \n #define TPM_CRB_NO_LOCALITY 0xff\n \n+static void tpm_crb_clear_internal_buffers(CRBState *s)\n+{\n+ g_byte_array_set_size(s->response_buffer, 0);\n+ g_byte_array_set_size(s->command_buffer, 0);\n+ s->response_offset = 0;\n+}\n+\n static uint64_t tpm_crb_mmio_read(void *opaque, hwaddr addr,\n unsigned size)\n {\n@@ -134,9 +144,11 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n }\n break;\n case A_CRB_CTRL_CANCEL:\n- if (val == CRB_CANCEL_INVOKE &&\n- s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n- tpm_backend_cancel_cmd(s->tpmbe);\n+ if (val == CRB_CANCEL_INVOKE) {\n+ if (s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n+ tpm_backend_cancel_cmd(s->tpmbe);\n+ }\n+ tpm_crb_clear_internal_buffers(s);\n }\n break;\n case A_CRB_CTRL_START:\n@@ -240,6 +252,7 @@ static void tpm_crb_reset(void *dev)\n tpm_ppi_reset(&s->ppi);\n }\n tpm_backend_reset(s->tpmbe);\n+ tpm_crb_clear_internal_buffers(s);\n \n memset(s->regs, 0, sizeof(s->regs));\n \n@@ -306,6 +319,9 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n memory_region_add_subregion(get_system_memory(),\n TPM_CRB_ADDR_BASE + sizeof(s->regs), &s->cmdmem);\n \n+ s->command_buffer = g_byte_array_new();\n+ s->response_buffer = g_byte_array_new();\n+\n if (s->ppi_enabled) {\n tpm_ppi_init(&s->ppi, get_system_memory(),\n TPM_PPI_ADDR_BASE, OBJECT(s));\n@@ -318,12 +334,22 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n }\n }\n \n+static void tpm_crb_unrealize(DeviceState *dev)\n+{\n+ CRBState *s = CRB(dev);\n+\n+ g_byte_array_unref(s->command_buffer);\n+ g_byte_array_unref(s->response_buffer);\n+\n+}\n+\n static void tpm_crb_class_init(ObjectClass *klass, const void *data)\n {\n DeviceClass *dc = DEVICE_CLASS(klass);\n TPMIfClass *tc = TPM_IF_CLASS(klass);\n \n dc->realize = tpm_crb_realize;\n+ dc->unrealize = tpm_crb_unrealize;\n device_class_set_props(dc, tpm_crb_properties);\n dc->vmsd = &vmstate_tpm_crb;\n dc->user_creatable = true;\n","prefixes":["v3","03/10"]}