{"id":2219741,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2219741/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260404042015.86580-12-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260404042015.86580-12-mohamed@unpredictable.fr>","date":"2026-04-04T04:20:15","name":"[v6,11/11] whpx: i386: IO port fast path cleanup","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"31475a5ad9d98230a9d0aa6d0b833df4a17e1e62","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260404042015.86580-12-mohamed@unpredictable.fr/mbox/","series":[{"id":498696,"url":"http://patchwork.ozlabs.org/api/1.1/series/498696/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498696","date":"2026-04-04T04:20:05","name":"whpx: i386: bug fixes, feature probing and CPUID","version":6,"mbox":"http://patchwork.ozlabs.org/series/498696/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219741/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219741/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=U/tfDV2e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnj9D5nnzz1yGr\n\tfor ; Sat, 04 Apr 2026 15:22:08 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8sUz-0006qF-IX; Sat, 04 Apr 2026 00:20:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8sUw-0006j2-Je\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 00:20:38 -0400","from p-east2-cluster5-host1-snip4-1.eps.apple.com ([57.103.79.4]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8sUv-000664-1x\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 00:20:38 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-10-percent-0 (Postfix) with ESMTPS id\n 13A2F1800148; Sat, 04 Apr 2026 04:20:34 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-10-percent-0 (Postfix) with ESMTPSA id\n 51D4F1800144; Sat, 04 Apr 2026 04:20:33 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775276436; x=1777868436;\n bh=XF3c7fudpu0e0TEiY2lChefEkznSH2lR6kP+JtXWkz4=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=U/tfDV2eVg4QZOVhxwvPEOKT4EsbDAxLDg5pg91SNf+1G9knwo057DuRM7alN3mfQXNqztJJJn6zpOqWRJHFZ/sDlchNDDqyU1Q0Y41GVI2ucyS/9SPOk2mSLsDA9a4L9mVkmj7nDn1k/jtU5xDfiGA9ZM5gAy/AYqGONcwpyJlVM9o83/spHJbqWF0tZHjbbq5Btquw1l9I684KNv/8naKsoT3XAZn51yDuUqPf99rszGuIr1Duefm37dEjvYO7qoDB0fcvz7qKsABl5lBPnvVvJO7DsgXLNQVu9uAU70PtcaOBJW6MVrbGnmfM3L7w3JAIO77sGmPOvf0xF8QpNA==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Wei Liu , Roman Bolshakov ,\n Pedro Barbuda ,\n Mohamed Mediouni ,\n Phil Dennis-Jordan ,\n Paolo Bonzini , Zhao Liu ","Subject":"[PATCH v6 11/11] whpx: i386: IO port fast path cleanup","Date":"Sat, 4 Apr 2026 06:20:15 +0200","Message-ID":"<20260404042015.86580-12-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260404042015.86580-1-mohamed@unpredictable.fr>","References":"<20260404042015.86580-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"CC1raVW39lRktLU8yaf4N8kamy5I5ksM","X-Authority-Info-Out":"v=2.4 cv=J+2nLQnS c=1 sm=1 tr=0 ts=69d09193\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Vrzv6M8N8vcM0KmfSJEA:9","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA0MDAzNCBTYWx0ZWRfX6RIPgARou4Ox\n DPAETOpkCiSEjcMymtQPQO/UvPMUIe7syU4ZumCLYwrRonJPZPDTU0ZD7SrHk+6ip4r+XlHozcR\n yS54h7x7NDgPDTr3MIlsgbcGzABSi3TOfOfa/G+XmAWi2wAYjuoaAsKe/VUXySao4FM0yj1NJxW\n uTX3ZyTKW5lkKAo/b1BjDzRWBmS5e5j1F0KdUW8dBRFPt32lK+tb3i0Z8AE5zTuk9a2FFtAYw42\n xKnYUAbqMVwRvWAXrfqP5uGUz+3NXmAlSjKL0t5UFrFr2991mi2e1/GV16Y87LhDmd1S5YVht0S\n FVOakwXxCBYCGmyG9a/2araGw8UKt6A6jyOneJKPpLzR40eGpIL7moHYpNKr3M=","X-Proofpoint-GUID":"CC1raVW39lRktLU8yaf4N8kamy5I5ksM","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-03_07,2026-04-03_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0\n lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0\n mlxscore=0 suspectscore=0 clxscore=1030 mlxlogscore=805 phishscore=0\n classifier=spam authscore=0 adjust=0 reason=mlx scancount=1\n engine=8.22.0-2601150000 definitions=main-2604040034","Received-SPF":"pass client-ip=57.103.79.4;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"vmport calls synchronise_state within an I/O port read.\nSupport that properly.\n\nWhat was there before worked because of a side effect of\nwhpx_get_reg synchronising context if cpu->vcpu_dirty.\n\nRemove that whpx_get_reg call in whpx_bump_rip too as it's no longer\nneeded now.\n\nSigned-off-by: Mohamed Mediouni \n---\n target/i386/whpx/whpx-all.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 4810b6387d..ac2671745f 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -861,7 +861,6 @@ static void handle_io(CPUState *env, uint16_t port, void *buffer,\n static void whpx_bump_rip(CPUState *cpu, WHV_RUN_VP_EXIT_CONTEXT *exit_ctx)\n {\n WHV_REGISTER_VALUE reg;\n- whpx_get_reg(cpu, WHvX64RegisterRip, ®);\n reg.Reg64 = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n whpx_set_reg(cpu, WHvX64RegisterRip, reg);\n }\n@@ -889,13 +888,23 @@ static int whpx_handle_portio(CPUState *cpu,\n } else {\n reg.Reg64 = (uint64_t)val;\n }\n- whpx_bump_rip(cpu, exit_ctx);\n- whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ /* vmport calls cpu_synchronize_state on an I/O port read */\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ env->regs[R_EAX] = reg.Reg64;\n+ }\n return 0;\n } else if (!ctx->AccessInfo.StringOp && ctx->AccessInfo.IsWrite) {\n RAX(env) = ctx->Rax;\n handle_io(cpu, ctx->PortNumber, &RAX(env), 1, ctx->AccessInfo.AccessSize, 1);\n- whpx_bump_rip(cpu, exit_ctx);\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ }\n return 0;\n }\n \n","prefixes":["v6","11/11"]}