{"id":2219726,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2219726/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260404012002.111873-3-carlos.bilbao@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260404012002.111873-3-carlos.bilbao@kernel.org>","date":"2026-04-04T01:20:02","name":"[2/2] misc: pci_endpoint_test: remove dead BAR read before doorbell trigger","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"289bc0f4267a0b3d8b939698b10c6d07b6acd944","submitter":{"id":93050,"url":"http://patchwork.ozlabs.org/api/1.1/people/93050/?format=json","name":null,"email":"carlos.bilbao@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260404012002.111873-3-carlos.bilbao@kernel.org/mbox/","series":[{"id":498691,"url":"http://patchwork.ozlabs.org/api/1.1/series/498691/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=498691","date":"2026-04-04T01:20:00","name":"misc: pci_endpoint_test: doorbell fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498691/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219726/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219726/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=HUEUtbzd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-51858-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"HUEUtbzd\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnd7m48d6z1yD3\n\tfor ; Sat, 04 Apr 2026 12:20:36 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 0813E3010230\n\tfor ; Sat, 4 Apr 2026 01:20:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 95939263C7F;\n\tSat, 4 Apr 2026 01:20:08 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 73120273D8F;\n\tSat, 4 Apr 2026 01:20:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 08BA1C4CEF7;\n\tSat, 4 Apr 2026 01:20:08 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775265608; cv=none;\n b=UILycQsDJizlwFAXCTy3dXwDbE/e2j5tjNVf15j9C5gVbMbxBXhBCjbhyHGCtPYIC8Dki8Rscnc9PLNPgSrCnT0/mH91wFoPRVr6VfMIcyqE9iZNYONg9ED/GWR9SMCTrEOfu5rslgJTRpqdOdFX+3fLviw7o17JfIFTWI7FRQk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775265608; c=relaxed/simple;\n\tbh=V3grCh/IvHL38jRC5lY2X4Fg0tr+ZJOpI/LmrS+pa6Y=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=AVgi7FU8szngNdkyP3qHluWxtiWYQUVNao6oNDgJ+Q3k2CetjFTjAdbY8x8WdaUKlrxlbZGAxLyJfiCB7N5stdOGEdWYi12lWEJOFlNqyK2Rs8TSaN2YYZFQtQHvELANtGyKQZlej1qV33VkFoggGWlwn3Z6yO54N4o7/liBGwI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=HUEUtbzd; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775265608;\n\tbh=V3grCh/IvHL38jRC5lY2X4Fg0tr+ZJOpI/LmrS+pa6Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HUEUtbzdKhLyjc6EOrrhoXAoqPJiBI0SbLWgSK7Sod9K91v0P3iXK0RJ32c7jxFNw\n\t 48mW/d8LC4NkMFcmFcCgqB4WzD4DUBVonsLXnNW5ZNXG2+/Ie5qyic6tomuqxG+whO\n\t zy4eSWk1D5YwP3TfcSM7i7JU4lJMDifwcPsGYfLtifRWTlg+MxbwV/fQXm+Yz+KiSd\n\t yrdvAEbxmeo6Q2ScSbOLLamLGoCVEb6oz1ToQSMgWnBoCKemSBDJaCCb8YoNTC0CbM\n\t 7FEpLiz/n4Y81dJYMl3aLiEXZmlKAz29Ov2ZEe5+/I+xh8nACdnQ/ZIJ7Qua5N8rNi\n\t 5IzvLAopuk9eA==","From":"carlos.bilbao@kernel.org","To":"mani@kernel.org,\n\tkwilczynski@kernel.org,\n\tkishon@kernel.org","Cc":"arnd@arndb.de,\n\tgregkh@linuxfoundation.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tbilbao@vt.edu,\n\tCarlos Bilbao ","Subject":"[PATCH 2/2] misc: pci_endpoint_test: remove dead BAR read before\n doorbell trigger","Date":"Fri, 3 Apr 2026 18:20:02 -0700","Message-ID":"<20260404012002.111873-3-carlos.bilbao@kernel.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260404012002.111873-1-carlos.bilbao@kernel.org>","References":"<20260404012002.111873-1-carlos.bilbao@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Carlos Bilbao \n\nThe assignment before the writel sequence is dead code (bar is\nunconditionally overwritten by the re-read immediately after) so remove the\ncall entirely.\n\nNote that the DB_BAR register is a plain value written by the endpoint\nfirmware; reading it carries no side effect.\n\nSigned-off-by: Carlos Bilbao (Lambda) \n---\n drivers/misc/pci_endpoint_test.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c\nindex 276bed3f1c18..07c5f19d5c5a 100644\n--- a/drivers/misc/pci_endpoint_test.c\n+++ b/drivers/misc/pci_endpoint_test.c\n@@ -1081,7 +1081,6 @@ static int pci_endpoint_test_doorbell(struct pci_endpoint_test *test)\n \n \tdata = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_DATA);\n \taddr = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_OFFSET);\n-\tbar = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_BAR);\n \n \tpci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE, irq_type);\n \tpci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, 1);\n","prefixes":["2/2"]}